Opened 18 months ago
Closed 17 months ago
#31963 closed enhancement (fixed)
Replace deprecated alias Polyhedron_base.affine_hull by a new method
Reported by: | Matthias Köppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.4 |
Component: | geometry | Keywords: | |
Cc: | gh-kliem, Jean-Philippe Labbé, Travis Scrimshaw | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Jonathan Kliem |
Report Upstream: | N/A | Work issues: | |
Branch: | dfbd801 (Commits, GitHub, GitLab) | Commit: | dfbd801c8e29afcf318b521d7d918ac747ecca69 |
Dependencies: | #29811 | Stopgaps: |
Description
#29326, renaming affine_hull
to affine_hull_projection
, was merged in 9.1 (released May 21, 2020).
We replace this alias by a new method affine_hull
that ... computes the affine hull as a polyhedron defined by just the equations. This will conform to the ABC for convex sets (#31919)
As a courtesy, if unknown keyword arguments are passed, we point users to the renamed method.
Change History (8)
comment:1 Changed 18 months ago by
Branch: | → u/mkoeppe/replace_deprecated_alias_polyhedron_base_affine_hull_by_a_new_method |
---|
comment:2 Changed 18 months ago by
Authors: | → Matthias Koeppe |
---|---|
Commit: | → d37c710af666e887ae3c85c4b8194c94e7702f7b |
Dependencies: | #31919 → #31919, #29811 |
Status: | new → needs_review |
comment:3 Changed 17 months ago by
Cc: | Travis Scrimshaw added |
---|---|
Dependencies: | #31919, #29811 → #29811 |
comment:4 Changed 17 months ago by
Reviewers: | → Jonathan Kliem |
---|
You should add the method to the polyhedron quickref in docs.
Otherwise it's good to go. Had a green bot weeks ago and everything still works.
comment:5 Changed 17 months ago by
Commit: | d37c710af666e887ae3c85c4b8194c94e7702f7b → dfbd801c8e29afcf318b521d7d918ac747ecca69 |
---|
comment:6 Changed 17 months ago by
Status: | needs_review → positive_review |
---|
comment:8 Changed 17 months ago by
Branch: | u/mkoeppe/replace_deprecated_alias_polyhedron_base_affine_hull_by_a_new_method → dfbd801c8e29afcf318b521d7d918ac747ecca69 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
src/sage/geometry/convex_set.py: More examples and tests
ConvexSet_base._test_convex_set: Fix doctest output
ConvexSet_base.codim, codimension: New
ConvexSet_base: Make dimension, ambient_dimension aliases for dim, ambient_dim
ConvexSet_base.cartesian_product: New
ConvexSet_base.contains, intersection: New
Merge #31919
PolyhedronFace.affine_tangent_cone: New
Merge #29811
Polyhedron_base.affine_hull: New, replace deprecated alias for affine_hull_projection