Opened 6 months ago

Closed 5 months ago

#31963 closed enhancement (fixed)

Replace deprecated alias Polyhedron_base.affine_hull by a new method

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.4
Component: geometry Keywords:
Cc: gh-kliem, jipilab, tscrim Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: dfbd801 (Commits, GitHub, GitLab) Commit: dfbd801c8e29afcf318b521d7d918ac747ecca69
Dependencies: #29811 Stopgaps:

Status badges

Description

#29326, renaming affine_hull to affine_hull_projection, was merged in 9.1 (released May 21, 2020).

We replace this alias by a new method affine_hull that ... computes the affine hull as a polyhedron defined by just the equations. This will conform to the ABC for convex sets (#31919)

As a courtesy, if unknown keyword arguments are passed, we point users to the renamed method.

Change History (8)

comment:1 Changed 6 months ago by mkoeppe

  • Branch set to u/mkoeppe/replace_deprecated_alias_polyhedron_base_affine_hull_by_a_new_method

comment:2 Changed 6 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to d37c710af666e887ae3c85c4b8194c94e7702f7b
  • Dependencies changed from #31919 to #31919, #29811
  • Status changed from new to needs_review

Last 10 new commits:

9a7ce3asrc/sage/geometry/convex_set.py: More examples and tests
e2b0ef7ConvexSet_base._test_convex_set: Fix doctest output
45c840aConvexSet_base.codim, codimension: New
17467c4ConvexSet_base: Make dimension, ambient_dimension aliases for dim, ambient_dim
fa5dc6eConvexSet_base.cartesian_product: New
f4bdffdConvexSet_base.contains, intersection: New
465b0cbMerge #31919
5965400PolyhedronFace.affine_tangent_cone: New
3f13401Merge #29811
d37c710Polyhedron_base.affine_hull: New, replace deprecated alias for affine_hull_projection

comment:3 Changed 5 months ago by mkoeppe

  • Cc tscrim added
  • Dependencies changed from #31919, #29811 to #29811

comment:4 Changed 5 months ago by gh-kliem

  • Reviewers set to Jonathan Kliem

You should add the method to the polyhedron quickref in docs.

Otherwise it's good to go. Had a green bot weeks ago and everything still works.

comment:5 Changed 5 months ago by git

  • Commit changed from d37c710af666e887ae3c85c4b8194c94e7702f7b to dfbd801c8e29afcf318b521d7d918ac747ecca69

Branch pushed to git repo; I updated commit sha1. New commits:

314e46aMerge tag '9.4.beta4' into t/31963/replace_deprecated_alias_polyhedron_base_affine_hull_by_a_new_method
dfbd801src/doc/en/thematic_tutorials/geometry/polyhedra_quickref.rst: Add affine_hull

comment:6 Changed 5 months ago by gh-kliem

  • Status changed from needs_review to positive_review

comment:7 Changed 5 months ago by mkoeppe

Thanks!

comment:8 Changed 5 months ago by vbraun

  • Branch changed from u/mkoeppe/replace_deprecated_alias_polyhedron_base_affine_hull_by_a_new_method to dfbd801c8e29afcf318b521d7d918ac747ecca69
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.