Opened 18 months ago

Last modified 17 months ago

#31959 closed enhancement

PolyhedronFace: Make it a subclass of ConvexSet_closed — at Version 5

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.4
Component: geometry Keywords:
Cc: gh-kliem, Jean-Philippe Labbé, Travis Scrimshaw Merged in:
Authors: Matthias Koeppe Reviewers:
Report Upstream: N/A Work issues:
Branch: u/mkoeppe/polyhedronface__make_it_a_subclass_of_convexset_closed (Commits, GitHub, GitLab) Commit: e66448ea0b3de1286595ef4af19fe95c5d9ef18e
Dependencies: #31919 Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

... we only need to be careful with the method ambient_dim, which is the dimension of the polyhedron, not of the space.

So in this ticket we add:

  • the method ambient to ConvexSet, which is allowed to be a containing convex set, not necessarily a space,
  • the method ambient_vector_space, which is always a vector space (even if ambient is only a free module).

Change History (5)

comment:1 Changed 18 months ago by Matthias Köppe

Branch: u/mkoeppe/polyhedronface__make_it_a_subclass_of_convexset_closed

comment:2 Changed 18 months ago by git

Commit: 8d77b3e67c27e24ccae8e529eddb4beece0e8a30

Branch pushed to git repo; I updated commit sha1. New commits:

8d77b3ePolyhedronFace.is_relatively_open, is_compact: New, add doctests

comment:3 Changed 18 months ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: Travis Scrimshaw added
Description: modified (diff)
Status: newneeds_review

comment:4 Changed 18 months ago by git

Commit: 8d77b3e67c27e24ccae8e529eddb4beece0e8a30e66448ea0b3de1286595ef4af19fe95c5d9ef18e

Branch pushed to git repo; I updated commit sha1. New commits:

6ba5d9cConvexSet_base.ambient_vector_space: New
e66448ePolyhedronFace.contains, ConvexSet_base._test_contains: New

comment:5 Changed 18 months ago by Matthias Köppe

Description: modified (diff)
Note: See TracTickets for help on using tickets.