#31938 closed enhancement (fixed)

Wrapper class for Sage sets as SymPy sets

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.4
Component: interfaces Keywords:
Cc: kcrisman, tscrim Merged in:
Authors: Matthias Koeppe Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c06c965 (Commits, GitHub, GitLab) Commit: c06c965d81713d698d6e6a73c69f3473aa26e1b2
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

We add a _sympy_ method to all sets. It creates an instance of the new class sage.interfaces.sympy_wrapper.SageSet, which is a subclass of SymPy's Set class.

Part of Meta-ticket #31926: Connect Sage sets to sympy sets

Change History (14)

comment:1 Changed 13 months ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 13 months ago by mkoeppe

  • Branch set to u/mkoeppe/wrapper_class_for_sage_sets_as_sympy_sets

comment:3 Changed 13 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc kcrisman added
  • Commit set to 6e5cac6491592b1d451b400de5e4f1b722db9c20

Here's a beginning. This obviously needs many more examples/tests


New commits:

6e5cac6sage.interfaces.sympy_wrapper, Sets.ParentMethods._sympy_: New

comment:4 Changed 13 months ago by git

  • Commit changed from 6e5cac6491592b1d451b400de5e4f1b722db9c20 to 3cac256c1af8a67ec21b90fbcb206a5001b635e8

Branch pushed to git repo; I updated commit sha1. New commits:

3cac256sage.interfaces.sympy_wrapper: Add doctests

comment:5 Changed 13 months ago by git

  • Commit changed from 3cac256c1af8a67ec21b90fbcb206a5001b635e8 to eef604e8e5e6441eed11fa4c86c6277fd8318277

Branch pushed to git repo; I updated commit sha1. New commits:

eef604eSageSet: Finish docstrings; handle symbolic _contains

comment:6 Changed 13 months ago by mkoeppe

  • Cc tscrim added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:7 Changed 13 months ago by git

  • Commit changed from eef604e8e5e6441eed11fa4c86c6277fd8318277 to 2baae58a51cd4f136cf0f89e3e6484804983908b

Branch pushed to git repo; I updated commit sha1. New commits:

2baae58Sets.ParentMethods._sympy_: Call sympy_init

comment:8 Changed 13 months ago by tscrim

I know it is not so useful, but please add a doctest for __new__. Perhaps running a TestSuite? Other than that, LGTM assume a green bot.

comment:9 Changed 13 months ago by git

  • Commit changed from 2baae58a51cd4f136cf0f89e3e6484804983908b to c06c965d81713d698d6e6a73c69f3473aa26e1b2

Branch pushed to git repo; I updated commit sha1. New commits:

c06c965sage.interfaces.sympy_wrapper.SageSet: Add another doctest

comment:10 Changed 13 months ago by tscrim

Thank you. Now once the bot comes back green, positive review.

comment:11 Changed 13 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

comment:12 Changed 13 months ago by tscrim

  • Status changed from needs_review to positive_review

comment:13 Changed 13 months ago by mkoeppe

Thanks!

comment:14 Changed 12 months ago by vbraun

  • Branch changed from u/mkoeppe/wrapper_class_for_sage_sets_as_sympy_sets to c06c965d81713d698d6e6a73c69f3473aa26e1b2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.