Opened 14 months ago

Closed 14 months ago

#31928 closed defect (fixed)

Failure when testing sage_conf version

Reported by: vbraun Owned by:
Priority: critical Milestone: sage-9.4
Component: build Keywords:
Cc: jhpalmieri, dimpase, slelievre, mkoeppe Merged in:
Authors: Matthias Koeppe Reviewers: Thierry Monteil
Report Upstream: N/A Work issues:
Branch: 8b6441e (Commits, GitHub, GitLab) Commit: 8b6441ea78e86d30c15660f192d9adaef8bb2a2f
Dependencies: Stopgaps:

Status badges

Description

Incremental builds fail when crossing a Sage version 

**********************************************************************
File "src/sage/misc/package.py", line 359, in sage.misc.package.installed_packages
Failed example:
    installed_packages()['sage_conf'] == sage.env.SAGE_VERSION # optional - build
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   1 of   4 in sage.misc.package.installed_packages
    [52 tests, 1 failure, 4.40 s]
----------------------------------------------------------------------

Change History (9)

comment:1 Changed 14 months ago by tmonteil

  • Priority changed from major to critical

I set this ticket to critical as it breaks all patchbots, see ​https://patchbot.sagemath.org/ticket/0/

comment:2 Changed 14 months ago by jhpalmieri

We can use the fix originally proposed in #31577: 

installed_packages()['sage_conf']  # optional - build, random

Other ideas?

comment:3 Changed 14 months ago by tmonteil

What is the initial goal of this doctest ? If it is useless why not simply remove it ?

comment:4 Changed 14 months ago by mkoeppe

  • Branch set to u/mkoeppe/failure_when_testing_sage_conf_version

comment:5 Changed 14 months ago by mkoeppe

  • Commit set to 8b6441ea78e86d30c15660f192d9adaef8bb2a2f

I think the original intention of the doctest was to show a package without a version. But there is no longer such a package that is guaranteed to be installed.

So I have just removed it.

New commits:

​8b6441einstalled_packages: Remove problematic test for sage_conf's version

comment:6 Changed 14 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Status changed from new to needs_review

comment:7 Changed 14 months ago by tmonteil

  • Reviewers set to Thierry Monteil
  • Status changed from needs_review to positive_review

Good move.

comment:8 Changed 14 months ago by mkoeppe

Thanks!

comment:9 Changed 14 months ago by vbraun

  • Branch changed from u/mkoeppe/failure_when_testing_sage_conf_version to 8b6441ea78e86d30c15660f192d9adaef8bb2a2f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.