Opened 6 months ago

Closed 5 months ago

#31927 closed enhancement (fixed)

RealSet: Replace is_included_in, is_disjoint_from by is_subset, is_disjoint

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.4
Component: geometry Keywords:
Cc: tscrim, gh-mjungmath Merged in:
Authors: Matthias Koeppe Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f27026f (Commits, GitHub, GitLab) Commit: f27026f2f9675c1bf47bcd64916dd5af5751d106
Dependencies: #21243 Stopgaps:

Status badges

Description (last modified by mkoeppe)

is_included_in is only defined by RealSet. We deprecate it and replace it by is_subset.

The spelling issubset is used in Python sets. is_subset is widely used in Sage. Sympy provides both spellings (see #31926), but the source code notes that issubset "should be deprecated".

Change History (13)

comment:1 Changed 6 months ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 6 months ago by mkoeppe

  • Branch set to u/mkoeppe/realset__replace_is_included_in_by_is_subset___issubset

comment:3 Changed 6 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 9079a1030aabaa3042a968dab7cf12526597cb29
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

9079a10RealSet.is_subset: Rename from is_included_in

comment:4 Changed 6 months ago by mkoeppe

  • Summary changed from RealSet: Replace is_included_in by is_subset / issubset to RealSet: Replace is_included_in by is_subset

comment:5 Changed 6 months ago by mkoeppe

  • Status changed from needs_review to needs_work
  • Summary changed from RealSet: Replace is_included_in by is_subset to RealSet: Replace is_included_in, is_disjoint_from by is_subset, is_disjoint

comment:6 Changed 6 months ago by git

  • Commit changed from 9079a1030aabaa3042a968dab7cf12526597cb29 to 4bc5a2c98192b207c8578928cefbc144a7e14a7e

Branch pushed to git repo; I updated commit sha1. New commits:

5b8cecaInternalRealInterval, RealSet: Add _latex_ methods
69ca854RealSet._repr_: Use unicode cup sign instead of +
dbdfc06InternalRealInterval, RealSet: Remove extra whitespace in latex, add documentation
a0e3bf5Merge #31880
181b128RealSet.is_open, is_closed, closure, interior, boundary: New
7f56338PiecewiseFunction: Adjust doctests for changed RealSet repr
8cd74b5Merge #31880
8fdb104RealSet.boundary: Add another doctest
0a2f499Merge #21243
4bc5a2cRealSet.is_disjoint: Rename from is_disjoint_from

comment:7 Changed 6 months ago by mkoeppe

  • Dependencies set to #21243
  • Status changed from needs_work to needs_review

comment:8 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

Can you also open a followup ticket (or on the original tickets or here) some quick fixes of some little things I missed during my previous reviews (sorry!):

  • #31880 Add # -*- coding: utf-8 -*- to the top of piecewise.py.
  • #21243 Remove the itertools import.

comment:9 Changed 6 months ago by mkoeppe

Thanks! I have updated these tickets.

comment:10 Changed 6 months ago by git

  • Commit changed from 4bc5a2c98192b207c8578928cefbc144a7e14a7e to f27026f2f9675c1bf47bcd64916dd5af5751d106
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

9d41f0esrc/sage/sets/real_set.py: Remove unnecessary import
f27026fMerge #21243

comment:11 Changed 6 months ago by mkoeppe

  • Status changed from needs_review to positive_review

comment:12 Changed 6 months ago by tscrim

Thank you.

comment:13 Changed 5 months ago by vbraun

  • Branch changed from u/mkoeppe/realset__replace_is_included_in_by_is_subset___issubset to f27026f2f9675c1bf47bcd64916dd5af5751d106
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.