Opened 18 months ago
Closed 18 months ago
#31927 closed enhancement (fixed)
RealSet: Replace is_included_in, is_disjoint_from by is_subset, is_disjoint
Reported by:  Matthias Köppe  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  geometry  Keywords:  
Cc:  Travis Scrimshaw, Michael Jung  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  f27026f (Commits, GitHub, GitLab)  Commit:  f27026f2f9675c1bf47bcd64916dd5af5751d106 
Dependencies:  #21243  Stopgaps: 
Description (last modified by )
is_included_in
is only defined by RealSet
. We deprecate it and replace it by is_subset
.
The spelling issubset
is used in Python sets. is_subset
is widely used in Sage. Sympy provides both spellings (see #31926), but the source code notes that issubset
"should be deprecated".
Change History (13)
comment:1 Changed 18 months ago by
Description:  modified (diff) 

comment:2 Changed 18 months ago by
Branch:  → u/mkoeppe/realset__replace_is_included_in_by_is_subset___issubset 

comment:3 Changed 18 months ago by
Authors:  → Matthias Koeppe 

Commit:  → 9079a1030aabaa3042a968dab7cf12526597cb29 
Description:  modified (diff) 
Status:  new → needs_review 
comment:4 Changed 18 months ago by
Summary:  RealSet: Replace is_included_in by is_subset / issubset → RealSet: Replace is_included_in by is_subset 

comment:5 Changed 18 months ago by
Status:  needs_review → needs_work 

Summary:  RealSet: Replace is_included_in by is_subset → RealSet: Replace is_included_in, is_disjoint_from by is_subset, is_disjoint 
comment:6 Changed 18 months ago by
Commit:  9079a1030aabaa3042a968dab7cf12526597cb29 → 4bc5a2c98192b207c8578928cefbc144a7e14a7e 

Branch pushed to git repo; I updated commit sha1. New commits:
5b8ceca  InternalRealInterval, RealSet: Add _latex_ methods

69ca854  RealSet._repr_: Use unicode cup sign instead of +

dbdfc06  InternalRealInterval, RealSet: Remove extra whitespace in latex, add documentation

a0e3bf5  Merge #31880

181b128  RealSet.is_open, is_closed, closure, interior, boundary: New

7f56338  PiecewiseFunction: Adjust doctests for changed RealSet repr

8cd74b5  Merge #31880

8fdb104  RealSet.boundary: Add another doctest

0a2f499  Merge #21243

4bc5a2c  RealSet.is_disjoint: Rename from is_disjoint_from

comment:7 Changed 18 months ago by
Dependencies:  → #21243 

Status:  needs_work → needs_review 
comment:8 Changed 18 months ago by
Reviewers:  → Travis Scrimshaw 

Status:  needs_review → positive_review 
comment:10 Changed 18 months ago by
Commit:  4bc5a2c98192b207c8578928cefbc144a7e14a7e → f27026f2f9675c1bf47bcd64916dd5af5751d106 

Status:  positive_review → needs_review 
comment:11 Changed 18 months ago by
Status:  needs_review → positive_review 

comment:13 Changed 18 months ago by
Branch:  u/mkoeppe/realset__replace_is_included_in_by_is_subset___issubset → f27026f2f9675c1bf47bcd64916dd5af5751d106 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
New commits:
RealSet.is_subset: Rename from is_included_in