#31927 closed enhancement (fixed)

RealSet: Replace is_included_in, is_disjoint_from by is_subset, is_disjoint

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.4
Component: geometry Keywords:
Cc: Travis Scrimshaw, Michael Jung Merged in:
Authors: Matthias Koeppe Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f27026f (Commits, GitHub, GitLab) Commit: f27026f2f9675c1bf47bcd64916dd5af5751d106
Dependencies: #21243 Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

is_included_in is only defined by RealSet. We deprecate it and replace it by is_subset.

The spelling issubset is used in Python sets. is_subset is widely used in Sage. Sympy provides both spellings (see #31926), but the source code notes that issubset "should be deprecated".

Change History (13)

comment:1 Changed 16 months ago by Matthias Köppe

Description: modified (diff)

comment:2 Changed 16 months ago by Matthias Köppe

Branch: u/mkoeppe/realset__replace_is_included_in_by_is_subset___issubset

comment:3 Changed 16 months ago by Matthias Köppe

Authors: Matthias Koeppe
Commit: 9079a1030aabaa3042a968dab7cf12526597cb29
Description: modified (diff)
Status: newneeds_review

New commits:

9079a10RealSet.is_subset: Rename from is_included_in

comment:4 Changed 16 months ago by Matthias Köppe

Summary: RealSet: Replace is_included_in by is_subset / issubsetRealSet: Replace is_included_in by is_subset

comment:5 Changed 16 months ago by Matthias Köppe

Status: needs_reviewneeds_work
Summary: RealSet: Replace is_included_in by is_subsetRealSet: Replace is_included_in, is_disjoint_from by is_subset, is_disjoint

comment:6 Changed 16 months ago by git

Commit: 9079a1030aabaa3042a968dab7cf12526597cb294bc5a2c98192b207c8578928cefbc144a7e14a7e

Branch pushed to git repo; I updated commit sha1. New commits:

5b8cecaInternalRealInterval, RealSet: Add _latex_ methods
69ca854RealSet._repr_: Use unicode cup sign instead of +
dbdfc06InternalRealInterval, RealSet: Remove extra whitespace in latex, add documentation
a0e3bf5Merge #31880
181b128RealSet.is_open, is_closed, closure, interior, boundary: New
7f56338PiecewiseFunction: Adjust doctests for changed RealSet repr
8cd74b5Merge #31880
8fdb104RealSet.boundary: Add another doctest
0a2f499Merge #21243
4bc5a2cRealSet.is_disjoint: Rename from is_disjoint_from

comment:7 Changed 16 months ago by Matthias Köppe

Dependencies: #21243
Status: needs_workneeds_review

comment:8 Changed 16 months ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

Can you also open a followup ticket (or on the original tickets or here) some quick fixes of some little things I missed during my previous reviews (sorry!):

  • #31880 Add # -*- coding: utf-8 -*- to the top of piecewise.py.
  • #21243 Remove the itertools import.

comment:9 Changed 16 months ago by Matthias Köppe

Thanks! I have updated these tickets.

comment:10 Changed 16 months ago by git

Commit: 4bc5a2c98192b207c8578928cefbc144a7e14a7ef27026f2f9675c1bf47bcd64916dd5af5751d106
Status: positive_reviewneeds_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

9d41f0esrc/sage/sets/real_set.py: Remove unnecessary import
f27026fMerge #21243

comment:11 Changed 16 months ago by Matthias Köppe

Status: needs_reviewpositive_review

comment:12 Changed 16 months ago by Travis Scrimshaw

Thank you.

comment:13 Changed 15 months ago by Volker Braun

Branch: u/mkoeppe/realset__replace_is_included_in_by_is_subset___issubsetf27026f2f9675c1bf47bcd64916dd5af5751d106
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.