Opened 12 months ago
Closed 11 months ago
#31888 closed defect (fixed)
Fixes to src/setup.py (used when configure --enable-editable is used)
Reported by: | isuruf | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-9.4 |
Component: | build | Keywords: | |
Cc: | mkoeppe, gh-tobiasdiez, gh-kliem | Merged in: | |
Authors: | Isuru Fernando, Matthias Koeppe | Reviewers: | Jonathan Kliem |
Report Upstream: | N/A | Work issues: | |
Branch: | cca587d (Commits, GitHub, GitLab) | Commit: | cca587d298600ba6cc2a0172788bce2805540f1d |
Dependencies: | Stopgaps: |
Description (last modified by )
Fixes:
- Include submodules in
find_namespace_packages
: Without this, only the extensions and top level .py files are installed and .py files in submodules are not installed.
- Do not catch and ignore build errors
Change History (10)
comment:1 Changed 12 months ago by
- Status changed from new to needs_review
comment:2 Changed 12 months ago by
comment:3 Changed 12 months ago by
- Cc gh-tobiasdiez added
For distribution packaging, use build/pkgs/sagelib/src/setup.py
comment:4 Changed 11 months ago by
- Description modified (diff)
- Summary changed from Include submodules in find_namespace_packages to Fixes to src/setup.py (used when configure --enable-editable is used)
comment:5 Changed 11 months ago by
- Branch changed from u/isuruf/submodules to u/mkoeppe/submodules
comment:6 Changed 11 months ago by
- Commit changed from 78862cd565e68e2d35dd6eb48e637cd9e6c255d8 to cca587d298600ba6cc2a0172788bce2805540f1d
comment:7 Changed 11 months ago by
- Cc gh-kliem added
comment:8 Changed 11 months ago by
- Reviewers set to Jonathan Kliem
- Status changed from needs_review to positive_review
LGTM.
comment:9 Changed 11 months ago by
Thanks!
comment:10 Changed 11 months ago by
- Branch changed from u/mkoeppe/submodules to cca587d298600ba6cc2a0172788bce2805540f1d
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
src/setup.py
is used by the Sage distribution only whenconfigure --enable-editable
has been used, which has not seen much testing yet.