Opened 8 months ago

Closed 7 months ago

#31876 closed enhancement (fixed)

Update maxima to 5.45.0

Reported by: arojas Owned by:
Priority: major Milestone: sage-9.4
Component: packages: standard Keywords:
Cc: fbissey, mkoeppe, isuruf, saraedum, pbruin Merged in:
Authors: Antonio Rojas Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: e32e2c0 (Commits, GitHub, GitLab) Commit: e32e2c060b5469f2a23dfa590c1d688db2227f70
Dependencies: Stopgaps:

Status badges

Description (last modified by arojas)

Previous update: #30063

A few changes in some tests output.

Change History (6)

comment:1 Changed 8 months ago by arojas

  • Branch set to u/arojas/update_maxima_to_5_45_0

comment:2 Changed 8 months ago by arojas

  • Authors set to Antonio Rojas
  • Cc fbissey mkoeppe isuruf saraedum pbruin added
  • Commit set to e32e2c060b5469f2a23dfa590c1d688db2227f70
  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

New commits:

1d94204Update maxima to 5.45.0
e32e2c0Update tests for maxima 5.45

comment:3 follow-up: Changed 8 months ago by arojas

The modified test in src/sage/calculus/functional.py seems to have the variables reversed. It seems to me that it's meant to compute the inverse of the previous result, or am I missing something? Currently it computes the ilt of a constant, which is kind of pointless.

comment:4 in reply to: ↑ 3 Changed 8 months ago by pbruin

Replying to arojas:

The modified test in src/sage/calculus/functional.py seems to have the variables reversed. It seems to me that it's meant to compute the inverse of the previous result, or am I missing something? Currently it computes the ilt of a constant, which is kind of pointless.

You are right, but actually the example itself is fishy since the variable of the Laplace transform (a in this case) already appears in the function being transformed. I would suggest simplifying the example as follows (also fixing whitespace):

  • src/sage/calculus/functional.py

    a b EXAMPLES: We illustrate each of the calculus functional functions. 
    2222    a
    2323    sage: taylor(a*sin(x)/x, x, 0, 4)
    2424    1/120*a*x^4 - 1/6*a*x^2 + a
    25     sage: expand( (x-a)^3 )
     25    sage: expand((x - a)^3)
    2626    -a^3 + 3*a^2*x - 3*a*x^2 + x^3
    27     sage: laplace( e^(x+a), x, a)
    28     e^a/(a - 1)
    29     sage: inverse_laplace( e^a/(a-1), x, a)
    30     ilt(e^a/(a - 1), x, a)
     27    sage: laplace(e^x, x, a)
     28    1/(a - 1)
     29    sage: inverse_laplace(1/(a - 1), a, x)
     30    e^x
    3131"""
    3232
    3333from .calculus import SR

This already succeeds with the current Maxima version.

Apart from that, it would be nice to have a doctest in src/sage/calculus/calculus.py showing that taking the inverse Laplace transform of a constant now returns a delta function.

comment:5 Changed 8 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

OK, good, thanks!

comment:6 Changed 7 months ago by vbraun

  • Branch changed from u/arojas/update_maxima_to_5_45_0 to e32e2c060b5469f2a23dfa590c1d688db2227f70
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.