Opened 15 months ago
Closed 14 months ago
#31858 closed defect (fixed)
Fix translation of univariate Gamma from FriCAS
Reported by:  mantepse  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  interfaces  Keywords:  fricas 
Cc:  chapoton, slelievre  Merged in:  
Authors:  Martin Rubey  Reviewers:  Thierry Monteil 
Report Upstream:  N/A  Work issues:  
Branch:  bec32a1 (Commits, GitHub, GitLab)  Commit:  bec32a1159ad9eef2f8abdd9440fd042662a3b27 
Dependencies:  Stopgaps: 
Description (last modified by )
Change History (7)
comment:1 Changed 15 months ago by
comment:2 Changed 15 months ago by
 Branch set to u/mantepse/tranlation_of_univariate_gamma_from_fricas_is_broken
comment:3 Changed 15 months ago by
 Commit set to e785da44e02d8b48cb7c1fd02017027bbd2b4788
 Status changed from new to needs_review
New commits:
e785da4  fix translation of Gamma

comment:4 Changed 15 months ago by
 Commit changed from e785da44e02d8b48cb7c1fd02017027bbd2b4788 to bec32a1159ad9eef2f8abdd9440fd042662a3b27
Branch pushed to git repo; I updated commit sha1. New commits:
bec32a1  add classical doctest

comment:5 Changed 15 months ago by
 Cc slelievre added
 Description modified (diff)
 Summary changed from tranlation of univariate Gamma from fricas is broken to Fix translation of univariate Gamma from FriCAS
comment:6 Changed 15 months ago by
 Reviewers set to Thierry Monteil
 Status changed from needs_review to positive_review
LGTM.
comment:7 Changed 14 months ago by
 Branch changed from u/mantepse/tranlation_of_univariate_gamma_from_fricas_is_broken to bec32a1159ad9eef2f8abdd9440fd042662a3b27
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
The problem is that, in
src/sage/functions/gamma.py
, we havewhich attaches
fricas.Gamma
to the bivariate gamma function, not the symbolic function: