Opened 14 months ago

Closed 7 months ago

Last modified 7 months ago

#31855 closed defect (fixed)

Upgrade gmpy2 to add python 3.10 support

Reported by: mkoeppe Owned by:
Priority: critical Milestone: sage-9.5
Component: packages: standard Keywords:
Cc: vdelecroix, dimpase, mjo, fbissey Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: 41f7f4e (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

gmpy2 fails to build with Python 3.10: error: ‘_PyHASH_NAN’ undeclared - ​https://bugzilla.redhat.com/show_bug.cgi?id=1959010 ...

2.1.0rc1 has a fix.

Change History (32)

comment:1 Changed 14 months ago by mkoeppe

  • Branch set to u/mkoeppe/patch_upgrade_gmpy2_to_add_python_3_10_support

comment:2 Changed 14 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to 8cd9ece1cb6942ee612bf7aff9cfad41d0946c2e
  • Status changed from new to needs_review

New commits:

​8cd9ecebuild/pkgs/gmpy2/patches: Add patches from Fedora @python/python3.10

comment:3 Changed 13 months ago by vdelecroix

Why not use upstream patch ​https://github.com/aleaxit/gmpy/pull/297?

comment:4 follow-up: Changed 13 months ago by mkoeppe

No idea, why doesn't upstream make a proper release at some point?

comment:5 in reply to: ↑ 4 ; follow-up: Changed 13 months ago by vdelecroix

Replying to mkoeppe:

No idea, why doesn't upstream make a proper release at some point?

No idea, worth asking. Though the patch was merged a week ago.

comment:6 Changed 13 months ago by mkoeppe

  • Cc dimpase added

comment:7 in reply to: ↑ 5 Changed 13 months ago by dimpase

  • Report Upstream changed from N/A to Reported upstream. No feedback yet.

Replying to vdelecroix:

Replying to mkoeppe:

No idea, why doesn't upstream make a proper release at some point?

No idea, worth asking. Though the patch was merged a week ago.

I've opened ​https://github.com/aleaxit/gmpy/issues/303

comment:8 Changed 13 months ago by dimpase

How about using the upstream patch ​https://patch-diff.githubusercontent.com/raw/aleaxit/gmpy/pull/297.diff instead?

comment:9 Changed 12 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5

comment:10 Changed 10 months ago by mkoeppe

Looks like upstream is preparing a proper release now - ​https://github.com/aleaxit/gmpy/commit/97424526eaf30ed33390d7b12d20d411583c6322

comment:11 Changed 10 months ago by git

  • Commit changed from 8cd9ece1cb6942ee612bf7aff9cfad41d0946c2e to 41f7f4ef9b3d4353fb4ca700d1f12e1bff919265

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​41f7f4ebuild/pkgs/gmpy2: Update to 2.1.0rc1

comment:12 Changed 10 months ago by mkoeppe

  • Description modified (diff)
  • Summary changed from Patch/upgrade gmpy2 to add python 3.10 support to Upgrade gmpy2 to add python 3.10 support

comment:13 Changed 10 months ago by mkoeppe

  • Report Upstream changed from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.

comment:14 Changed 10 months ago by mkoeppe

  • Cc mjo added

comment:15 Changed 10 months ago by mkoeppe

  • Reviewers set to https://github.com/mkoeppe/sage/actions/runs/1242854091, https://github.com/mkoeppe/sage/actions/runs/1242854090

comment:16 Changed 10 months ago by mjo

OK by me when the GH actions finish. Everyone is already using beta5, so it's not like rc1 is a step down in purported release quality.

comment:17 Changed 9 months ago by mkoeppe

  • Priority changed from major to critical

Let's get this in please.

comment:18 Changed 8 months ago by enriqueartal

I am in Fedora 35 now and I would like to test it. I can use python3.10 (following the hack of the packager of sagemath in Fedora) but I do not know how to deal with cysignals. Any clue?

comment:19 Changed 8 months ago by mkoeppe

See #32576 for cysignals

comment:20 Changed 8 months ago by enriqueartal

I saw it but I am not how to deal with it. Apparently in Fedora they were able to compile cysignals and to use it as a system package.

comment:21 Changed 8 months ago by mkoeppe

You can help on #32576 by reviewing the proposed changes to cysignals

comment:22 Changed 8 months ago by enriqueartal

This is the status. I used the configure file of sagemath.spec in fedora which allows to use python3.10.0 in the system. Using the link in #32576 I used the revised cysignals, and I also used gmpy2.1.0rc1, both are compiled. The only unsuccessful package is pyzmq; the fedora system package python3-zmq exists and I was able to recompile it locally. The error in Sage is:

gcc build/temp.linux-x86_64-3.9/tmp/timer_createq5lapz40.o -o build/temp.linux-x86_64-3.9/a.out

error: [Errno 2] No such file or directory: 'a.out'

It happens with 22.2.1 and 22.0.3 I do not know how to use the system package for this.

comment:23 Changed 8 months ago by mkoeppe

I have opened #32828 for the issues with pyzmq. I think they are unrelated to python 3.10

comment:24 Changed 8 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/1242854091, https://github.com/mkoeppe/sage/actions/runs/1242854090 to https://github.com/mkoeppe/sage/actions/runs/1429845185, https://github.com/mkoeppe/sage/actions/runs/1429845182

comment:25 Changed 8 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/1429845185, https://github.com/mkoeppe/sage/actions/runs/1429845182 to https://github.com/mkoeppe/sage/actions/runs/1430376300

comment:26 Changed 8 months ago by mkoeppe

Tests look good, let's please get this update in.

comment:27 Changed 8 months ago by mkoeppe

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/1430376300 to https://github.com/mkoeppe/sage/actions/runs/1430376304, https://github.com/mkoeppe/sage/actions/runs/1430376300

comment:28 Changed 8 months ago by mkoeppe

  • Cc fbissey added

comment:29 Changed 8 months ago by dimpase

  • Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/1430376304, https://github.com/mkoeppe/sage/actions/runs/1430376300 to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:30 Changed 8 months ago by mkoeppe

Thanks!

comment:31 Changed 7 months ago by vbraun

  • Branch changed from u/mkoeppe/patch_upgrade_gmpy2_to_add_python_3_10_support to 41f7f4ef9b3d4353fb4ca700d1f12e1bff919265
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:32 Changed 7 months ago by dimpase

  • Commit 41f7f4ef9b3d4353fb4ca700d1f12e1bff919265 deleted

gmpy2 stable version 2.1 has been released.

Note: See TracTickets for help on using tickets.