Opened 5 months ago

Closed 4 months ago

#31854 closed enhancement (fixed)

Pass name and latex_name to copy method in set_restriction

Reported by: gh-mjungmath Owned by:
Priority: major Milestone: sage-9.4
Component: manifolds Keywords:
Cc: tscrim, egourgoulhon Merged in:
Authors: Michael Jung Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f2d37a1 (Commits, GitHub, GitLab) Commit: f2d37a10436b79f9425cf1f224d6ee9bd48a0869
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-mjungmath)

This makes the code a little bit nicer.

Change History (4)

comment:1 Changed 5 months ago by gh-mjungmath

  • Authors set to Michael Jung
  • Cc tscrim egourgoulhon added
  • Component changed from PLEASE CHANGE to manifolds
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Scalarfield set names in set_restriction to Pass name and latex_name to copy method in set_restriction
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 5 months ago by gh-mjungmath

  • Branch set to u/gh-mjungmath/scalarfield_set_names_in_set_restriction

comment:3 Changed 5 months ago by tscrim

  • Commit set to f2d37a10436b79f9425cf1f224d6ee9bd48a0869
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

New commits:

​f2d37a1Trac #31854: pass name and latex_name to copy method

comment:4 Changed 4 months ago by vbraun

  • Branch changed from u/gh-mjungmath/scalarfield_set_names_in_set_restriction to f2d37a10436b79f9425cf1f224d6ee9bd48a0869
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.