#31853 closed enhancement (fixed)

conversion of polygamma to fricas

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.4
Component: interfaces: optional Keywords: fricas
Cc: mantepse, slelievre Merged in:
Authors: Frédéric Chapoton Reviewers: Martin Rubey, Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: c77da15 (Commits, GitHub, GitLab) Commit: c77da15982f82935844ec215f3d3a5a1bd842a70
Dependencies: Stopgaps:

Status badges

Description (last modified by slelievre)

Related:

  • #31858: Fix translation of univariate Gamma from FriCAS
  • #25597: Translate bivariate Gamma from FriCAS

Change History (16)

comment:1 Changed 14 months ago by chapoton

  • Branch set to u/chapoton/31853
  • Commit set to 9d86cb93eebcb7df10753813314c2ba82fe0b49e
  • Status changed from new to needs_review

New commits:

3c04187Fixing single function and variable with solution_dict solve() corner case.
0b17b06Merge branch 'public/symbolics/solution_dict_list-31452' of ssh://trac.sagemath.org:22/sage into essai
9d86cb9conversion of polygamma to fricas

comment:2 Changed 14 months ago by git

  • Commit changed from 9d86cb93eebcb7df10753813314c2ba82fe0b49e to 7a6a6bf65c75cd087e09fc3d9459a5dbb1d4d8ba

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7a6a6bfconvert polygamma to fricas

comment:3 Changed 14 months ago by chapoton

  • Cc mantepse added

comment:4 Changed 14 months ago by mantepse

Could you add polygamma, too, and also include a test along the following lines to make sure that the functions really are the same (unfortunately, both fricas and sage have gaps in the implementation, in different aspects)?

sage: fricas.digamma(1.0)
- 0.5772156649_0153286061
sage: psi(1.0)
-0.577215664901533
sage: fricas.polygamma(1, 1.0)
1.6449340668482269
sage: psi(1, 1.0)
psi(1, 1.00000000000000)
sage: psi(1, 1)
1/6*pi^2
sage: psi(1, 1).n()
1.64493406684823

This might fit with the test in lines 1465-- in fricas.py.

comment:5 Changed 14 months ago by git

  • Commit changed from 7a6a6bf65c75cd087e09fc3d9459a5dbb1d4d8ba to 8c363596f23af0ddfa1c57d096079907a6485c07

Branch pushed to git repo; I updated commit sha1. New commits:

8c36359add doctests for fricas digamma and polygamma

comment:6 Changed 14 months ago by chapoton

polygamma is added already. Did you mean something else ?

I have added your suggested doctests.

comment:7 Changed 14 months ago by mantepse

  • Branch changed from u/chapoton/31853 to u/mantepse/31853

comment:8 Changed 14 months ago by mantepse

  • Branch changed from u/mantepse/31853 to u/chapoton/31853

Oh, sorry, I overlooked this. I noticed that we can also should translate euler_gamma, I took the liberty to add this, too. If you are happy with this, please set the ticket to positive review on my behalf.

comment:9 Changed 14 months ago by mantepse

  • Branch changed from u/chapoton/31853 to u/mantepse/31853

comment:10 Changed 14 months ago by slelievre

  • Cc slelievre added
  • Commit changed from 8c363596f23af0ddfa1c57d096079907a6485c07 to c77da15982f82935844ec215f3d3a5a1bd842a70
  • Description modified (diff)

New commits:

c77da15add translation from euler_gamma

comment:11 Changed 14 months ago by mantepse

  • Reviewers set to Martin Rubey

comment:12 Changed 13 months ago by chapoton

ok, looks good. Can we set to positive ?

comment:13 Changed 13 months ago by mantepse

  • Reviewers changed from Martin Rubey to Martin Rubey, Frédéric Chapoton
  • Status changed from needs_review to positive_review

comment:14 Changed 13 months ago by mantepse

comment:15 Changed 13 months ago by mantepse

I also fixed #28647 now. I'd be very grateful for a review, so things don't break again.

comment:16 Changed 13 months ago by vbraun

  • Branch changed from u/mantepse/31853 to c77da15982f82935844ec215f3d3a5a1bd842a70
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.