Opened 15 months ago
Closed 14 months ago
#31848 closed defect (fixed)
Random failure: sage.libs.gap.util.GAPError: Error, OnSets: <set> must be a set
Reported by:  vbraun  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  group theory  Keywords:  random_fail 
Cc:  Merged in:  
Authors:  Vincent Delecroix  Reviewers:  Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  03cee82 (Commits, GitHub, GitLab)  Commit:  03cee8203ed5852e71eb01e1c4a071a01fa98b22 
Dependencies:  Stopgaps: 
Description
# for i in `seq 0 25` ; do sage t long src/sage/graphs/graph.py ; done [...]  Total time for all tests: 11.6 seconds cpu time: 10.7 seconds cumulative wall time: 11.4 seconds Pytest is not installed, skip checking tests that rely on it. Running doctests with ID 2021052311204127ccab84. Git branch: develop Using optional=build,dochtml,fedora,pip,sage,sage_spkg Doctesting 1 file. sage t long warnlong 44.4 randomseed=0 src/sage/graphs/graph.py ********************************************************************** File "src/sage/graphs/graph.py", line 2713, in sage.graphs.graph.Graph.is_edge_transitive Failed example: C.is_edge_transitive() Exception raised: Traceback (most recent call last): File "/home/release/Sage/local/lib64/python3.9/sitepackages/sage/doctest/forker.py", line 714, in _run self.compile_and_execute(example, compiler, test.globs) File "/home/release/Sage/local/lib64/python3.9/sitepackages/sage/doctest/forker.py", line 1133, in compile_and_execute exec(compiled, globs) File "<doctest sage.graphs.graph.Graph.is_edge_transitive[3]>", line 1, in <module> C.is_edge_transitive() File "/home/release/Sage/local/lib64/python3.9/sitepackages/sage/graphs/graph.py", line 2731, in is_edge_transitive return libgap(A).OrbitLength(e, libgap.OnSets) == self.size() File "sage/libs/gap/element.pyx", line 2677, in sage.libs.gap.element.GapElement_MethodProxy.__call__ (build/cythonized/sage/libs/gap/element.c:20776) return GapElement_Function.__call__(self, * ([self.first_argument] + list(args))) File "sage/libs/gap/element.pyx", line 2525, in sage.libs.gap.element.GapElement_Function.__call__ (build/cythonized/sage/libs/gap/element.c:19780) sig_on() sage.libs.gap.util.GAPError: Error, OnSets: <set> must be a set (not a immutable nonstrictlysorted plain list of cyclotomics) ********************************************************************** 1 item had failures: 1 of 9 in sage.graphs.graph.Graph.is_edge_transitive [1216 tests, 1 failure, 11.14 s]  sage t long warnlong 44.4 randomseed=0 src/sage/graphs/graph.py # 1 doctest failed  Total time for all tests: 11.3 seconds cpu time: 10.4 seconds cumulative wall time: 11.1 seconds Pytest is not installed, skip checking tests that rely on it. Running doctests with ID 202105231120556956bb7d. Git branch: develop Using optional=build,dochtml,fedora,pip,sage,sage_spkg Doctesting 1 file. sage t long warnlong 44.4 randomseed=0 src/sage/graphs/graph.py [1216 tests, 11.18 s]  All tests passed! 
Change History (12)
comment:1 Changed 15 months ago by
 Keywords random_fail added
comment:2 Changed 15 months ago by
 Keywords random_fail removed
comment:3 Changed 15 months ago by
 Keywords random_fail added
comment:4 Changed 15 months ago by
Already present in Sage 9.3
comment:5 Changed 15 months ago by
is it by any chance fixed by updating GAP to 4.11.1 ?
comment:6 Changed 15 months ago by
the update is on https://trac.sagemath.org/ticket/31498  needs review
comment:7 Changed 15 months ago by
Can even loop on the single command
$ sagedev c 'graphs.CubeGraph(3).is_edge_transitive()
Version 0, edited 15 months ago
by
(next)
comment:8 Changed 15 months ago by
 Branch set to u/vdelecroix/31848
 Commit set to 03cee8203ed5852e71eb01e1c4a071a01fa98b22
 Status changed from new to needs_review
New commits:
03cee82  31848: fix a random failure in is_edge_transitive

comment:9 followup: ↓ 10 Changed 15 months ago by
This is also reproducible in a GAP console
gap> OrbitLength(SymmetricGroup(5), [1,2], OnSets); 10 gap> OrbitLength(SymmetricGroup(5), [2,1], OnSets); Error, OnSets: <set> must be a set (not a immutable nonstrictlysorted plain list of cyclotomics)
comment:10 in reply to: ↑ 9 Changed 15 months ago by
Replying to vdelecroix:
This is also reproducible in a GAP console
gap> OrbitLength(SymmetricGroup(5), [1,2], OnSets); 10 gap> OrbitLength(SymmetricGroup(5), [2,1], OnSets); Error, OnSets: <set> must be a set (not a immutable nonstrictlysorted plain list of cyclotomics)
this seems to work in GAP 4.11.1 : #31498
comment:11 Changed 15 months ago by
 Reviewers set to Dima Pasechnik
 Status changed from needs_review to positive_review
the doctest fix is good.
comment:12 Changed 14 months ago by
 Branch changed from u/vdelecroix/31848 to 03cee8203ed5852e71eb01e1c4a071a01fa98b22
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Possibly ? related to https://github.com/gapsystem/gap/commit/965b1c69de723492202659c4c5e53b369d766f11