Opened 8 months ago

Closed 6 months ago

#31823 closed enhancement (fixed)

Obtain flexible maximal chains of a combinatorial polyhedron

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.4
Component: geometry Keywords: combinatorial polyhedron, maximal chain
Cc: jipilab, mkoeppe, yzh, tscrim Merged in:
Authors: Jonathan Kliem Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 98efbbf (Commits, GitHub, GitLab) Commit: 98efbbf15ff4866f4608cc4a4c27005cf75d60a3
Dependencies: #31822 Stopgaps:

Status badges

Description

We allow obtaining more flexible maximal chains specifying an index for a vertex and/or facet.

Change History (10)

comment:1 Changed 8 months ago by gh-kliem

  • Status changed from new to needs_review

comment:2 Changed 8 months ago by gh-kliem

  • Status changed from needs_review to needs_work

Needs rebase.

comment:3 Changed 7 months ago by mkoeppe

What's the status here?

comment:4 Changed 7 months ago by gh-kliem

  • Branch changed from u/gh-kliem/flexible_maximal_chains to u/gh-kliem/flexible_maximal_chains-reb
  • Commit changed from 29a787145635ad02ad4e13d6ac40c8612ed4c3ee to 11e024ae52fe433d5b9020ac9bcf5eaf2a045988
  • Dependencies changed from #31821, #31822 to #31822
  • Status changed from needs_work to needs_review

Last 10 new commits:

​4c0a4aeinitialize do_f_vector
​542baeemerge in #31245
​3e0229fMerge tag '9.4.beta3' into t/31834/public/31834-reb2
​8190917Merge #31834
​7f7e630Merge #29683
​ac5c327Merge #31819
​2e5908esimplify a maximal chain
​10f6519specify Vindex and/or Hindex for maximal chain
​1ba63c4fix search for Hindex in dual case
​11e024aadd test method for a maximal chain

comment:5 Changed 7 months ago by mkoeppe

  • Cc yzh tscrim added

comment:6 Changed 7 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

It would be good to indicate in the the _test method what is randomized in the test. Other than that, LGTM.

comment:7 Changed 7 months ago by git

  • Commit changed from 11e024ae52fe433d5b9020ac9bcf5eaf2a045988 to 98efbbf15ff4866f4608cc4a4c27005cf75d60a3

Branch pushed to git repo; I updated commit sha1. New commits:

​98efbbfdocument what is random in _test_a_maximal_chain

comment:8 Changed 7 months ago by mkoeppe

Is anything missing here for positive review?

comment:9 Changed 7 months ago by tscrim

  • Status changed from needs_review to positive_review

Nope, LGTM. I didn't get an email for the pushed commit and I forgot to check back to this ticket.

comment:10 Changed 6 months ago by vbraun

  • Branch changed from u/gh-kliem/flexible_maximal_chains-reb to 98efbbf15ff4866f4608cc4a4c27005cf75d60a3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.