Opened 15 months ago
Closed 13 months ago
#31823 closed enhancement (fixed)
Obtain flexible maximal chains of a combinatorial polyhedron
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.4 |
Component: | geometry | Keywords: | combinatorial polyhedron, maximal chain |
Cc: | jipilab, mkoeppe, yzh, tscrim | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 98efbbf (Commits, GitHub, GitLab) | Commit: | 98efbbf15ff4866f4608cc4a4c27005cf75d60a3 |
Dependencies: | #31822 | Stopgaps: |
Description
We allow obtaining more flexible maximal chains specifying an index for a vertex and/or facet.
Change History (10)
comment:1 Changed 15 months ago by
- Status changed from new to needs_review
comment:2 Changed 15 months ago by
- Status changed from needs_review to needs_work
comment:3 Changed 14 months ago by
What's the status here?
comment:4 Changed 14 months ago by
- Branch changed from u/gh-kliem/flexible_maximal_chains to u/gh-kliem/flexible_maximal_chains-reb
- Commit changed from 29a787145635ad02ad4e13d6ac40c8612ed4c3ee to 11e024ae52fe433d5b9020ac9bcf5eaf2a045988
- Dependencies changed from #31821, #31822 to #31822
- Status changed from needs_work to needs_review
Last 10 new commits:
4c0a4ae | initialize do_f_vector
|
542baee | merge in #31245
|
3e0229f | Merge tag '9.4.beta3' into t/31834/public/31834-reb2
|
8190917 | Merge #31834
|
7f7e630 | Merge #29683
|
ac5c327 | Merge #31819
|
2e5908e | simplify a maximal chain
|
10f6519 | specify Vindex and/or Hindex for maximal chain
|
1ba63c4 | fix search for Hindex in dual case
|
11e024a | add test method for a maximal chain
|
comment:5 Changed 14 months ago by
- Cc yzh tscrim added
comment:6 Changed 14 months ago by
- Reviewers set to Travis Scrimshaw
It would be good to indicate in the the _test
method what is randomized in the test. Other than that, LGTM.
comment:7 Changed 14 months ago by
- Commit changed from 11e024ae52fe433d5b9020ac9bcf5eaf2a045988 to 98efbbf15ff4866f4608cc4a4c27005cf75d60a3
Branch pushed to git repo; I updated commit sha1. New commits:
98efbbf | document what is random in _test_a_maximal_chain
|
comment:8 Changed 13 months ago by
Is anything missing here for positive review?
comment:9 Changed 13 months ago by
- Status changed from needs_review to positive_review
Nope, LGTM. I didn't get an email for the pushed commit and I forgot to check back to this ticket.
comment:10 Changed 13 months ago by
- Branch changed from u/gh-kliem/flexible_maximal_chains-reb to 98efbbf15ff4866f4608cc4a4c27005cf75d60a3
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Needs rebase.