Opened 5 months ago
Closed 3 months ago
#31821 closed enhancement (fixed)
Run tests on combinatorial polyhedron
Reported by: | gh-kliem | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.4 |
Component: | geometry | Keywords: | |
Cc: | jipilab, mkoeppe | Merged in: | |
Authors: | Jonathan Kliem | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | b285d95 (Commits, GitHub, GitLab) | Commit: | b285d958fab3bcb034fcc9f90191e3600bc25c55 |
Dependencies: | #31820 | Stopgaps: |
Description
We add a method _test_combinatorial_polyhedron
to Polyhedron_base
that runs the test suite on the combinatorial polyhedron.
We fix pickling of the combinatorial polyhedron in case there are equations by pickling from the matrix instead of a list of facets. This way the incidences will be exactly the same including the incidences corresponding to equations.
Change History (7)
comment:1 Changed 5 months ago by
- Status changed from new to needs_review
comment:2 Changed 5 months ago by
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
comment:3 Changed 5 months ago by
- Summary changed from Run tests on combinatorial polyehdron to Run tests on combinatorial polyhedron
comment:4 Changed 5 months ago by
comment:5 Changed 5 months ago by
- Status changed from positive_review to needs_info
Oops, wrong ticket. Deleted my previous comment which was meant for #31822.
comment:6 Changed 5 months ago by
- Status changed from needs_info to positive_review
Back to positive review, sorry for the noise.
comment:7 Changed 3 months ago by
- Branch changed from u/gh-kliem/test_combinatorial_polyhedron to b285d958fab3bcb034fcc9f90191e3600bc25c55
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Thank you.