Opened 9 months ago
Closed 7 months ago
#31798 closed enhancement (fixed)
ManifoldSubset.difference, complement
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  manifolds  Keywords:  
Cc:  egourgoulhon, ghmjungmath  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Eric Gourgoulhon 
Report Upstream:  N/A  Work issues:  
Branch:  2113f78 (Commits, GitHub, GitLab)  Commit:  2113f788564abcfe08176998b4d2132b11b5aede 
Dependencies:  #31764  Stopgaps: 
Description
We implement ManifoldSubset.difference
by making a new subset and declaring a disjoint union (#31764)
Change History (16)
comment:1 Changed 9 months ago by
 Branch set to u/mkoeppe/manifoldsubset_difference__complement
comment:2 Changed 9 months ago by
 Commit set to 3786cee241f6097efc8a695dc3f9b6913584f4b7
 Status changed from new to needs_review
comment:3 Changed 9 months ago by
 Status changed from needs_review to needs_work
Patchbot seems not to like it.
comment:4 Changed 9 months ago by
 Commit changed from 3786cee241f6097efc8a695dc3f9b6913584f4b7 to 6370e88a31ff2eba67b753ec1bacb424dc86aa5d
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
6370e88  ManifoldSubset.difference, complement: New

comment:5 followup: ↓ 6 Changed 9 months ago by
 Status changed from needs_work to needs_review
Let's see what the patchbot thinks now
comment:6 in reply to: ↑ 5 Changed 9 months ago by
comment:7 Changed 9 months ago by
Btw, with Python 3, shouldn't the non_ascii
plugin be removed from the pathbot? It generates a false alarm here.
comment:8 Changed 9 months ago by
 Commit changed from 6370e88a31ff2eba67b753ec1bacb424dc86aa5d to e7f7a7d4445ebdcb01b1dbfc42205c71e7b276e9
Branch pushed to git repo; I updated commit sha1. New commits:
94edd68  ManifoldSubset.declare_superset: Fix documentation

41826b4  ManifoldSubset.declare_{sub,super}set: Expand docstring

3ef5141  Merge #31763

79a625b  ManifoldSubset._reduce_intersection_members: Add examples, raise TypeError if input is empty family

8e70023  ManifoldSubset._reduce_union_members: Add examples

ee4efc9  ManifoldSubset._{union,intersection}_subset: Do cache the result here; add examples

e7f7a7d  Merge #31764

comment:9 Changed 8 months ago by
 Commit changed from e7f7a7d4445ebdcb01b1dbfc42205c71e7b276e9 to 8d3ad854f87a640e7e0713deffd3dd73c42991e1
comment:10 Changed 8 months ago by
I don't understand the pyflakes errors reported by the patchbot. Do you?
comment:11 followup: ↓ 12 Changed 8 months ago by
The patchbot report at the very top refers to the commit before I merged in the latest version of #31764.
comment:12 in reply to: ↑ 11 Changed 8 months ago by
 Reviewers set to Eric Gourgoulhon
 Status changed from needs_review to positive_review
comment:13 Changed 8 months ago by
Thanks for the review!
comment:14 Changed 7 months ago by
 Commit changed from 8d3ad854f87a640e7e0713deffd3dd73c42991e1 to 2113f788564abcfe08176998b4d2132b11b5aede
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
359dde1  Merge branch 't/31727/manifoldsubset__add_methods_subset_family__superset_family__equal_subset_family__deprecate_method_list_of_subsets' into t/31732/manifoldsubset__new_methods_declare_empty__declare_nonempty__is_empty__has_defined_points__open_cover_family

0e9e5cd  Merge #31732

fd4506a  Merge #31732

a96f736  Merge #31736

7fed9ef  Merge #31736

c4acd09  Merge tag '9.4.beta2' into t/31763/manifoldsubset__new_methods_declare_subset__declare_superset

582b58d  Merge #31763

2113f78  Merge #31764

comment:15 Changed 7 months ago by
 Status changed from needs_review to positive_review
Trivial merge with update dependency
comment:16 Changed 7 months ago by
 Branch changed from u/mkoeppe/manifoldsubset_difference__complement to 2113f788564abcfe08176998b4d2132b11b5aede
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
ManifoldSubset.intersection: Go through ManifoldSubsetFiniteFamily to make the order of operations canonical
ManifoldSubset._union_subset: Factor out from ManifoldSubset.union
ManifoldSubset.union: Handle arbitrary unions
ManifoldSubset.union: Add example and plots
ManifoldSubset.declare_union: Handle arbitrary unions
src/sage/manifolds/subset.py: import itertools
ManifoldSubset._intersection_subset, _union_subset: Use declare_subset, declare_superset; fix doctest
ManifoldSubset._union_subset: Fixup
Merge #31764
ManifoldSubset.difference, complement: New