Opened 5 months ago

Closed 4 months ago

#31784 closed defect (fixed)

Mixed form name bug for pullback bundle

Reported by: gh-mjungmath Owned by:
Priority: major Milestone: sage-9.4
Component: manifolds Keywords:
Cc: egourgoulhon, tscrim Merged in:
Authors: Michael Jung Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: bd5031b (Commits, GitHub, GitLab) Commit: bd5031bb8570c073fc2ebe5a0473559f0f670508
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-mjungmath)

sage: E3 = EuclideanSpace(3)
sage: S2 = E3.sphere()
sage: iota = S2.embedding()
sage: Omega = S2.mixed_form_algebra(dest_map=iota)
sage: Omega(1)
Mixed differential form one along the {} with values on the {} Mixed differential form one along the 2-sphere S^2 of radius 1 smoothly embedded in the Euclidean space E^3 with values on the Euclidean space E^3 via the map iota

Change History (11)

comment:1 Changed 5 months ago by gh-mjungmath

  • Authors set to Michael Jung
  • Cc egourgoulhon tscrim added
  • Component changed from PLEASE CHANGE to manifolds
  • Description modified (diff)
  • Type changed from PLEASE CHANGE to defect

comment:2 Changed 5 months ago by gh-mjungmath

  • Branch set to u/gh-mjungmath/mixed_form_name_bug_for_pullback_bundle

comment:3 Changed 5 months ago by gh-mjungmath

  • Commit set to af19b9cdb5ab099b8c729c881189182c63944106
  • Status changed from new to needs_review

New commits:

af19b9cTrac 31784: fix repr for destination maps

comment:4 Changed 5 months ago by gh-mjungmath

We need more examples for those cases. At the moment, this is not caught by many tests. Similarly for tensor fields by the way.

comment:5 Changed 5 months ago by gh-mjungmath

But this should do for the moment.

comment:6 Changed 5 months ago by git

  • Commit changed from af19b9cdb5ab099b8c729c881189182c63944106 to bd5031bb8570c073fc2ebe5a0473559f0f670508

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

bd5031bTrac 31784: fix repr for destination maps

comment:7 Changed 5 months ago by gh-mjungmath

  • Description modified (diff)

comment:8 Changed 5 months ago by gh-mjungmath

Patchbot green.

comment:9 Changed 5 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:10 Changed 5 months ago by gh-mjungmath

Thank you for the review.

comment:11 Changed 4 months ago by vbraun

  • Branch changed from u/gh-mjungmath/mixed_form_name_bug_for_pullback_bundle to bd5031bb8570c073fc2ebe5a0473559f0f670508
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.