Opened 16 months ago

Closed 14 months ago

#31759 closed defect (fixed)

Fix bug in WordMorphism.periodic_point

Reported by: gh-mrejmon Owned by:
Priority: major Milestone: sage-9.4
Component: combinatorics Keywords: words
Cc: Merged in:
Authors: Martin Rejmon Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 18097e9 (Commits, GitHub, GitLab) Commit: 18097e91dfd36648810d2f01594a2c08aa2fd28b
Dependencies: Stopgaps:

Status badges

Description

WordMorphism.periodic_point loops endlessly on bounded letters with period larger than 1, for example: 

sage: WordMorphism('a->b,b->a').periodic_point('a')

This is fixed by this patch.

Change History (4)

comment:1 Changed 16 months ago by git

  • Commit changed from 7de85c8bafc9c60b6d77df242ece117563122588 to 18097e91dfd36648810d2f01594a2c08aa2fd28b

Branch pushed to git repo; I updated commit sha1. New commits:

​18097e931759: Add a regression test

comment:2 Changed 16 months ago by gh-mrejmon

  • Status changed from new to needs_review

comment:3 Changed 16 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 14 months ago by vbraun

  • Branch changed from u/gh-mrejmon/fix_periodic_v2 to 18097e91dfd36648810d2f01594a2c08aa2fd28b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.