Opened 19 months ago
Closed 18 months ago
#31736 closed enhancement (fixed)
ManifoldSubset: New methods declare_equal, equal_subsets, equal_subset_family
Reported by:  Matthias Köppe  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  manifolds  Keywords:  
Cc:  Eric Gourgoulhon, Michael Jung, Travis Scrimshaw  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Eric Gourgoulhon 
Report Upstream:  N/A  Work issues:  
Branch:  fd4506a (Commits, GitHub, GitLab)  Commit:  fd4506aabb6636a2028e050c3ab1b5e6041eec89 
Dependencies:  #31727, #31732  Stopgaps: 
Description
Two subsets are equal if they are subsets of each other.
We add methods equal_subsets
, equal_subset_family
; and a method declare_equal
to make two or more subsets equal.
We modify the method subset_poset
and superset_poset
to quotient out by equality.
Change History (17)
comment:1 Changed 19 months ago by
Branch:  → u/mkoeppe/manifoldsubset__new_methods_declare_equal__equal_subsets__equal_subset_family 

comment:2 Changed 19 months ago by
Commit:  → c9fd9f748ff870f2dc2fc474214e0f403d9a9872 

Status:  new → needs_review 
comment:3 Changed 19 months ago by
Commit:  c9fd9f748ff870f2dc2fc474214e0f403d9a9872 → e06932b1449e78e0bfc63dd48ae545ee3834275b 

comment:4 Changed 19 months ago by
Shouldn't we have
def equal_subset_family(self):  return ManifoldSubsetFiniteFamily(self.supersets()) + return ManifoldSubsetFiniteFamily(self.equal_subsets())
comment:5 Changed 19 months ago by
Commit:  e06932b1449e78e0bfc63dd48ae545ee3834275b → 93b8aa3ed701c5f500f5615f4de8ee0849b5b187 

Branch pushed to git repo; I updated commit sha1. New commits:
93b8aa3  ManifoldSubset.equal_subset_family: Fixup

comment:7 Changed 19 months ago by
Another comment: your name should appear in the AUTHORS
field of src/sage/manifolds/subset.py
, and possibly in other files, like src/sage/manifolds/topological_submanifold.py
; such a field should also be added to src/sage/manifolds/family.py
.
comment:8 Changed 19 months ago by
Commit:  93b8aa3ed701c5f500f5615f4de8ee0849b5b187 → 5c7bb75171a85d8097917d58eb301f7b05ef9100 

Branch pushed to git repo; I updated commit sha1. New commits:
5c7bb75  src/sage/manifolds/{family,manifold,subset,differentiable/manifold,**/*_submanifold}.py: Update authors, copyright

comment:9 followup: 13 Changed 19 months ago by
(I used git blame w date=format:%Y src/sage/manifolds/manifold.py  sort k2
to determine what copyright years to add.)
comment:10 Changed 19 months ago by
Status:  needs_review → needs_work 

comment:11 Changed 19 months ago by
Commit:  5c7bb75171a85d8097917d58eb301f7b05ef9100 → f244b8770b7cd3eb7d66e04586d39af7992a4588 

Branch pushed to git repo; I updated commit sha1. New commits:
f244b87  ManifoldSubset.subset_digraph: Do not forget to include isolated vertices

comment:12 Changed 19 months ago by
Status:  needs_work → needs_review 

comment:13 Changed 19 months ago by
Reviewers:  → Eric Gourgoulhon 

Status:  needs_review → positive_review 
Replying to mkoeppe:
(I used
git blame w date=format:%Y src/sage/manifolds/manifold.py  sort k2
to determine what copyright years to add.)
Thanks!
comment:15 Changed 18 months ago by
Commit:  f244b8770b7cd3eb7d66e04586d39af7992a4588 → fd4506aabb6636a2028e050c3ab1b5e6041eec89 

Status:  positive_review → needs_review 
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
359dde1  Merge branch 't/31727/manifoldsubset__add_methods_subset_family__superset_family__equal_subset_family__deprecate_method_list_of_subsets' into t/31732/manifoldsubset__new_methods_declare_empty__declare_nonempty__is_empty__has_defined_points__open_cover_family

fd4506a  Merge #31732

comment:16 Changed 18 months ago by
Status:  needs_review → positive_review 

Merged updated #31732 to resolve merge conflict
comment:17 Changed 18 months ago by
Branch:  u/mkoeppe/manifoldsubset__new_methods_declare_equal__equal_subsets__equal_subset_family → fd4506aabb6636a2028e050c3ab1b5e6041eec89 

Resolution:  → fixed 
Status:  positive_review → closed 
Last 10 new commits:
ManifoldSubset.open_covers: Add option supersets; use it to fix is_empty
ManifoldSubset.open_cover_family: Add option supersets
Fix doctests
ManifoldSubset.declare_empty: Add plot
src/sage/manifolds/subset.py: Remove unused import, make doctest stable by using 'sorted'
Merge #31732
ManifoldSubsetFiniteFamily.from_subsets_or_families: New constructor
ManifoldSubset.equal_subsets, equal_subset_family: New
ManifoldSubset.{subset,superset}_digraph: New option quotient; use it for {subset,superset}_poset
ManifoldSubset.declare_equal: New