Opened 7 months ago

Closed 5 months ago

#31734 closed enhancement (fixed)

Add linestyle option to polygon2d

Reported by: slelievre Owned by:
Priority: major Milestone: sage-9.4
Component: graphics Keywords:
Cc: slelievre, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8012677 (Commits, GitHub, GitLab) Commit: 8012677b2f39e72c42c6fdcfd95ca038125cad40
Dependencies: Stopgaps:

Status badges

Description

Requested at

In Sage 9.3.rc4: 

sage: polygon2d([(1, 1), (0, 1), (1, 0)], fill=False, linestyle="dashed")
... WARNING: Ignoring option 'linestyle'=dashed ...
The allowed options for Polygon ... are:
alpha ... edgecolor ... fill ... hue ... legend_color ...
legend_label ... rgbcolor ... thickness ... zorder ...

Change History (6)

comment:1 Changed 7 months ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch set to u/chapoton/31734
  • Status changed from new to needs_review

comment:2 Changed 7 months ago by git

  • Commit set to 8012677b2f39e72c42c6fdcfd95ca038125cad40

Branch pushed to git repo; I updated commit sha1. New commits:

​8012677add linestyle option to polygon

comment:3 Changed 7 months ago by chapoton

here is a tentative

comment:4 Changed 7 months ago by chapoton

  • Cc tscrim added

green bot, please review

comment:5 Changed 7 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 5 months ago by vbraun

  • Branch changed from u/chapoton/31734 to 8012677b2f39e72c42c6fdcfd95ca038125cad40
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.