Opened 6 months ago

Closed 4 months ago

#31727 closed enhancement (fixed)

ManifoldSubset: Add methods subset_family, superset_family, open_superset_family; deprecate method list_of_subsets

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.4
Component: manifolds Keywords:
Cc: egourgoulhon, gh-mjungmath, tscrim Merged in:
Authors: Matthias Koeppe Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: 2b47b1b (Commits, GitHub, GitLab) Commit: 2b47b1b4573d19fc8c9201a379d255cc67631c11
Dependencies: #31718, #31677 Stopgaps:

Status badges

Description (last modified by mkoeppe)

Follow-up from #31718.

This ticket proposes to deprecate list_of_subsets (note - no other methods in sage.manifolds follow this naming scheme) in favor of a new method subset_family, which prints in a more compact way, is hashable, and is sorted by name too.

We also add superset_family (previously the set of supersets was not exposed by a method).

We also add open_superset_family (to complement open_superset added in #31677).

Change History (19)

comment:1 Changed 6 months ago by mkoeppe

  • Branch set to u/mkoeppe/manifoldsubset__add_methods_subset_family__superset_family__equal_subset_family__deprecate_method_list_of_subsets

comment:2 Changed 6 months ago by mkoeppe

  • Commit set to 52a93f94de48c0fb7070f95b170cd218d7ddfc15
  • Dependencies set to #31718

Last 10 new commits:

5d87ceeManifold{Object,Subset}FiniteFamily: Rename from FiniteManifold{Object,Subset}Family
2f2ace2src/doc/en/reference/manifolds/manifold.rst: Add sage.manifolds.family
1aff58aFix up docstring markup
b922066ManifoldSubsetFiniteFamily: If all subsets are open, include 'open' in repr
30271afFixup doctest
adac07aMerge #31680
78cc27aManifoldSubset.open_covers: Change to generator, add optional arg 'trivial'; update uses
e026e7aManifoldSubset.subset_digraph: Use open_covers method
3c5555aMerge #31718
52a93f9ManifoldSubset.subset_family: New; deprecate .list_of_subsets

comment:3 Changed 6 months ago by git

  • Commit changed from 52a93f94de48c0fb7070f95b170cd218d7ddfc15 to f1bc8bc9cd3c49a4beb64a8a4b4ecbf04d7a3b37

Branch pushed to git repo; I updated commit sha1. New commits:

f1bc8bcManifoldSubset.superset_family: New, use it in doctests

comment:4 Changed 6 months ago by mkoeppe

  • Dependencies changed from #31718 to #31718, #31677

comment:5 Changed 6 months ago by git

  • Commit changed from f1bc8bc9cd3c49a4beb64a8a4b4ecbf04d7a3b37 to 59553f7408ec98f32f18ee2cf7fc81703653bacd

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

ef1614aRefactor Manifold.open_subset methods through new method _init_open_subset
265b0e2TopologicalManifold._init_open_subset: Add docstring
a93f7edTopologicalSubmanifold._init_open_subset: Add docstring
58b43f7DifferentiableManifold._init_open_subset: Add docstring
d542412ManifoldSubset.open_supersets: New generator, use it to fix loops that assume open supersets
c821a75{Topological,...}Manifold.open_subset: New optional parameter supersets
b35eca1ManifoldSubset.{open_subset,_init_open_subset}: New
afe10a0Merge #31677
cd1fa4dManifoldSubset.open_superset_family: New
59553f7ManifoldSubset.open_cover_family: New

comment:6 Changed 6 months ago by mkoeppe

  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from ManifoldSubset: Add methods subset_family, superset_family, equal_subset_family; deprecate method list_of_subsets to ManifoldSubset: Add methods subset_family, superset_family, open_superset_family, open_cover_family; deprecate method list_of_subsets

comment:7 Changed 6 months ago by git

  • Commit changed from 59553f7408ec98f32f18ee2cf7fc81703653bacd to fc23784527c66e6287625a720edc12c85740ccb6

Branch pushed to git repo; I updated commit sha1. New commits:

fc23784ManifoldSubset.open_cover_family: Fix up docstring

comment:8 Changed 6 months ago by mkoeppe

  • Status changed from needs_review to needs_work

comment:9 Changed 6 months ago by git

  • Commit changed from fc23784527c66e6287625a720edc12c85740ccb6 to d5127e531ad364666bd2d27a3609e7f4af273698

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d5127e5ManifoldSubset.open_cover_family: New

comment:10 Changed 6 months ago by mkoeppe

  • Status changed from needs_work to needs_review

comment:11 Changed 6 months ago by mkoeppe

  • Description modified (diff)
  • Summary changed from ManifoldSubset: Add methods subset_family, superset_family, open_superset_family, open_cover_family; deprecate method list_of_subsets to ManifoldSubset: Add methods subset_family, superset_family, open_superset_family; deprecate method list_of_subsets

comment:12 Changed 6 months ago by git

  • Commit changed from d5127e531ad364666bd2d27a3609e7f4af273698 to cd1fa4da5745b5ed358405d0613aec17a976d30d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

comment:13 Changed 6 months ago by mkoeppe

Removed the last commit; the addition of open_cover_family will now happen in #31732 instead.

comment:14 Changed 6 months ago by mkoeppe

Ready for review.

comment:15 Changed 6 months ago by git

  • Commit changed from cd1fa4da5745b5ed358405d0613aec17a976d30d to 2b47b1b4573d19fc8c9201a379d255cc67631c11

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7a22bb0ManifoldSubset.superset_family: New, use it in doctests
bdc07ffMerge #31677
2b47b1bManifoldSubset.open_superset_family: New

comment:16 Changed 6 months ago by egourgoulhon

  • Status changed from needs_review to positive_review

LGTM. Thanks!

comment:17 Changed 6 months ago by egourgoulhon

  • Reviewers set to Eric Gourgoulhon

comment:18 Changed 6 months ago by mkoeppe

Thanks for the review!

comment:19 Changed 4 months ago by vbraun

  • Branch changed from u/mkoeppe/manifoldsubset__add_methods_subset_family__superset_family__equal_subset_family__deprecate_method_list_of_subsets to 2b47b1b4573d19fc8c9201a379d255cc67631c11
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.