Changes between Initial Version and Version 1 of Ticket #31725, comment 5
 Timestamp:
 Apr 25, 2021, 10:07:02 AM (17 months ago)
Legend:
 Unmodified
 Added
 Removed
 Modified

Ticket #31725, comment 5
initial v1 1 In fact, I meant `FinitePoset.meet(x, y)` for two given elements x and y in the poset, even for poset such that `poset.has_bottom()` is `False`. Now reading the code more carefully, I realize that this is not exactly the same as `poset._hasse_diagram._meet`, which gives the `meet_matrix` in the case of a meetsemilattice` and raises an error otherwise.2 1 Replying to [comment:4 tscrim]: 3 2 > I don't understand why we need a `_meet` and `_join` method in `FinitePoset`. Those are implementation details in the backend. 4 3 > 5 4 > +1 for adding a `common_lower_covers` method. 6 >  7 > New commits: 8 > [https://git.sagemath.org/sage.git/commit?id=287ec785acd6a520beae4f2f61523cc2e40ce9fa 287ec78]{{{implement common_lower_covers}}} 5 6 In fact, I meant `FinitePoset.meet(x, y)` for two given elements x and y in the poset, even for poset such that `poset.has_bottom()` is `False`. Now reading the code more carefully, I realize that this is not exactly the same as `poset._hasse_diagram._meet`, which gives the `meet_matrix` in the case of a meetsemilattice and raises an error otherwise.