Opened 14 months ago

Closed 12 months ago

#31719 closed enhancement (fixed)

Fix deprecation warning with viewing KR crystals

Reported by: tscrim Owned by:
Priority: major Milestone: sage-9.4
Component: combinatorics Keywords: crystals, latex
Cc: sage-combinat, bump, aschilling, nthiery, chapoton, slabbe Merged in:
Authors: Travis Scrimshaw Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 0354a41 (Commits, GitHub, GitLab) Commit: 0354a41f5504017a2aedf0ad27ee12a27f4a1702
Dependencies: Stopgaps:

Status badges

Description

We have the following: 

sage: K = crystals.KirillovReshetikhin(['A',2,1], 2,1)
sage: view(K)
/sage-build/local/lib/python3.9/site-packages/sage/misc/decorators.py:491:
 DeprecationWarning: parameter {'backward':True} (in edge_options) is deprecated.
 Use {'dir':'back'} instead.
See https://trac.sagemath.org/31381 for details.
  return func(*args, **options)

We update the edge option function according to #31381.

Change History (5)

comment:1 Changed 14 months ago by tscrim

  • Branch set to public/crystals/fix_edge_options-31719
  • Commit set to 0354a41f5504017a2aedf0ad27ee12a27f4a1702
  • Status changed from new to needs_review

Simple fix.

New commits:

​0354a41Fix deprecation warning for viewing crystals with graphviz.

comment:2 Changed 14 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:3 Changed 14 months ago by tscrim

Thank you.

comment:4 Changed 12 months ago by chapoton

  • Priority changed from minor to major

comment:5 Changed 12 months ago by vbraun

  • Branch changed from public/crystals/fix_edge_options-31719 to 0354a41f5504017a2aedf0ad27ee12a27f4a1702
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.