Opened 16 months ago
Last modified 14 months ago
#31718 closed enhancement
ManifoldSubset: Change some methods to generators — at Version 5
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.4 |
Component: | manifolds | Keywords: | |
Cc: | gh-mjungmath, egourgoulhon, tscrim | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/mkoeppe/manifoldsubset__manifold__change_some_methods_to_generators (Commits, GitHub, GitLab) | Commit: | 78cc27a8e439c542c2f03958e8e0888b0551a979 |
Dependencies: | #31680 | Stopgaps: |
Description (last modified by )
This ticket proposes to change some methods that currently return lists to generators - like the method open_supersets
added in #31677. This is in line with the changes in the Python standard library when we moved from Python 2 to 3.
ManifoldSubset
:
open_covers()
currently returns a list of lists- change to generator of
ManifoldSubsetFiniteFamily
instances - add optional argument
trivial
to simplify the common use case that only needs the nontrivial open covers
- change to generator of
subsets()
currently returns afrozenset
- change to generator of
ManifoldSubset
instances
- change to generator of
Follow-up for some methods of Manifold
in #31720.
Change History (5)
comment:1 Changed 16 months ago by
- Branch set to u/mkoeppe/manifoldsubset__manifold__change_some_methods_to_generators
comment:2 Changed 16 months ago by
- Commit set to 186707ba9fe840040c6675421a65f28fc4f3999e
- Description modified (diff)
comment:3 Changed 16 months ago by
- Description modified (diff)
comment:4 Changed 16 months ago by
- Commit changed from 186707ba9fe840040c6675421a65f28fc4f3999e to 78cc27a8e439c542c2f03958e8e0888b0551a979
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
42abda7 | Adding __bool__ for other families.
|
1f21a8f | Merge #31717
|
f095988 | FiniteManifoldObjectFamily.__bool__: Remove, inherited from superclass after #31717
|
5d87cee | Manifold{Object,Subset}FiniteFamily: Rename from FiniteManifold{Object,Subset}Family
|
2f2ace2 | src/doc/en/reference/manifolds/manifold.rst: Add sage.manifolds.family
|
1aff58a | Fix up docstring markup
|
b922066 | ManifoldSubsetFiniteFamily: If all subsets are open, include 'open' in repr
|
30271af | Fixup doctest
|
adac07a | Merge #31680
|
78cc27a | ManifoldSubset.open_covers: Change to generator, add optional arg 'trivial'; update uses
|
comment:5 Changed 16 months ago by
- Description modified (diff)
- Status changed from new to needs_review
- Summary changed from ManifoldSubset, Manifold: Change some methods to generators to ManifoldSubset: Change some methods to generators
Note: See
TracTickets for help on using
tickets.
New commits:
ManifoldSubset.subsets: Change to generator