Opened 6 months ago

Closed 3 months ago

#31706 closed enhancement (fixed)

Immutability for mixed forms

Reported by: gh-mjungmath Owned by:
Priority: major Milestone: sage-9.4
Component: manifolds Keywords:
Cc: egourgoulhon, mkoeppe, tscrim Merged in:
Authors: Michael Jung Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f3a32af (Commits, GitHub, GitLab) Commit: f3a32af8ad18acab356c3f5ab958339d05b8ffa1
Dependencies: #30272 Stopgaps:

Status badges

Description

We introduce immutability functionality for mixed forms in view of #30261.

Change History (13)

comment:1 Changed 6 months ago by gh-mjungmath

  • Status changed from new to needs_review

comment:2 Changed 6 months ago by gh-mjungmath

  • Branch set to u/gh-mjungmath/mixed_form_immutable

comment:3 Changed 6 months ago by git

  • Commit set to d91bb152b249332c4009d9734b966c7931957bab

Branch pushed to git repo; I updated commit sha1. New commits:

d91bb15Trac #31706: remove unnecessary import

comment:4 Changed 6 months ago by gh-mjungmath

  • Dependencies set to #30272

comment:5 Changed 6 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 6 months ago by gh-mjungmath

Thanks!

comment:7 Changed 4 months ago by git

  • Commit changed from d91bb152b249332c4009d9734b966c7931957bab to 7fed44934c9472ce0339b47b21278ddabdbd7b58
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

89dc552Trac #30272: merged
7fed449Merge branch 't/30272/mixed_forms__set_comp__comp' into t/31706/mixed_form_immutable

comment:8 Changed 3 months ago by git

  • Commit changed from 7fed44934c9472ce0339b47b21278ddabdbd7b58 to f3a32af8ad18acab356c3f5ab958339d05b8ffa1

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

5d096f1f-string for unicode_symbol in TensorProductFunctor and SignedTensorProductFunctor
76c2fd5Use Unicode symbol for the Riemann sphere example
5167e6cUse Unicode symbol for default text display of RealLine
332410bUse unicode_otimes in TensorProductFunctor and SignedTensorProductFunctor
f5d15d2Merge branch 'public/manifolds/unicode_art' of git://trac.sagemath.org/sage into Sage 9.4.beta4.
d87d09b#30473: fix doctest error in DiffMap.pullback
d62adadmerge unicode
f1e7ef8Trac #30272: remove set_name_comp + fix doctest
91fc96fTrac #30272: minor doctest fix
f3a32afmerge #30272

comment:9 Changed 3 months ago by gh-mjungmath

Ready for review again.

comment:10 Changed 3 months ago by tscrim

Were any changes needed for the part of this ticket from #30272?

comment:11 Changed 3 months ago by gh-mjungmath

No changes.

comment:12 Changed 3 months ago by tscrim

  • Status changed from needs_review to positive_review

comment:13 Changed 3 months ago by vbraun

  • Branch changed from u/gh-mjungmath/mixed_form_immutable to f3a32af8ad18acab356c3f5ab958339d05b8ffa1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.