Opened 14 months ago
Closed 12 months ago
#31692 closed enhancement (fixed)
Refactor display behavior of mixed forms
Reported by: | gh-mjungmath | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.4 |
Component: | manifolds | Keywords: | |
Cc: | egourgoulhon, tscrim | Merged in: | |
Authors: | Michael Jung | Reviewers: | Eric Gourgoulhon |
Report Upstream: | N/A | Work issues: | |
Branch: | 6c714ef (Commits, GitHub, GitLab) | Commit: | 6c714efcfdcd9d9ce7755574eab8c7202ad08c25 |
Dependencies: | Stopgaps: |
Description
We refactor the display behavior of mixed forms, in particular:
- We remove square brackets around homogeneous components since it might lead to confusion with cohomology elements (or any other equivalence classes).
- We remove zero-terms to make the output cleaner.
Change History (9)
comment:1 Changed 13 months ago by
- Branch set to u/gh-mjungmath/refactor_display_behavior_of_mixed_forms
comment:2 Changed 13 months ago by
- Commit set to 8a0a9b65a2380ddee5a8720c12bf5b67f171d6fb
- Status changed from new to needs_review
comment:4 Changed 13 months ago by
- Status changed from needs_review to needs_work
The patchbot says
File "src/sage/manifolds/differentiable/vector_bundle.py", line 242, in sage.manifolds.differentiable.vector_bundle.DifferentiableVectorBundle.characteristic_class Failed example: p_form = p.get_form(nab); p_form.display_expansion() Expected: p(TM, nabla_g) = [1] + [0] + [0] + [0] + [0] Got: p(TM, nabla_g) = 1
comment:5 Changed 13 months ago by
Is there a way to fixdoctesting all files in a folder at once, optimally with multicore support?
comment:6 Changed 13 months ago by
- Commit changed from 8a0a9b65a2380ddee5a8720c12bf5b67f171d6fb to 6c714efcfdcd9d9ce7755574eab8c7202ad08c25
Branch pushed to git repo; I updated commit sha1. New commits:
6c714ef | Trac #31692: doctest fix
|
comment:8 Changed 13 months ago by
- Reviewers set to Eric Gourgoulhon
- Status changed from needs_review to positive_review
LGTM.
comment:9 Changed 12 months ago by
- Branch changed from u/gh-mjungmath/refactor_display_behavior_of_mixed_forms to 6c714efcfdcd9d9ce7755574eab8c7202ad08c25
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Trac #31692: refactor display_expansion
Trac #31692: fix doctests