Opened 15 months ago
Closed 12 months ago
#31683 closed enhancement (fixed)
Simplify FiniteWord_class.primitive_length
| Reported by: | gh-mrejmon | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-9.4 |
| Component: | combinatorics | Keywords: | words |
| Cc: | Merged in: | ||
| Authors: | Martin Rejmon | Reviewers: | Travis Scrimshaw |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 318068d (Commits, GitHub, GitLab) | Commit: | 318068df239cabfd45c6a0c13aeb16b8e0c02518 |
| Dependencies: | Stopgaps: |
Status badges
Description
I pushed a small branch which slightly simplifies the method primitive_length of FiniteWord_class.
Explanation: We have that a word is primitive if and only if its period is not a proper divisor of its length (see for example Problem 1.2.1 in [Lothaire2002]). Clearly, if its period is a divisor of its length, then the length of the primitive root is equal to the period.
Change History (4)
comment:1 Changed 15 months ago by
- Status changed from new to needs_review
comment:2 Changed 15 months ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
comment:3 Changed 15 months ago by
- Type changed from task to enhancement
comment:4 Changed 12 months ago by
- Branch changed from u/gh-mrejmon/simplify_primitive to 318068df239cabfd45c6a0c13aeb16b8e0c02518
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
LGTM.