Opened 16 months ago
Last modified 14 months ago
#31677 closed enhancement
Open subsets of arbitrary subsets of manifolds — at Version 5
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.4 |
Component: | manifolds | Keywords: | |
Cc: | gh-mjungmath, egourgoulhon, tscrim | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/mkoeppe/open-subsets-of-arbitrary-subsets (Commits, GitHub, GitLab) | Commit: | b35eca14d542d604421cf82de0c24f9287e6b05f |
Dependencies: | #31674 | Stopgaps: |
Description (last modified by )
Various places in the code assumed that the elements of the _supersets
attribute of an open set are open, but this is not a guaranteed invariant.
We fix this by updating all loops over supersets that need to make this assumption to use a new generator function ManifoldSubset.open_supersets
.
We also add the method ManifoldSubset.open_subset
. It delegates to its base manifold's open_subset
method, by passing a new optional parameter supersets
to it.
Change History (5)
comment:1 Changed 16 months ago by
- Branch set to u/mkoeppe/open-subsets-of-arbitrary-subsets
comment:2 Changed 16 months ago by
- Commit set to 4e63b3093596f6c21ddd0a9e44b1d29522d593e5
comment:3 Changed 16 months ago by
- Commit changed from 4e63b3093596f6c21ddd0a9e44b1d29522d593e5 to 5623f497a325d6093f7cbac5a36399a8271869f5
comment:4 Changed 16 months ago by
- Commit changed from 5623f497a325d6093f7cbac5a36399a8271869f5 to b35eca14d542d604421cf82de0c24f9287e6b05f
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
d542412 | ManifoldSubset.open_supersets: New generator, use it to fix loops that assume open supersets
|
c821a75 | {Topological,...}Manifold.open_subset: New optional parameter supersets
|
b35eca1 | ManifoldSubset.{open_subset,_init_open_subset}: New
|
comment:5 Changed 16 months ago by
- Description modified (diff)
- Status changed from new to needs_review
Note: See
TracTickets for help on using
tickets.
Here's the beginning. To complete it, the remaining
open_subset
methods will need updating.New commits:
TopologicalSubmanifold.open_subset: New
TopologicalSubmanifold.open_subset: Fix docstring
{DifferentiableSubmanifold,PseudoRiemannianSubmanifold}.open_subset: New
{Topological,Differentiable,PseudoRiemannianSubmanifold}._repr_: Print subsets as subsets
Add/update examples
Refactor Manifold.open_subset methods through new method _init_open_subset
TopologicalManifold._init_open_subset: Add docstring
WIP