Changes between Initial Version and Version 5 of Ticket #31677


Ignore:
Timestamp:
04/19/21 22:56:40 (15 months ago)
Author:
mkoeppe
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31677

    • Property Status changed from new to needs_review
    • Property Commit changed from to b35eca14d542d604421cf82de0c24f9287e6b05f
    • Property Branch changed from to u/mkoeppe/open-subsets-of-arbitrary-subsets
  • Ticket #31677 – Description

    initial v5  
    1 We add the method `ManifoldSubset.open_subset`.
     1Various places in the code assumed that the elements of the `_supersets` attribute of an open set are open, but this is not a guaranteed invariant.
    22
    3 It delegates to its base manifold's `open_subset` method, by passing a new optional parameter `supersets` to it.
     3We fix this by updating all loops over supersets that need to make this assumption to use a new generator function `ManifoldSubset.open_supersets`.
    44
     5We also add the method `ManifoldSubset.open_subset`. It delegates to its base manifold's `open_subset` method, by passing a new optional parameter `supersets` to it.
     6