Opened 16 months ago
Closed 16 months ago
#31673 closed defect (fixed)
MR53: Unbreak sagelib's setup.py install
| Reported by: | galois | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | sage-9.3 |
| Component: | build | Keywords: | |
| Cc: | dimpase | Merged in: | |
| Authors: | Mauricio Collares | Reviewers: | Matthias Koeppe |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 994f57c (Commits, GitHub, GitLab) | Commit: | 994f57c75fd5202fb3b5008b52f489463fa0b795 |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Mauricio Collares (@collares) opened a merge request at https://gitlab.com/sagemath/sage/-/merge_requests/53:
The pattern of importing setuptools before distutils was already used in other files, but not in sagelib's setup.py. This caused errors of the form "AttributeError: 'Extension' object has no attribute '_needs_stub'" on my machine.
I understand this install method is deprecated, but I believe this patch has essentially zero cost and can safely be added to Sage 9.3.
Change History (4)
comment:1 Changed 16 months ago by
- Component changed from PLEASE CHANGE to build
- Description modified (diff)
- Milestone changed from sage-9.4 to sage-9.3
- Priority changed from major to critical
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
- Type changed from PLEASE CHANGE to defect
comment:2 Changed 16 months ago by
- Cc dimpase added
comment:3 Changed 16 months ago by
- Priority changed from critical to blocker
comment:4 Changed 16 months ago by
- Branch changed from u/galois/mrs/53/setuppy-install to 994f57c75fd5202fb3b5008b52f489463fa0b795
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
