Opened 7 months ago

Last modified 3 months ago

#31660 needs_work enhancement

Polyhedron.relative_interior_manifold, as_manifold_subset

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.5
Component: manifolds Keywords:
Cc: gh-mjungmath, gh-kliem, yzh, jipilab, tscrim, egourgoulhon Merged in:
Authors: Matthias Koeppe Reviewers:
Report Upstream: N/A Work issues: Refactor through #31688, #31916, #31963, #31993
Branch: u/mkoeppe/polyhedron_relative_interior_manifold (Commits, GitHub, GitLab) Commit: 0ddf3a8f6bddfa78a91fa3ec77c6ca72891405ba
Dependencies: #31688, #31963, #31993 Stopgaps:

Status badges

Description (last modified by mkoeppe)

We extend the ManifoldSubsetPullback constructor to handle relatively open convex sets.

In this case, we

  • set up the affine hull as an embedded submanifold via ConvexSet_base.affine_hull_projection (#31993), generalized from Polyhedron.affine_hull_manifold (#31659)
  • make the relatively open set an open subset; the pullback is the image of the open subset

We add ConvexSet_base methods

  • as_manifold_subset.
  • relative_interior_manifold

Next step: Polyhedron.face_manifold_poset, top element of which is the polyhedron as a union of its relative interior and its facets. Using #31732, the intersection of the relative interior and each facet is declared empty.

Change History (30)

comment:1 Changed 7 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

comment:2 Changed 6 months ago by mkoeppe

  • Branch set to u/mkoeppe/polyhedron_relative_interior_manifold

comment:3 Changed 6 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to cead8ceca8d5761bcc8792cf87cbc347554a2505
  • Status changed from new to needs_review

Last 10 new commits:

8414039Polyhedron_base.affine_hull_projection: Document a weaker guarantee of parametric_form
dba2763Polyhedron_base.affine_hull_projection: Replace 'affine_map' by 'projection_map', 'parametric_form'/'coordinate_images' by 'section_map'
d49c313Polyhedron_base.affine_hull_projection: section map for non-orthogonal case
d77181bAdd doctest
6f30843Polyhedron_base.affine_hull_manifold: New
0538280Polyhedron_base.affine_hull_manifold: Finish
f2bdbf2Add example
eb88cfealso plot the polyhedron
10136e9Put '# not tested' in the right place
cead8cePolyhedron_base.relative_interior_manifold: New

comment:4 Changed 6 months ago by mkoeppe

  • Description modified (diff)

comment:5 Changed 6 months ago by mkoeppe

  • Dependencies changed from #31659 to #31659, #31674

comment:6 Changed 6 months ago by git

  • Commit changed from cead8ceca8d5761bcc8792cf87cbc347554a2505 to 1c2b1bb0532912fa59be99086fdbcd61c874704b

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

d815b63{DifferentiableSubmanifold,PseudoRiemannianSubmanifold}.open_subset: New
3fc1922Merge #31674
006fd02{Topological,Differentiable,PseudoRiemannianSubmanifold}._repr_: Print subsets as subsets
ed1a2eaUpdate doctest output: Riemannian
aac8835{Topological,Differentiable,PseudoRiemannianSubmanifold}._repr_: Print subsets as subsets
004c23aAdd/update examples
ef1614aRefactor Manifold.open_subset methods through new method _init_open_subset
b2ccbbaMerge #31674
3fdb300Polyhedron_base.affine_hull_manifold: Small edit to the doctest
1c2b1bbPolyhedron_base.relative_interior_manifold: Use open_subset method

comment:7 Changed 6 months ago by mkoeppe

  • Description modified (diff)

comment:8 Changed 6 months ago by git

  • Commit changed from 1c2b1bb0532912fa59be99086fdbcd61c874704b to 7a6a10c41f8df5f828b041932b2cf3fb7380e961

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

643392cUse new format of affine hull data
57dce72Polyhedron.affine_hull_manifold: Update doctests
a4d3d5cMerge #31659
265b0e2TopologicalManifold._init_open_subset: Add docstring
a93f7edTopologicalSubmanifold._init_open_subset: Add docstring
58b43f7DifferentiableManifold._init_open_subset: Add docstring
dee6cefMerge #31674
730f5e6Update doctest
a47ea80Update doctest
7a6a10cMerge #31659

comment:9 Changed 6 months ago by git

  • Commit changed from 7a6a10c41f8df5f828b041932b2cf3fb7380e961 to 9734f9837f10f7ca76632115c461d59cbc2e3f01

Branch pushed to git repo; I updated commit sha1. New commits:

9734f98Polyhedron_base.relative_interior_manifold: Substitute the values of the foliation parameters

comment:10 Changed 6 months ago by mkoeppe

  • Description modified (diff)

comment:11 Changed 6 months ago by git

  • Commit changed from 9734f9837f10f7ca76632115c461d59cbc2e3f01 to 9e8eb277e813bed6bbc683f4b071e2addc52c5f9

Branch pushed to git repo; I updated commit sha1. New commits:

b17aa8cadd another doctest
eee1aadfix section map
915389dMerge #27366
9e8eb27Merge #31659

comment:12 Changed 5 months ago by mkoeppe

  • Dependencies changed from #31659, #31674 to #31659, #31674, #31644

comment:13 Changed 5 months ago by git

  • Commit changed from 9e8eb277e813bed6bbc683f4b071e2addc52c5f9 to 200096b4464b43d5b9b9846d7bba72fdad124549

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

ee4efc9ManifoldSubset._{union,intersection}_subset: Do cache the result here; add examples
e7f7a7dMerge #31764
9259a2cMerge #31798
ac53984src/sage/manifolds/subsets/__init__.py: New
f88e410Merge #31644
87a2beaPolyhedron_base.affine_hull_manifold: In the full-dimensional case, do not create a submanifold
8af2c71Polyhedron_base._affine_hull_name_latex_name: Add docstring
05d228cMerge #31659
d79a8cbPolyhedron_base.relative_interior_manifold: Handle the full-dimensional case
200096bPolyhedron_base.as_manifold_subset: New

comment:14 Changed 5 months ago by mkoeppe

  • Cc egourgoulhon added
  • Description modified (diff)
  • Summary changed from Polyhedron.relative_interior_manifold to Polyhedron.relative_interior_manifold, as_manifold_subset

comment:15 Changed 5 months ago by git

  • Commit changed from 200096b4464b43d5b9b9846d7bba72fdad124549 to 54f736b5811cd972a36363f7afd57142b597771b

Branch pushed to git repo; I updated commit sha1. New commits:

8c6759aMake docstrings raw
8110203Merge #31659
54f736bMake docstrings raw

comment:16 Changed 5 months ago by mkoeppe

  • Description modified (diff)

comment:17 Changed 5 months ago by git

  • Commit changed from 54f736b5811cd972a36363f7afd57142b597771b to ca4bbf64d591595f4279c24de2b7a6f1ea79f476

Branch pushed to git repo; I updated commit sha1. New commits:

19a9cebPolyhedron_base.affine_hull_manifold: Add argument ambient_chart
8951090Merge #31659
ca4bbf6Polyhedron_base.as_manifold_subset, relative_interior_manifold: Add argument ambient_chart

comment:18 Changed 5 months ago by git

  • Commit changed from ca4bbf64d591595f4279c24de2b7a6f1ea79f476 to 52802f83356d5cce31935fd0d9a7220c0d3f3654

Branch pushed to git repo; I updated commit sha1. New commits:

62390c9src/sage/geometry/polyhedron/base.py: Fix typo
52802f8Merge #31659

comment:19 Changed 5 months ago by mkoeppe

  • Status changed from needs_review to needs_work
  • Work issues set to Refactor through #31688, #31916

comment:20 Changed 5 months ago by mkoeppe

With #31916, instead of introducing relative_interior_manifold(...), one would write relative_interior().as_manifold_subset(...)

comment:21 Changed 5 months ago by mkoeppe

Likewise with #31963 for affine_hull()

comment:22 Changed 4 months ago by mkoeppe

  • Dependencies changed from #31659, #31674, #31644 to #31688, #31916

comment:23 Changed 4 months ago by mkoeppe

  • Dependencies changed from #31688, #31916 to #31688, #31916, #31963

comment:24 Changed 4 months ago by mkoeppe

  • Dependencies changed from #31688, #31916, #31963 to #31688, #31963

comment:25 Changed 4 months ago by git

  • Commit changed from 52802f83356d5cce31935fd0d9a7220c0d3f3654 to 3fd8f86a33cd8a27fe34564575f831b10288633a

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

768afc7Polyhedron_base.relative_interior_manifold: New
39d5679Update doctest output: Riemannian
88adca6Polyhedron_base.affine_hull_manifold: Small edit to the doctest
94dfbe4Polyhedron_base.relative_interior_manifold: Use open_subset method
cb030e6Update doctest
bb60d84Polyhedron_base.relative_interior_manifold: Substitute the values of the foliation parameters
80f9213Polyhedron_base.relative_interior_manifold: Handle the full-dimensional case
b103d9cPolyhedron_base.as_manifold_subset: New
02fba3cMake docstrings raw
3fd8f86Polyhedron_base.as_manifold_subset, relative_interior_manifold: Add argument ambient_chart

comment:26 Changed 4 months ago by git

  • Commit changed from 3fd8f86a33cd8a27fe34564575f831b10288633a to a9bc5bc594e3d35ae19b4ce012a01963ffb3c7cd

Branch pushed to git repo; I updated commit sha1. New commits:

a9bc5bcPolyhedron_base.relative_interior_manifold: Update doctest output

comment:27 Changed 4 months ago by mkoeppe

  • Dependencies changed from #31688, #31963 to #31688, #31963, #31993
  • Work issues changed from Refactor through #31688, #31916 to Refactor through #31688, #31916, #31963, #31993

comment:28 Changed 4 months ago by mkoeppe

  • Description modified (diff)

comment:29 Changed 4 months ago by git

  • Commit changed from a9bc5bc594e3d35ae19b4ce012a01963ffb3c7cd to 0ddf3a8f6bddfa78a91fa3ec77c6ca72891405ba

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

f956fd3AffineHullProjectionData: Move from Polyhedron_base to sage.geometry.convex_set, rename field 'polyhedron' to 'image'
2a96f18sage.geometry: Import cached_method from a more specific module
0226965WIP ConvexSet_base.affine_hull_projection
23b08cdRelativeInterior.an_affine_basis: New; relax _test_affine_basis to accept closure points
0e2965fPolyhedron.affine_hull_projection: Refactor as ConvexSet_base.affine_hull_projection and Polyhedron._affine_hull_projection
837b7f5RelativeInterior.{dilation,linear_transformation,translation}: New
579303cConvexSet_base.dilation: Add default implementation, test
535e412ConvexSet_base.linear_transformation, translation: Add tests
e389f0aMerge #31993
0ddf3a8ManifoldSubsetPullback: WIP relatively open

comment:30 Changed 3 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5
Note: See TracTickets for help on using tickets.