Opened 6 months ago

Closed 4 months ago

#31659 closed enhancement (fixed)

Polyhedron.affine_hull_manifold

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.4
Component: manifolds Keywords:
Cc: gh-mjungmath, gh-kliem, yzh, jipilab, tscrim, egourgoulhon Merged in:
Authors: Matthias Koeppe Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 62390c9 (Commits, GitHub, GitLab) Commit: 62390c9a35dcf76f2eb76178458ff978fef2ced2
Dependencies: Stopgaps:

Status badges

Description

This new method will return the affine hull of the polyhedron as an embedded submanifold of the ambient space, with a default chart defining coordinates that are the same as those that affine_hull_projection gives.

Change History (28)

comment:1 Changed 6 months ago by mkoeppe

  • Branch set to u/mkoeppe/polyhedron_affine_hull_manifold

comment:2 Changed 6 months ago by mkoeppe

  • Commit set to c2e6c553b0d0e4f0284ae9dee7cc0311dbe36f7b

Here's a beginning.

Unfortunately affine_hull_projection(as_affine_map=True) is a bit strange - it does not return everything what we need: The inverse affine map, from the projection back to the polyhedron. Maybe we should add more output options to this function (see also #27366)


New commits:

c2e6c55Polyhedron_base.affine_hull_manifold: New

comment:3 Changed 6 months ago by mkoeppe

  • Authors set to Matthias Koeppe, ...

comment:4 Changed 6 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

comment:5 Changed 6 months ago by mkoeppe

  • Dependencies set to #27366

comment:6 Changed 6 months ago by git

  • Commit changed from c2e6c553b0d0e4f0284ae9dee7cc0311dbe36f7b to 05382808adf7af99caa94c70c88548fe59515c83

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

b407987Merge tag '9.3.rc2' into t/27366/affine-hull-more
d25f7f3Fixup merge
7e0f31daffine_hull -> affine_hull_projection in doctests
58e6dccMerge tag '9.3.rc3' into t/27366/affine-hull-more
8414039Polyhedron_base.affine_hull_projection: Document a weaker guarantee of parametric_form
dba2763Polyhedron_base.affine_hull_projection: Replace 'affine_map' by 'projection_map', 'parametric_form'/'coordinate_images' by 'section_map'
d49c313Polyhedron_base.affine_hull_projection: section map for non-orthogonal case
d77181bAdd doctest
6f30843Polyhedron_base.affine_hull_manifold: New
0538280Polyhedron_base.affine_hull_manifold: Finish

comment:7 Changed 6 months ago by mkoeppe

  • Authors changed from Matthias Koeppe, ... to Matthias Koeppe
  • Status changed from new to needs_review

comment:8 Changed 6 months ago by git

  • Commit changed from 05382808adf7af99caa94c70c88548fe59515c83 to f2bdbf247d8e271c46c04e080af4c7d452d1779f

Branch pushed to git repo; I updated commit sha1. New commits:

f2bdbf2Add example

comment:9 Changed 6 months ago by git

  • Commit changed from f2bdbf247d8e271c46c04e080af4c7d452d1779f to eb88cfeff352600c91ba2c47f57323782e39669b

Branch pushed to git repo; I updated commit sha1. New commits:

eb88cfealso plot the polyhedron

comment:10 Changed 6 months ago by mkoeppe

The plotting is best tested with #31600

comment:11 Changed 6 months ago by git

  • Commit changed from eb88cfeff352600c91ba2c47f57323782e39669b to de50778341abffc546cc048cc547121bc401288b

Branch pushed to git repo; I updated commit sha1. New commits:

3d5f3c4Put '# not tested' in the right place
de50778Polyhedron_base.affine_hull_manifold: Make it Riemannian

comment:12 Changed 6 months ago by mkoeppe

  • Status changed from needs_review to needs_work

It seems I need to make this a foliation so that I get access to a volume form

comment:13 Changed 6 months ago by git

  • Commit changed from de50778341abffc546cc048cc547121bc401288b to e409f37ac8db2d033b9c678f860f2e75ba0434b9

Branch pushed to git repo; I updated commit sha1. New commits:

ab10ce2correct base_rings for projection and section map and test suite method
69ceebcbase extend in test; only run defined tests
e409f37Merge #27366

comment:14 Changed 6 months ago by git

  • Commit changed from e409f37ac8db2d033b9c678f860f2e75ba0434b9 to cd15496f0bfc5df7e755993b12cc5eb025353a86

Branch pushed to git repo; I updated commit sha1. New commits:

ba62e66Polyhedron_base.affine_hull_projection: Fix for 0-dimensional case
934a33fPolyhedron_base.affine_hull_projection: Error for the empty polyhedron
9629620Polyhedron_base.affine_hull_projection: Fix up use of echelong form
cd15496Merge #27366

comment:15 Changed 6 months ago by git

  • Commit changed from cd15496f0bfc5df7e755993b12cc5eb025353a86 to 931b5ca961235d976f2a2eaa132a5794c15afaf8

Branch pushed to git repo; I updated commit sha1. New commits:

8c24c5cPolyhedron_base.affine_hull_projection: Remove last occurrence of 'parametric_form'
9368947Merge #27366
931b5caPolyhedron_base.affine_hull_manifold: Use a foliation

comment:16 Changed 6 months ago by mkoeppe

  • Status changed from needs_work to needs_review

comment:17 Changed 6 months ago by git

  • Commit changed from 931b5ca961235d976f2a2eaa132a5794c15afaf8 to 57dce72795fea7cad909c678482c90973e872358

Branch pushed to git repo; I updated commit sha1. New commits:

9f5560ainitialize empty matrix after trivial multiplication
f9faa02minimal extension only avoid AA if the base ring is not already AA
397ae3asrc/sage/geometry/polyhedron/base.py: Update copyright according to git blame -w --date=format:%Y src/sage/geometry/polyhedron/base.py | sort -k2
2c1e2bdPolyhedron_base.affine_hull_projection: Return a dataclass instance, not a dictionary
57fd3e1Fixup doctest formatting
6e686a4Merge #27366
643392cUse new format of affine hull data
57dce72Polyhedron.affine_hull_manifold: Update doctests

comment:18 Changed 6 months ago by git

  • Commit changed from 57dce72795fea7cad909c678482c90973e872358 to a47ea805c6bdf547bd96b1ee1f9db3406bf2d1ab

Branch pushed to git repo; I updated commit sha1. New commits:

a47ea80Update doctest

comment:19 Changed 6 months ago by git

  • Commit changed from a47ea805c6bdf547bd96b1ee1f9db3406bf2d1ab to 915389d0ad545bba8855903ee981182ef4bc99d9

Branch pushed to git repo; I updated commit sha1. New commits:

b17aa8cadd another doctest
eee1aadfix section map
915389dMerge #27366

comment:20 Changed 5 months ago by git

  • Commit changed from 915389d0ad545bba8855903ee981182ef4bc99d9 to 8af2c7126f785403d8df4a7dd7c22afdc90937d9

Branch pushed to git repo; I updated commit sha1. New commits:

87a2beaPolyhedron_base.affine_hull_manifold: In the full-dimensional case, do not create a submanifold
8af2c71Polyhedron_base._affine_hull_name_latex_name: Add docstring

comment:21 Changed 5 months ago by mkoeppe

  • Cc egourgoulhon added

comment:22 Changed 5 months ago by git

  • Commit changed from 8af2c7126f785403d8df4a7dd7c22afdc90937d9 to 8c6759a490b2011708b34a7feba92d789c62f885

Branch pushed to git repo; I updated commit sha1. New commits:

8c6759aMake docstrings raw

comment:23 Changed 5 months ago by git

  • Commit changed from 8c6759a490b2011708b34a7feba92d789c62f885 to 19a9cebabdcdcba2aace57f814a014a6468133e6

Branch pushed to git repo; I updated commit sha1. New commits:

19a9cebPolyhedron_base.affine_hull_manifold: Add argument ambient_chart

comment:24 Changed 5 months ago by git

  • Commit changed from 19a9cebabdcdcba2aace57f814a014a6468133e6 to 62390c9a35dcf76f2eb76178458ff978fef2ced2

Branch pushed to git repo; I updated commit sha1. New commits:

62390c9src/sage/geometry/polyhedron/base.py: Fix typo

comment:25 Changed 5 months ago by mkoeppe

  • Dependencies #27366 deleted

Ready for review; the failure on one of the patchbots is unrelated (#28559)

comment:26 Changed 5 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:27 Changed 4 months ago by mkoeppe

Thanks!

comment:28 Changed 4 months ago by vbraun

  • Branch changed from u/mkoeppe/polyhedron_affine_hull_manifold to 62390c9a35dcf76f2eb76178458ff978fef2ced2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.