Opened 20 months ago
Closed 18 months ago
#31659 closed enhancement (fixed)
Polyhedron.affine_hull_manifold
Reported by:  Matthias Köppe  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  manifolds  Keywords:  
Cc:  Michael Jung, ghkliem, Yuan Zhou, JeanPhilippe Labbé, Travis Scrimshaw, Eric Gourgoulhon  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  62390c9 (Commits, GitHub, GitLab)  Commit:  62390c9a35dcf76f2eb76178458ff978fef2ced2 
Dependencies:  Stopgaps: 
Description
This new method will return the affine hull of the polyhedron as an embedded submanifold of the ambient space, with a default chart defining coordinates that are the same as those that affine_hull_projection
gives.
Change History (28)
comment:1 Changed 20 months ago by
Branch:  → u/mkoeppe/polyhedron_affine_hull_manifold 

comment:2 Changed 20 months ago by
Commit:  → c2e6c553b0d0e4f0284ae9dee7cc0311dbe36f7b 

comment:3 Changed 20 months ago by
Authors:  → Matthias Koeppe, ... 

comment:4 Changed 20 months ago by
Milestone:  sage9.3 → sage9.4 

comment:5 Changed 20 months ago by
Dependencies:  → #27366 

comment:6 Changed 20 months ago by
Commit:  c2e6c553b0d0e4f0284ae9dee7cc0311dbe36f7b → 05382808adf7af99caa94c70c88548fe59515c83 

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
b407987  Merge tag '9.3.rc2' into t/27366/affinehullmore

d25f7f3  Fixup merge

7e0f31d  affine_hull > affine_hull_projection in doctests

58e6dcc  Merge tag '9.3.rc3' into t/27366/affinehullmore

8414039  Polyhedron_base.affine_hull_projection: Document a weaker guarantee of parametric_form

dba2763  Polyhedron_base.affine_hull_projection: Replace 'affine_map' by 'projection_map', 'parametric_form'/'coordinate_images' by 'section_map'

d49c313  Polyhedron_base.affine_hull_projection: section map for nonorthogonal case

d77181b  Add doctest

6f30843  Polyhedron_base.affine_hull_manifold: New

0538280  Polyhedron_base.affine_hull_manifold: Finish

comment:7 Changed 20 months ago by
Authors:  Matthias Koeppe, ... → Matthias Koeppe 

Status:  new → needs_review 
comment:8 Changed 20 months ago by
Commit:  05382808adf7af99caa94c70c88548fe59515c83 → f2bdbf247d8e271c46c04e080af4c7d452d1779f 

Branch pushed to git repo; I updated commit sha1. New commits:
f2bdbf2  Add example

comment:9 Changed 20 months ago by
Commit:  f2bdbf247d8e271c46c04e080af4c7d452d1779f → eb88cfeff352600c91ba2c47f57323782e39669b 

Branch pushed to git repo; I updated commit sha1. New commits:
eb88cfe  also plot the polyhedron

comment:11 Changed 20 months ago by
Commit:  eb88cfeff352600c91ba2c47f57323782e39669b → de50778341abffc546cc048cc547121bc401288b 

comment:12 Changed 20 months ago by
Status:  needs_review → needs_work 

It seems I need to make this a foliation so that I get access to a volume form
comment:13 Changed 20 months ago by
Commit:  de50778341abffc546cc048cc547121bc401288b → e409f37ac8db2d033b9c678f860f2e75ba0434b9 

comment:14 Changed 20 months ago by
Commit:  e409f37ac8db2d033b9c678f860f2e75ba0434b9 → cd15496f0bfc5df7e755993b12cc5eb025353a86 

Branch pushed to git repo; I updated commit sha1. New commits:
ba62e66  Polyhedron_base.affine_hull_projection: Fix for 0dimensional case

934a33f  Polyhedron_base.affine_hull_projection: Error for the empty polyhedron

9629620  Polyhedron_base.affine_hull_projection: Fix up use of echelong form

cd15496  Merge #27366

comment:15 Changed 20 months ago by
Commit:  cd15496f0bfc5df7e755993b12cc5eb025353a86 → 931b5ca961235d976f2a2eaa132a5794c15afaf8 

comment:16 Changed 20 months ago by
Status:  needs_work → needs_review 

comment:17 Changed 20 months ago by
Commit:  931b5ca961235d976f2a2eaa132a5794c15afaf8 → 57dce72795fea7cad909c678482c90973e872358 

Branch pushed to git repo; I updated commit sha1. New commits:
9f5560a  initialize empty matrix after trivial multiplication

f9faa02  minimal extension only avoid AA if the base ring is not already AA

397ae3a  src/sage/geometry/polyhedron/base.py: Update copyright according to git blame w date=format:%Y src/sage/geometry/polyhedron/base.py  sort k2

2c1e2bd  Polyhedron_base.affine_hull_projection: Return a dataclass instance, not a dictionary

57fd3e1  Fixup doctest formatting

6e686a4  Merge #27366

643392c  Use new format of affine hull data

57dce72  Polyhedron.affine_hull_manifold: Update doctests

comment:18 Changed 20 months ago by
Commit:  57dce72795fea7cad909c678482c90973e872358 → a47ea805c6bdf547bd96b1ee1f9db3406bf2d1ab 

Branch pushed to git repo; I updated commit sha1. New commits:
a47ea80  Update doctest

comment:19 Changed 20 months ago by
Commit:  a47ea805c6bdf547bd96b1ee1f9db3406bf2d1ab → 915389d0ad545bba8855903ee981182ef4bc99d9 

comment:20 Changed 19 months ago by
Commit:  915389d0ad545bba8855903ee981182ef4bc99d9 → 8af2c7126f785403d8df4a7dd7c22afdc90937d9 

comment:21 Changed 19 months ago by
Cc:  Eric Gourgoulhon added 

comment:22 Changed 19 months ago by
Commit:  8af2c7126f785403d8df4a7dd7c22afdc90937d9 → 8c6759a490b2011708b34a7feba92d789c62f885 

Branch pushed to git repo; I updated commit sha1. New commits:
8c6759a  Make docstrings raw

comment:23 Changed 19 months ago by
Commit:  8c6759a490b2011708b34a7feba92d789c62f885 → 19a9cebabdcdcba2aace57f814a014a6468133e6 

Branch pushed to git repo; I updated commit sha1. New commits:
19a9ceb  Polyhedron_base.affine_hull_manifold: Add argument ambient_chart

comment:24 Changed 19 months ago by
Commit:  19a9cebabdcdcba2aace57f814a014a6468133e6 → 62390c9a35dcf76f2eb76178458ff978fef2ced2 

Branch pushed to git repo; I updated commit sha1. New commits:
62390c9  src/sage/geometry/polyhedron/base.py: Fix typo

comment:25 Changed 18 months ago by
Dependencies:  #27366 

Ready for review; the failure on one of the patchbots is unrelated (#28559)
comment:26 Changed 18 months ago by
Reviewers:  → Travis Scrimshaw 

Status:  needs_review → positive_review 
LGTM.
comment:28 Changed 18 months ago by
Branch:  u/mkoeppe/polyhedron_affine_hull_manifold → 62390c9a35dcf76f2eb76178458ff978fef2ced2 

Resolution:  → fixed 
Status:  positive_review → closed 
Here's a beginning.
Unfortunately
affine_hull_projection(as_affine_map=True)
is a bit strange  it does not return everything what we need: The inverse affine map, from the projection back to the polyhedron. Maybe we should add more output options to this function (see also #27366)New commits:
Polyhedron_base.affine_hull_manifold: New