Opened 16 months ago

Closed 16 months ago

#31646 closed defect (fixed)

clean BezierPath constructor

Reported by: vdelecroix Owned by:
Priority: blocker Milestone: sage-9.3
Component: graphics Keywords: bug
Cc: Merged in:
Authors: Vincent Delecroix Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 33a9e9d (Commits, GitHub, GitLab) Commit: 33a9e9df896228e085073943e232c35499176e13
Dependencies: Stopgaps:

Status badges

Description

From ​http://ask.sagemath.org/question/56608/possible-problem-in-bezier_pathpy/

Change History (8)

comment:1 Changed 16 months ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Branch set to u/vdelecroix/31646
  • Commit set to 8d2ef75dc15e9ed67467ca0741e34d049724e843
  • Status changed from new to needs_review

New commits:

​8d2ef7531646: clean BezierPath constructor

comment:2 Changed 16 months ago by git

  • Commit changed from 8d2ef75dc15e9ed67467ca0741e34d049724e843 to 33a9e9df896228e085073943e232c35499176e13

Branch pushed to git repo; I updated commit sha1. New commits:

​33a9e9d31646: remove import of unused deepcopy

comment:3 Changed 16 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 16 months ago by tscrim

  • Milestone changed from sage-9.3 to sage-9.4

Bumping to 9.4 since we are in the 9.3.rc stage.

comment:5 Changed 16 months ago by vdelecroix

Note that this is a bug fix and used to break the conversion to 3d.

comment:6 Changed 16 months ago by vdelecroix

  • Milestone changed from sage-9.4 to sage-9.3
  • Priority changed from major to blocker

Let's try to squeeze in.

comment:7 Changed 16 months ago by vdelecroix

  • Keywords bug added

comment:8 Changed 16 months ago by vbraun

  • Branch changed from u/vdelecroix/31646 to 33a9e9df896228e085073943e232c35499176e13
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.