Opened 7 months ago
Closed 5 months ago
#31629 closed defect (fixed)
Fix a regression in show(obj) for string obj
Reported by:  klee  Owned by:  

Priority:  critical  Milestone:  sage9.4 
Component:  user interface  Keywords:  
Cc:  egourgoulhon  Merged in:  
Authors:  Kwankyu Lee  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  691e17e (Commits, GitHub, GitLab)  Commit:  691e17e1397c2b5d49b12823f0ba5417e50f4a3a 
Dependencies:  #31517  Stopgaps: 
Description (last modified by )
The ticket #31536 merged to Sage 9.3.rc2 introduced a regression such that
sage: show('$x+1$')
displays a nicely rendered expression! Before, the same code displayed a verbatim string $x+1$
.
The symptom is related with how html(...)
works. This
sage: html('$x+1$')
also renders the math in the string (before and after #31536).
This ticket introduces strict
mode to html()
to fix the regression. The patch is based on #31517.
Change History (15)
comment:1 Changed 7 months ago by
 Branch set to u/klee/31629
comment:2 Changed 7 months ago by
 Commit set to 6e668f49ec1301bd781b29da34416d6ab669b3f4
comment:3 Changed 7 months ago by
 Status changed from new to needs_review
comment:4 Changed 7 months ago by
 Cc egourgoulhon added
comment:5 Changed 6 months ago by
 Milestone changed from sage9.3 to sage9.4
Moving to 9.4, as 9.3 has been released.
comment:6 Changed 6 months ago by
 Dependencies set to #31517
comment:7 Changed 6 months ago by
 Commit changed from 6e668f49ec1301bd781b29da34416d6ab669b3f4 to 691e17e1397c2b5d49b12823f0ba5417e50f4a3a
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
691e17e  Introduce strict mode to html()

comment:8 Changed 6 months ago by
 Description modified (diff)
comment:9 Changed 5 months ago by
Related: #31847.
comment:10 Changed 5 months ago by
ping
comment:11 followup: ↓ 12 Changed 5 months ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
LGTM.
comment:12 in reply to: ↑ 11 Changed 5 months ago by
comment:13 Changed 5 months ago by
Thanks for the fix!
comment:14 Changed 5 months ago by
 Priority changed from minor to critical
Setting to critical as the change in show
for latex expressions breaks user code, see e.g.
comment:15 Changed 5 months ago by
 Branch changed from u/klee/31629 to 691e17e1397c2b5d49b12823f0ba5417e50f4a3a
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
Introduce strict mode to html()