Opened 22 months ago

Closed 11 months ago

Last modified 6 months ago

#31590 closed enhancement (fixed)

Allow passing command to plantri

Reported by: slelievre Owned by:
Priority: major Milestone: sage-9.6
Component: graph theory Keywords:
Cc: chapoton, dcoudert, slelievre Merged in:
Authors: David Coudert Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 37a5b40 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

Allow passing command to plantri, similar to what graphs.nauty_geng allows for nauty.

As suggested in #31571.

Change History (8)

comment:1 Changed 19 months ago by mkoeppe

Milestone: sage-9.4 → sage-9.5

comment:2 Changed 14 months ago by mkoeppe

Milestone: sage-9.5 → sage-9.6

comment:3 Changed 13 months ago by dcoudert

Authors: → David Coudert
Branch: → public/graphs/31590_plantri
Commit: → 75376430697532660ec448026359da2a450a3fd7
Status: new → needs_review

This is a first version of the method.

  • the name plantri_gen might not be best possible. Could be simply plantri ?
  • I use a try except statement but I'm not sure it's the best way. We have an error when the combination of parameters does not allow plantri to generate any graph. Should we instead return nothing ?
  • I have documented some parameters that are part of version 5.2 (release in 2021) but not of 4.5 (version released in 2011 that we use). I have opened #33120 to update to plantri 5.2.

New commits:

​7537643trac #31590: allow passing command to plantri

comment:4 Changed 13 months ago by git

Commit: 75376430697532660ec448026359da2a450a3fd7 → 37a5b40e07a5768ae4ff83b856cbd1e6338edafb

Branch pushed to git repo; I updated commit sha1. New commits:

​37a5b40trac #31590: add missing optional statements

comment:5 Changed 13 months ago by dcoudert

Should be ok now.

comment:6 Changed 11 months ago by mkoeppe

Reviewers: → Matthias Koeppe
Status: needs_review → positive_review

comment:7 Changed 11 months ago by vbraun

Branch: public/graphs/31590_plantri → 37a5b40e07a5768ae4ff83b856cbd1e6338edafb
Resolution: → fixed
Status: positive_review → closed

comment:8 Changed 6 months ago by jhpalmieri

Commit: 37a5b40e07a5768ae4ff83b856cbd1e6338edafb

See #34245 for a followup: there is a bad doctest created by this ticket.

Note: See TracTickets for help on using tickets.