Changes between Initial Version and Version 7 of Ticket #31584


Ignore:
Timestamp:
Mar 31, 2021, 5:23:15 PM (20 months ago)
Author:
Matthias Köppe
Comment:

I have expanded the ticket description, please take a look

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31584

    • Property Status changed from new to needs_review
    • Property Authors changed from to Matthias Koeppe
    • Property Cc Michael Orlitzky added
    • Property Branch changed from to u/mkoeppe/fix_suitesparse_cvxopt__usr_local_leakage
    • Property Reviewers changed from to Michael Orlitzky
    • Property Commit changed from to 52537d120927ed57ce9659683fed15c405b1d1c7
  • Ticket #31584 – Description

    initial v7  
    11We fix a simple bug in our build system:
    22
    3 The value of `SAGE_SUITESPARSE_LOCALINSTALL` is set in `build/pkgs/suitesparse/spkg-configure.m4` but is not actually passed on to `build/pkgs/cvxopt/spkg-install.in`.
     3The value of `SAGE_SUITESPARSE_LOCALINSTALL` is set in `build/pkgs/suitesparse/spkg-configure.m4` but is not actually passed on to `build/pkgs/cvxopt/spkg-install.in`.  A different variable, `SAGE_SUITESPARSE_PREFIX`, is passed by `build/bin/sage-build-env-config.in` from the configure stage to the build stage, but it is never set or used.
     4{{{
     5$ git grep SAGE_SUITESPARSE
     6build/bin/sage-build-env-config.in:export SAGE_SUITESPARSE_PREFIX="@SAGE_SUITESPARSE_PREFIX@"
     7build/pkgs/cvxopt/spkg-install.in:if test "x$SAGE_SUITESPARSE_LOCALINSTALL" != "x"; then
     8build/pkgs/suitesparse/spkg-configure.m4:       AC_SUBST(SAGE_SUITESPARSE_LOCALINSTALL, ['$SAGE_LOCAL'])
     9build/pkgs/suitesparse/spkg-configure.m4:       AC_SUBST(SAGE_SUITESPARSE_LOCALINSTALL, [''])
     10}}}
    411
    512As a result, `suitesparse` from `/usr/local` can leak in, as observed in https://trac.sagemath.org/ticket/31567?replyto=25#comment:25
     13
     14
     15Clearly these two variables were intended to be the same variable. We fix this.  This unified variable, `SAGE_SUITESPARSE_PREFIX`, is analogous to other variables `SAGE_..._PREFIX`.
     16