#31583 closed enhancement (fixed)

Deprecate quaternion_order() method of quaternion ideals

Reported by: Peter Bruin Owned by:
Priority: major Milestone: sage-9.4
Component: algebra Keywords: quaternion algebra
Cc: Merged in:
Authors: Peter Bruin Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c8ee322 (Commits, GitHub, GitLab) Commit: c8ee32284cb00b0c1a417d050536c7f1f2712f1e
Dependencies: #31582 Stopgaps:

Status badges

Description

The method quaternion_order() of QuaternionFractionalIdeal_rational may return a different result depending on whether the left and/or right order of the ideal have been computed. In this ticket we deprecate this method, as well as ring(), which behaves identically, and recommend using left_order() or right_order() instead.

After the ring() method is removed (in a future ticket), calling ring() will return the ambient quaternion algebra rather than an order. This is consistent with the behaviour for fractional ideals of number fields.

Change History (7)

comment:1 Changed 21 months ago by Peter Bruin

Branch: u/pbruin/31583-quaternion_ideal_deprecations
Commit: 3c0591a3af928b5a902e2d31e5807de5c49c0a59
Status: newneeds_review

comment:2 Changed 21 months ago by Peter Bruin

Dependencies: #31582

comment:3 Changed 20 months ago by git

Commit: 3c0591a3af928b5a902e2d31e5807de5c49c0a59c8ee32284cb00b0c1a417d050536c7f1f2712f1e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c3dcc34Trac 31582: use existing attributes and methods of Ideal_fractional,
5c453e9Trac 31582: add argument Q to QuaternionFractionalIdeal_rational.__init__()
c8ee322Trac 31583: deprecate quaternion_order() and ring() methods of quaternion ideals

comment:4 Changed 20 months ago by Matthias Köppe

Milestone: sage-9.3sage-9.4

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review.

comment:5 Changed 20 months ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Consistency is good. LGTM.

comment:6 Changed 17 months ago by Matthias Köppe

Priority: minormajor

Promoting the oldest 5 positively reviewed tickets to "major"

comment:7 Changed 17 months ago by Volker Braun

Branch: u/pbruin/31583-quaternion_ideal_deprecationsc8ee32284cb00b0c1a417d050536c7f1f2712f1e
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.