Opened 21 months ago

Closed 17 months ago

## #31583 closed enhancement (fixed)

# Deprecate quaternion_order() method of quaternion ideals

Reported by: | Peter Bruin | Owned by: | |
---|---|---|---|

Priority: | major | Milestone: | sage-9.4 |

Component: | algebra | Keywords: | quaternion algebra |

Cc: | Merged in: | ||

Authors: | Peter Bruin | Reviewers: | Travis Scrimshaw |

Report Upstream: | N/A | Work issues: | |

Branch: | c8ee322 (Commits, GitHub, GitLab) | Commit: | c8ee32284cb00b0c1a417d050536c7f1f2712f1e |

Dependencies: | #31582 | Stopgaps: |

### Description

The method `quaternion_order()`

of `QuaternionFractionalIdeal_rational`

may return a different result depending on whether the left and/or right order of the ideal have been computed. In this ticket we deprecate this method, as well as `ring()`

, which behaves identically, and recommend using `left_order()`

or `right_order()`

instead.

After the `ring()`

method is removed (in a future ticket), calling `ring()`

will return the ambient quaternion algebra rather than an order. This is consistent with the behaviour for fractional ideals of number fields.

### Change History (7)

### comment:1 Changed 21 months ago by

Branch: | → u/pbruin/31583-quaternion_ideal_deprecations |
---|---|

Commit: | → 3c0591a3af928b5a902e2d31e5807de5c49c0a59 |

Status: | new → needs_review |

### comment:2 Changed 21 months ago by

Dependencies: | → #31582 |
---|

### comment:3 Changed 20 months ago by

Commit: | 3c0591a3af928b5a902e2d31e5807de5c49c0a59 → c8ee32284cb00b0c1a417d050536c7f1f2712f1e |
---|

### comment:4 Changed 20 months ago by

Milestone: | sage-9.3 → sage-9.4 |
---|

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review.

### comment:5 Changed 20 months ago by

Reviewers: | → Travis Scrimshaw |
---|---|

Status: | needs_review → positive_review |

Consistency is good. LGTM.

### comment:6 Changed 17 months ago by

Priority: | minor → major |
---|

Promoting the oldest 5 positively reviewed tickets to "major"

### comment:7 Changed 17 months ago by

Branch: | u/pbruin/31583-quaternion_ideal_deprecations → c8ee32284cb00b0c1a417d050536c7f1f2712f1e |
---|---|

Resolution: | → fixed |

Status: | positive_review → closed |

**Note:**See TracTickets for help on using tickets.

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`Trac 31582: use existing attributes and methods of Ideal_fractional,`

`Trac 31582: add argument Q to QuaternionFractionalIdeal_rational.__init__()`

`Trac 31583: deprecate quaternion_order() and ring() methods of quaternion ideals`