Opened 15 months ago

Closed 6 months ago

#31580 closed enhancement (fixed)

Update matplotlib to 3.4

Reported by: arojas Owned by:
Priority: critical Milestone: sage-9.5
Component: packages: standard Keywords:
Cc: mkoeppe, fbissey, gh_timokau Merged in:
Authors: Dima Pasechnik, François Bissey, Matthias Koeppe Reviewers: François Bissey, Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 475a26a (Commits, GitHub, GitLab) Commit: 475a26a44e587e043c5a85cb0677546d475b403a
Dependencies: Stopgaps:

Status badges

Description (last modified by arojas)

Causes some deprecation warnings due to set_dpi_cor. According to ​https://github.com/matplotlib/matplotlib/commit/1843a484194c45d4724431fe2990ad3e31d21ca5 this was a no-op, so we just remove it.

Change History (83)

comment:1 Changed 15 months ago by arojas

  • Branch set to u/arojas/update_matplotlib_to_3_4

comment:2 Changed 15 months ago by arojas

  • Cc mkoeppe fbissey gh_timokau added
  • Commit set to c2e282b5841a7b1c2586b71b94562b01ccd22d6c
  • Component changed from PLEASE CHANGE to packages: standard
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

New commits:

282ff30Remove call to deprecated set_dpi_cor
c2e282bUpdate matplotlib to 3.4.0
Last edited 15 months ago by arojas (previous) (diff)

comment:3 follow-up: Changed 15 months ago by fbissey

At this stage, I don't think that will make it in 9.3 unless there was something critical about it. That being said, would matplotlib 3.3.x work just as well with that line removed?

comment:4 in reply to: ↑ 3 Changed 15 months ago by arojas

Replying to fbissey:

At this stage, I don't think that will make it in 9.3 unless there was something critical about it. That being said, would matplotlib 3.3.x work just as well with that line removed?

Sure, I didn't expect it to - just didn't change the default Milestone value. I haven't tested, but given that the line in question didn't have any effect (according to the upstream commit I linked) I don't expect there to be any issues with 3.3.x

comment:5 follow-up: Changed 15 months ago by fbissey

I didn't really see your link earlier. Probably a bit too early in the morning for me to process information properly. In any case I was wondering if it would be OK to just squeeze that change in since it is a no-op anyway.

comment:6 Changed 15 months ago by arojas

  • Description modified (diff)

comment:7 in reply to: ↑ 5 Changed 15 months ago by arojas

Replying to fbissey:

I didn't really see your link earlier. Probably a bit too early in the morning for me to process information properly. In any case I was wondering if it would be OK to just squeeze that change in since it is a no-op anyway.

As usual, I wrote in the comment box instead of the description. Yes, would be nice to remove that line for 9.3 - would save me some garbage output when doctesting.

comment:8 Changed 15 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review.

comment:9 Changed 14 months ago by mkoeppe

  • Status changed from needs_review to needs_work

3.4.2 is out

comment:10 Changed 14 months ago by git

  • Commit changed from c2e282b5841a7b1c2586b71b94562b01ccd22d6c to 426b67a62c2cd132919be149c3d8a39d59c8bb10

Branch pushed to git repo; I updated commit sha1. New commits:

426b67aUpdate matplotlib to 3.4.2

comment:11 Changed 14 months ago by arojas

  • Authors set to Antonio Rojas
  • Status changed from needs_work to needs_review

comment:12 Changed 14 months ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

LGTM

comment:13 Changed 14 months ago by vbraun

  • Status changed from positive_review to needs_work

Build tries to download additional source files:

  copying lib/matplotlib/backends/web_backend/all_figures.html -> build/lib.linux-x86_64-3.9/matplotlib/backends/web_backend
  copying lib/matplotlib/mpl-data/fonts/pdfcorefonts/ZapfDingbats.afm -> build/lib.linux-x86_64-3.9/matplotlib/mpl-data/fonts/pdfcorefonts
  copying lib/matplotlib/mpl-data/fonts/afm/pagd8a.afm -> build/lib.linux-x86_64-3.9/matplotlib/mpl-data/fonts/afm
  copying lib/matplotlib/mpl-data/images/qt4_editor_options.svg -> build/lib.linux-x86_64-3.9/matplotlib/mpl-data/images
  copying lib/matplotlib/mpl-data/images/zoom_to_rect.png -> build/lib.linux-x86_64-3.9/matplotlib/mpl-data/images
  UPDATING build/lib.linux-x86_64-3.9/matplotlib/_version.py
  set build/lib.linux-x86_64-3.9/matplotlib/_version.py to '3.4.2'
  running build_ext
  error: Failed to download any of the following: ['http://www.qhull.org/download/qhull-2020-src-8.0.2.tgz'].  Please download one of these urls and extract it into 'build/' at the top-level of the source repository.
  Building wheel for matplotlib (setup.py): finished with status 'error'
  ERROR: Failed building wheel for matplotlib

comment:14 Changed 14 months ago by arojas

heh, so it looks like it no longer bundles qhull [1] so it will finally have to be made standard. Since this may take a while, I'll split off the sagelib part.

[1] https://github.com/matplotlib/matplotlib/commit/d81d15d368ec8b7fbdd3c0450d7d3ee96641ffe1

comment:15 Changed 14 months ago by arojas

  • Authors Antonio Rojas deleted
  • Dependencies set to #31827

Done in #31827

comment:16 Changed 12 months ago by dimpase

  • Dependencies changed from #31827 to #32213

comment:17 Changed 12 months ago by dimpase

  • Branch changed from u/arojas/update_matplotlib_to_3_4 to u/dimpase/packages/matplotlib/3_4
  • Commit changed from 426b67a62c2cd132919be149c3d8a39d59c8bb10 to 00522efd0721f633f8ffdd7fb880d0ed04226f15
  • Status changed from needs_work to needs_review

New commits:

a2db12cUpdate matplotlib to 3.4.0
59e4fa9Update matplotlib to 3.4.2
9879b7cbuild/pkgs/cmake/distros: Add alpine, arch, gentoo, nix
de6fde8build/pkgs/cmake: Update to 3.21.0
a8cbd93build/pkgs/cmake/type: Change to standard
0c566ddMerge branch 'u/mkoeppe/make_cmake_a_standard_package' of trac.sagemath.org:sage into u/dimpase/packages/matplotlib/3_4
00522efqhull is a dependency

comment:18 Changed 12 months ago by git

  • Commit changed from 00522efd0721f633f8ffdd7fb880d0ed04226f15 to 9c80f38ac309fcf9d94a279e7b48b750231ce3a9

Branch pushed to git repo; I updated commit sha1. New commits:

9c80f38qhull standard, as a dep of matplotlib

comment:20 Changed 12 months ago by mkoeppe

I haven't looked at the details, but it looks like our qhull package is outdated - https://repology.org/project/qhull/versions

comment:21 Changed 12 months ago by dimpase

  • Dependencies changed from #32213 to #32213, #31161
  • Status changed from needs_review to needs_work

errors about inability to build wheels for mathplotlib.

comment:22 Changed 12 months ago by dimpase

one needs to unconditionally allow qhull from the system in the python script generat8ng .cfg file.

comment:23 Changed 12 months ago by git

  • Commit changed from 9c80f38ac309fcf9d94a279e7b48b750231ce3a9 to c360d37190cf5272b6e62699313c2bff7f04674f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3ff41caUpdate matplotlib to 3.4.0
8cf68f6Update matplotlib to 3.4.2
f3e1b07build/pkgs/cmake/distros: Add alpine, arch, gentoo, nix
79cc7b9build/pkgs/cmake: Update to 3.21.0
94ffa8fbuild/pkgs/cmake/type: Change to standard
13ba8a8qhull is a dependency
6e76e02qhull standard, as a dep of matplotlib
c360d37do not vendor ghull, unconditionally

comment:24 Changed 12 months ago by git

  • Commit changed from c360d37190cf5272b6e62699313c2bff7f04674f to 9f9487626ad112b024d44cb02f25cc6cdb4a84d1

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

cbf8f4b31161: Upgrade: qhull 2020-src-8.0.2
fa99c20added basic spkg-configure.m4
4ed8c39Update matplotlib to 3.4.0
b2a0599Update matplotlib to 3.4.2
a2f910dbuild/pkgs/cmake/distros: Add alpine, arch, gentoo, nix
14bcb58build/pkgs/cmake: Update to 3.21.0
4c91e5cbuild/pkgs/cmake/type: Change to standard
54472c1qhull is a dependency
189ca21qhull standard, as a dep of matplotlib
9f94876do not vendor ghull, unconditionally

comment:25 Changed 12 months ago by dimpase

  • Status changed from needs_work to needs_review

comment:26 Changed 12 months ago by dimpase

There is a race condition in docbuild which leads to this GH Actions run erroring out on many systems, as follows:

  [dochtml]   [reference]     topology: 1937 js index entries
  [dochtml]   [reference]     valuations: 973 js index entries
  [dochtml]   [reference] ... done (64387 js index entries)
  [dochtml]   [reference] copying static files... failed
  [dochtml]   [reference] WARNING: cannot copy static file FileExistsError(17, 'File exists')
  [dochtml]   [reference] dumping search index in English (code: en)... done
  [dochtml]   [reference] The HTML pages are in .tox/local-homebrew-macos-standard/local/share/doc/sage/html/en/reference.
  [dochtml]   Error building the documentation.
  [dochtml]   Traceback (most recent call last):
  [dochtml]     File "/Users/runner/work/sagetrac-mirror/sagetrac-mirror/.tox/local-homebrew-macos-standard/homebrew/Cellar/python@3.9/3.9.6/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
  [dochtml]       return _run_code(code, main_globals, None,
  [dochtml]     File "/Users/runner/work/sagetrac-mirror/sagetrac-mirror/.tox/local-homebrew-macos-standard/homebrew/Cellar/python@3.9/3.9.6/Frameworks/Python.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
  [dochtml]       exec(code, run_globals)
  [dochtml]     File "/Users/runner/work/sagetrac-mirror/sagetrac-mirror/.tox/local-homebrew-macos-standard/local/lib/python3.9/site-packages/sage_docbuild/__main__.py", line 2, in <module>
  [dochtml]       main()
  [dochtml]     File "/Users/runner/work/sagetrac-mirror/sagetrac-mirror/.tox/local-homebrew-macos-standard/local/lib/python3.9/site-packages/sage_docbuild/__init__.py", line 1813, in main
  [dochtml]       builder()
  [dochtml]     File "/Users/runner/work/sagetrac-mirror/sagetrac-mirror/.tox/local-homebrew-macos-standard/local/lib/python3.9/site-packages/sage_docbuild/__init__.py", line 133, in f
  [dochtml]       runsphinx()
  [dochtml]     File "/Users/runner/work/sagetrac-mirror/sagetrac-mirror/.tox/local-homebrew-macos-standard/local/lib/python3.9/site-packages/sage_docbuild/sphinxbuild.py", line 323, in runsphinx
  [dochtml]       sys.stderr.raise_errors()
  [dochtml]     File "/Users/runner/work/sagetrac-mirror/sagetrac-mirror/.tox/local-homebrew-macos-standard/local/lib/python3.9/site-packages/sage_docbuild/sphinxbuild.py", line 258, in raise_errors
  [dochtml]       raise OSError(self._error)
  [dochtml]   OSError: WARNING: cannot copy static file FileExistsError(17, 'File exists')
  [dochtml]   
  [dochtml]       Note: incremental documentation builds sometimes cause spurious
  [dochtml]       error messages. To be certain that these are real errors, run
  [dochtml]       "make doc-clean" first and try again.
  [dochtml]   make[3]: *** [doc-html--reference_top] Error 1
  [dochtml]   make[2]: *** [doc-html-reference] Error 2
  [dochtml]   make[2]: Target `doc-html' not remade because of errors.
  [dochtml] Full log file: /Users/runner/work/sagetrac-mirror/sagetrac-mirror/logs/dochtml.log
make[1]: *** [doc-html] Error 2

this was altready reported on https://groups.google.com/g/sage-devel/c/ts6u19KpapA/m/22BdxXZhBAAJ

comment:27 Changed 12 months ago by klee

From #32262:

Replying to dimpase:

Replying to klee:

What is the command to reproduce the bug?

try building the branch of #31580 with make -jX (for X=8, say?) on macOS or Ubuntu.

Building fails with me:

[matplotlib-3.4.2] ERROR [transfer|run:135]: [Errno 404] Not Found: '//sagepad.org/spkg/upstream/matplotlib/matplotlib-3.4.2.tar.gz'
[matplotlib-3.4.2] ************************************************************************
[matplotlib-3.4.2] Traceback (most recent call last):
...
[matplotlib-3.4.2]     raise FileNotMirroredError('tarball does not exist on mirror network')
[matplotlib-3.4.2] FileNotMirroredError: tarball does not exist on mirror network

comment:28 Changed 12 months ago by dimpase

Of course the tarballs are not on the mirrors yet, this only happens after the ticket is merged etc.

You need to

./configure --enable-download-from-upstream-url

Then the URLs in checksum.ini files will be used if nothing is found on the mirrors. Due to this feature (crucial for CI), nobody lists explicit tarballs in ticket descriptions any more. (Or look at checksum.ini, find the URL, manually upload the tarfile to upstream/)

comment:29 Changed 11 months ago by dimpase

  • Dependencies changed from #32213, #31161 to #32213, #31161, #32262

comment:30 Changed 11 months ago by dimpase

  • Authors set to Dima Pasechnik

comment:31 Changed 11 months ago by git

  • Commit changed from 9f9487626ad112b024d44cb02f25cc6cdb4a84d1 to 829590548897bafc6183376653133b535243e4fc

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

98652ec31161: Add qhull distro info
26a5aa731161: Upgrade: qhull 2020-src-8.0.2
15ee2d7added basic spkg-configure.m4
50748e7Update matplotlib to 3.4.0
20d4fc4Update matplotlib to 3.4.2
af27c8bqhull is a dependency
cd4a0f2qhull standard, as a dep of matplotlib
0a0856edo not vendor ghull, unconditionally
8295905upstream patch to recitfy docbuild problem

comment:32 Changed 11 months ago by dimpase

  • Dependencies changed from #32213, #31161, #32262 to #32213, #31161

comment:33 Changed 11 months ago by mkoeppe

  • Milestone changed from sage-9.4 to sage-9.5

comment:34 Changed 10 months ago by mkoeppe

3.4.3 is out

comment:35 Changed 10 months ago by git

  • Commit changed from 829590548897bafc6183376653133b535243e4fc to f958b71125a06e6e043de9e09d513e09598807be

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

c3c3108Update matplotlib to 3.4.2
a67736eqhull is a dependency
f424c41qhull standard, as a dep of matplotlib
936203ddo not vendor ghull, unconditionally
13912acupstream patch to recitfy docbuild problem
78c663aupdate to 3.4.3
8cdfdac31161: Add qhull distro info
8c5cd8131161: Upgrade: qhull 2020-src-8.0.2
47df756added basic spkg-configure.m4
f958b71Merge branch 'public/31161' of trac.sagemath.org:sage into u/dimpase/packages/matplotlib/3_4

comment:36 Changed 10 months ago by git

  • Commit changed from f958b71125a06e6e043de9e09d513e09598807be to 5f2eaadd4eef2ac0285e064c89446206bf4bd1e4

Branch pushed to git repo; I updated commit sha1. New commits:

5f2eaadRevert "upstream patch to recitfy docbuild problem"

comment:37 Changed 10 months ago by dimpase

updated to 3.4.3.

comment:38 Changed 10 months ago by git

  • Commit changed from 5f2eaadd4eef2ac0285e064c89446206bf4bd1e4 to df91ddcc475c557fd4bb402a22212d7e9b714421

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

d30ca7d31161: Upgrade: qhull 2020-src-8.0.2
de66f70added basic spkg-configure.m4
2f044eeUpdate matplotlib to 3.4.0
4e9ecc4Update matplotlib to 3.4.2
9a3d7a3qhull is a dependency
00b580aqhull standard, as a dep of matplotlib
248bc95do not vendor ghull, unconditionally
97faa41upstream patch to recitfy docbuild problem
12fcaa7update to 3.4.3
df91ddcRevert "upstream patch to recitfy docbuild problem"

comment:39 Changed 10 months ago by dimpase

rebased over 9.5.beta1

comment:41 Changed 10 months ago by git

  • Commit changed from df91ddcc475c557fd4bb402a22212d7e9b714421 to df8d17c6a90076b6df852475c7c788f34276c211

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

64f613aadded basic spkg-configure.m4
0939967correct distros info
78184d4Update matplotlib to 3.4.0
696978fUpdate matplotlib to 3.4.2
992f989qhull is a dependency
18fddf8qhull standard, as a dep of matplotlib
fa16032do not vendor ghull, unconditionally
d45933bupstream patch to recitfy docbuild problem
862e656update to 3.4.3
df8d17cRevert "upstream patch to recitfy docbuild problem"

comment:42 in reply to: ↑ 40 Changed 10 months ago by dimpase

  • Reviewers changed from François Bissey to François Bissey, https://github.com/sagemath/sagetrac-mirror/actions/runs/1233224818
Last edited 10 months ago by dimpase (previous) (diff)

comment:43 Changed 10 months ago by git

  • Commit changed from df8d17c6a90076b6df852475c7c788f34276c211 to 382de1b20acc063c62a41bc9f2bd63b726686e79

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7e7e983correct package name on debian
e073d08replace tabs by spaces, adjust spacing
094592eUpdate matplotlib to 3.4.0
33e9833Update matplotlib to 3.4.2
a004b06qhull is a dependency
6d150f1qhull standard, as a dep of matplotlib
fcb3fc7do not vendor ghull, unconditionally
70876f6upstream patch to recitfy docbuild problem
b879882update to 3.4.3
382de1bRevert "upstream patch to recitfy docbuild problem"

comment:44 Changed 10 months ago by dimpase

  • Reviewers changed from François Bissey, https://github.com/sagemath/sagetrac-mirror/actions/runs/1233224818 to François Bissey, https://github.com/sagemath/sagetrac-mirror/actions/runs/1235471874

comment:45 Changed 10 months ago by dimpase

tests are done, please have a look

comment:46 Changed 9 months ago by dimpase

  • Dependencies changed from #32213, #31161 to #31161

comment:47 Changed 8 months ago by mkoeppe

Also the dependencies of matplotlib: cycler, kiwisolver, ... are outdated

comment:48 Changed 8 months ago by git

  • Commit changed from 382de1b20acc063c62a41bc9f2bd63b726686e79 to 8af511c414982483de66a93d84865475b262efc1

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6cd3723Update matplotlib to 3.4.0
4d742f2Update matplotlib to 3.4.2
e406102qhull is a dependency
51ba6f3qhull standard, as a dep of matplotlib
8669821do not vendor ghull, unconditionally
f999e9bupstream patch to recitfy docbuild problem
af761faupdate to 3.4.3
24b7a9aRevert "upstream patch to recitfy docbuild problem"
42435f4add gfortran to _prereq/distros/*
8af511crebase, update deps

comment:49 Changed 8 months ago by git

  • Commit changed from 8af511c414982483de66a93d84865475b262efc1 to 5c972e4f1e27382191f268880c5222dc9d687d11

Branch pushed to git repo; I updated commit sha1. New commits:

5c972e4correct checksum

comment:50 Changed 8 months ago by dimpase

  • Status changed from needs_review to needs_work

and more new deps are coming, such as cppy... hold tight

comment:51 Changed 8 months ago by git

  • Commit changed from 5c972e4f1e27382191f268880c5222dc9d687d11 to c7ab8fe14fed24254a9d637556ddd799431e0450

Branch pushed to git repo; I updated commit sha1. New commits:

00b677bnew dep of kiwisolver, cppy
c7ab8feupdate matplotlib deps

comment:52 Changed 8 months ago by git

  • Commit changed from c7ab8fe14fed24254a9d637556ddd799431e0450 to 48b7ec3849754abb1a526887a85f6fdd4e6a4d30

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

48b7ec3update matplotlib deps

comment:53 Changed 8 months ago by mkoeppe

cppy is missing SPKG.rst. Consider using sage --package create --pypi cppy to create packages...

comment:54 Changed 8 months ago by git

  • Commit changed from 48b7ec3849754abb1a526887a85f6fdd4e6a4d30 to 15369f95d8bbff3fee1cb0bab14e17b3dc38fabd

Branch pushed to git repo; I updated commit sha1. New commits:

15369f9fix SPKG.rst's for cppy and kiwisolver

comment:55 Changed 8 months ago by dimpase

  • Status changed from needs_work to needs_review

comment:56 Changed 8 months ago by mkoeppe

Let's get rid of these "Dependencies" sections in SPKG.rst please if they just duplicate what's in the dependencies file.

comment:57 Changed 8 months ago by git

  • Commit changed from 15369f95d8bbff3fee1cb0bab14e17b3dc38fabd to 26910e65f5357fc2f6505440fccc718a52908872

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

26910e6fix SPKG.rst's for cppy and kiwisolver

comment:58 Changed 8 months ago by dimpase

  • Dependencies #31161 deleted

New commits:

26910e6fix SPKG.rst's for cppy and kiwisolver

New commits:

26910e6fix SPKG.rst's for cppy and kiwisolver

comment:59 Changed 8 months ago by mkoeppe

  • Dependencies set to #31161
diff --git a/build/pkgs/_prereq/distros/debian.txt b/build/pkgs/_prereq/distros/debian.txt
index 50be6ac..c348ee3 100644
--- a/build/pkgs/_prereq/distros/debian.txt
+++ b/build/pkgs/_prereq/distros/debian.txt
@@ -26,5 +26,6 @@ gcc
 # configure: error: in `/sage':
 # configure: error: C++ preprocessor "/lib/cpp" fails sanity check
 g++
+gfortran
 # Needed if we download some packages from a https upstream URL
 ca-certificates

Please don't sneak these changes in.

comment:60 Changed 8 months ago by mkoeppe

  • Dependencies #31161 deleted

comment:61 Changed 8 months ago by mkoeppe

  • Status changed from needs_review to needs_work

comment:62 Changed 8 months ago by git

  • Commit changed from 26910e65f5357fc2f6505440fccc718a52908872 to aedaf93a51ee4bd69cf61b7c999940d6990b911c

Branch pushed to git repo; I updated commit sha1. New commits:

aedaf93Revert "add gfortran to _prereq/distros/*"

comment:63 Changed 8 months ago by dimpase

oops, sorry, should be OK now.

comment:64 Changed 8 months ago by dimpase

  • Status changed from needs_work to needs_review

comment:65 Changed 8 months ago by mkoeppe

--- a/build/pkgs/cycler/checksums.ini
+++ b/build/pkgs/cycler/checksums.ini
@@ -1,4 +1,5 @@
 tarball=cycler-VERSION.tar.gz
-sha1=1bcf4a985a5f414333603f3f70a7deebbaf30439
-md5=4cb42917ac5007d1cdff6cccfe2d016b
-cksum=4189438538
+sha1=ea144185cf1d54d7415e3c66d705d9a232e57da5
+md5=cf3b4846fded12fa4d2a7a291a5d6e13
+cksum=3626319704
+upstream_url=https://github.com/matplotlib/cycler/archive/refs/tags/vVERSION.tar.gz

Please use PyPI URL, not a github archive

comment:66 Changed 8 months ago by git

  • Commit changed from aedaf93a51ee4bd69cf61b7c999940d6990b911c to 62792d4b191d2116774562147a5d089b88d5c1cd

Branch pushed to git repo; I updated commit sha1. New commits:

62792d4use pypi host for cycler url

comment:67 Changed 8 months ago by arojas

In the meantime, 3.5 is released with new dependencies (fonttools) and new deprecations. I've opened #32909 to fix these.

comment:68 Changed 7 months ago by dimpase

OK, so can this ticket get in, please?

comment:69 follow-up: Changed 7 months ago by tornaria

Note that matplotlib 3.5 is needed to avoid distutils deprecation warnings with python 3.10 (see https://trac.sagemath.org/ticket/30766#comment:68).

The actual commit fixing the deprecation warning is https://github.com/matplotlib/matplotlib/commit/7d77bb96707f10032d8fedf2bd225491f9a28afe

comment:70 follow-up: Changed 7 months ago by dimpase

Are we aiming at a full support of Python 3.10 in 9.5? If so, I guess we should go straight to matplotlib 3.5.

comment:71 in reply to: ↑ 70 Changed 7 months ago by mkoeppe

Replying to dimpase:

Are we aiming at a full support of Python 3.10 in 9.5?

Not sure if we can/should. I think it's better to have a release very soon because of the glibc 2.34 issue (#32576), which lots of people are already running into.

comment:72 in reply to: ↑ 69 Changed 7 months ago by mkoeppe

Replying to tornaria:

Note that matplotlib 3.5 is needed to avoid distutils deprecation warnings with python 3.10

Opened #33040 for this

comment:73 Changed 7 months ago by mkoeppe

  • Priority changed from major to critical
  • Reviewers changed from François Bissey, https://github.com/sagemath/sagetrac-mirror/actions/runs/1235471874 to François Bissey, Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:74 Changed 7 months ago by vbraun

  • Status changed from positive_review to needs_work

On OSX:

**********************************************************************
File "src/sage/plot/plot3d/list_plot3d.py", line 380, in sage.plot.plot3d.list_plot3d.list_plot3d_tuples
Failed example:
    list_plot3d(m, color='yellow', interpolation_type='linear', num_points=5) # indirect doctest
Exception raised:
    Traceback (most recent call last):
      File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/doctest/forker.py", line 694, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/doctest/forker.py", line 1088, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.plot.plot3d.list_plot3d.list_plot3d_tuples[2]>", line 1, in <module>
        list_plot3d(m, color='yellow', interpolation_type='linear', num_points=Integer(5)) # indirect doctest
      File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/plot/plot3d/list_plot3d.py", line 188, in list_plot3d
        return list_plot3d_tuples(data, interpolation_type, **kwds)
      File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/sage/plot/plot3d/list_plot3d.py", line 453, in list_plot3d_tuples
        T = tri.Triangulation(x, y)
      File "/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/matplotlib/tri/triangulation.py", line 39, in __init__
        from matplotlib import _qhull
    ImportError: dlopen(/Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/matplotlib/_qhull.cpython-39-darwin.so, 2): Library not loaded: lib/libqhull_r.8.0.dylib
      Referenced from: /Users/buildbot-sage/worker/sage_git/build/local/var/lib/sage/venv-python3.9.9/lib/python3.9/site-packages/matplotlib/_qhull.cpython-39-darwin.so
      Reason: image not found
**********************************************************************
1 item had failures:
   1 of   7 in sage.plot.plot3d.list_plot3d.list_plot3d_tuples
    [48 tests, 1 failure, 4.36 s]
----------------------------------------------------------------------
sage -t --long --random-seed=269285139450068045496865355624462748906 src/sage/plot/plot3d/list_plot3d.py  # 1 doctest failed
----------------------------------------------------------------------

comment:75 Changed 7 months ago by fbissey

Looks like some wrong install_name was used on that qhull install. Is qhull supposed to come from conda, brew or sage internals on OSX during those testruns?

It is a bit strange it wasn't seen before.

comment:76 Changed 7 months ago by fbissey

OK, qhull used to be optional and has been switched to standard with this release. Unfortunately boiler plate sdh_cmake doesn't set install_name properly for qhull. I am not sure how it all install in the proper places but to get the right rpath and install_name, -DLIB_INSTALL_DIR=... has to be passed to camke when configuring.

I'll fix that ASAP. This would affect the further upgrade to 3.5.1.

comment:77 Changed 7 months ago by fbissey

  • Branch changed from u/dimpase/packages/matplotlib/3_4 to u/fbissey/MPL3_4
  • Commit changed from 62792d4b191d2116774562147a5d089b88d5c1cd to 0e5c130c196c6ad849212e536fee06e808771f36
  • Status changed from needs_work to needs_review

Should work now.


New commits:

0018e34Merge branch 'develop' into MPL3_4
0e5c130Specify custom variable LIB_INSTALL_DIR for qhull, it controls rpath and install_name settings on OSX

comment:78 Changed 7 months ago by fbissey

  • Authors changed from Dima Pasechnik to Dima Pasechnik, François Bissey

comment:79 Changed 7 months ago by mkoeppe

  • Status changed from needs_review to needs_work

Also cppy is missing install-requires.txt.

comment:80 Changed 7 months ago by mkoeppe

  • Branch changed from u/fbissey/MPL3_4 to u/mkoeppe/MPL3_4

comment:81 Changed 7 months ago by mkoeppe

  • Authors changed from Dima Pasechnik, François Bissey to Dima Pasechnik, François Bissey, Matthias Koeppe
  • Commit changed from 0e5c130c196c6ad849212e536fee06e808771f36 to 475a26a44e587e043c5a85cb0677546d475b403a
  • Status changed from needs_work to needs_review

New commits:

475a26abuild/pkgs/cppy/install-requires.txt: New

comment:82 Changed 7 months ago by mkoeppe

  • Status changed from needs_review to positive_review

comment:83 Changed 6 months ago by vbraun

  • Branch changed from u/mkoeppe/MPL3_4 to 475a26a44e587e043c5a85cb0677546d475b403a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.