tox.ini, build/bin/write-dockerfile.sh: Do not use "make -k" by default
Reported by: |
mkoeppe |
Owned by: |
|
Priority:
|
minor
|
Milestone:
|
sage-9.9
|
Component:
|
porting
|
Keywords:
|
|
Cc:
|
jhpalmieri
|
Merged in:
|
|
Authors:
|
Matthias Koeppe
|
Reviewers:
|
|
Report Upstream:
|
N/A
|
Work issues:
|
|
Branch:
|
u/mkoeppe/tox_ini__build_bin_write_dockerfile_sh__do_not_use__make__k__by_default
(Commits, GitHub, GitLab) |
Commit:
|
4aede699ebd63db287002db47fd4af02fdd5091d
|
Dependencies:
|
|
Stopgaps:
|
|
... only set it in the GH Actions workflows by setting MAKE
or USE_MAKEFLAGS
.
This will make it less surprising for manual use.
Before merging this, we need to remember to update ci-sage.yml
of upstream packages!
Change History (11)
Milestone: |
sage-9.3 →
sage-9.4
|
Priority: |
major →
minor
|
Branch: |
→ u/mkoeppe/tox_ini__build_bin_write_dockerfile_sh__do_not_use__make__k__by_default
|
Authors: |
→ Matthias Koeppe
|
Commit: |
→ 4aede699ebd63db287002db47fd4af02fdd5091d
|
Description: |
modified (diff)
|
Milestone: |
sage-9.4 →
sage-9.5
|
Milestone: |
sage-9.5 →
sage-9.6
|
Milestone: |
sage-9.6 →
sage-9.7
|
Milestone: |
sage-9.7 →
sage-9.8
|
Milestone: |
sage-9.8 →
sage-9.9
|
As a wishlist item, for uniformity perhaps we can use environment variable
MAKE
for docker builds as well, instead of asking users to pass theUSE_MAKEFLAGS
variable.New commits:
.github/workflows/ci-cygwin-*.yml: Use 'make -k' explicitly
.github/workflows/tox*.yml: Give the main workflow step a name so it looks nicer on GH Actions
.github/workflows/tox-*.yml: Use 'make -k' explicitly
.github/workflows/ci-wsl.yml: Use 'make -k' explicitly
tox.ini, build/bin/write-dockerfile.sh: Do not use 'make -k' by default