Opened 20 months ago

Last modified 3 months ago

#31574 new enhancement

tox.ini, build/bin/write-dockerfile.sh: Do not use "make -k" by default

Reported by: Matthias Köppe Owned by:
Priority: minor Milestone: sage-9.8
Component: porting Keywords:
Cc: John Palmieri Merged in:
Authors: Matthias Koeppe Reviewers:
Report Upstream: N/A Work issues:
Branch: u/mkoeppe/tox_ini__build_bin_write_dockerfile_sh__do_not_use__make__k__by_default (Commits, GitHub, GitLab) Commit: 4aede699ebd63db287002db47fd4af02fdd5091d
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

... only set it in the GH Actions workflows by setting MAKE or USE_MAKEFLAGS.

This will make it less surprising for manual use.

Before merging this, we need to remember to update ci-sage.yml of upstream packages!

Change History (10)

comment:1 Changed 20 months ago by Matthias Köppe

Dependencies: #31521

comment:2 Changed 20 months ago by Matthias Köppe

Dependencies: #31521

comment:3 Changed 20 months ago by Matthias Köppe

Milestone: sage-9.3sage-9.4
Priority: majorminor

comment:4 Changed 20 months ago by Matthias Köppe

Branch: u/mkoeppe/tox_ini__build_bin_write_dockerfile_sh__do_not_use__make__k__by_default

comment:5 Changed 20 months ago by Matthias Köppe

Authors: Matthias Koeppe
Commit: 4aede699ebd63db287002db47fd4af02fdd5091d

As a wishlist item (noted in #29146), for uniformity perhaps we can use environment variable MAKE for docker builds as well, instead of asking users to pass the USE_MAKEFLAGS variable.


New commits:

ba13cd0.github/workflows/ci-cygwin-*.yml: Use 'make -k' explicitly
3df8fc9.github/workflows/tox*.yml: Give the main workflow step a name so it looks nicer on GH Actions
cf41b79.github/workflows/tox-*.yml: Use 'make -k' explicitly
11fc6a1.github/workflows/ci-wsl.yml: Use 'make -k' explicitly
4aede69tox.ini, build/bin/write-dockerfile.sh: Do not use 'make -k' by default
Last edited 20 months ago by Matthias Köppe (previous) (diff)

comment:6 Changed 20 months ago by Matthias Köppe

Description: modified (diff)

comment:7 Changed 17 months ago by Matthias Köppe

Milestone: sage-9.4sage-9.5

comment:8 Changed 12 months ago by Matthias Köppe

Milestone: sage-9.5sage-9.6

comment:9 Changed 8 months ago by Matthias Köppe

Milestone: sage-9.6sage-9.7

comment:10 Changed 3 months ago by Matthias Köppe

Milestone: sage-9.7sage-9.8
Note: See TracTickets for help on using tickets.