#31573 closed defect (fixed)

Improve the Weierstrass sigma function on the formal group of an elliptic curve

Reported by: wuthrich Owned by:
Priority: major Milestone: sage-9.4
Component: elliptic curves Keywords: sigma, formal group
Cc: Cremona Merged in:
Authors: Chris Wuthrich Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: da19ab3 (Commits, GitHub, GitLab) Commit: da19ab399c9c2ad0ed0da302db2cbb14138deb9b
Dependencies: Stopgaps:

Status badges

Description

Initiated by this mathoverflow question I propose to improve the documentation of sigma for a formal group of an elliptic curve as well as simplify it.

For historic reasons, it produced a power series with coefficients containing one, now useless, indeterminate. This ticket changes the code to return simply a power series in the base field of the elliptic curve. And it clarifies the documentation.

Change History (9)

comment:1 Changed 22 months ago by wuthrich

Branch: u/wuthrich/ticket_31573
Commit: d8fd8c6942d78393afaec4556c4bb4015d3e8aa4

New commits:

d83c82bchange sigma in formal groups of elliptic curves
fa93ec8docstring improvement
d8fd8c6small correction in docstring of elliptic_curves rank

comment:2 Changed 22 months ago by wuthrich

Status: newneeds_review

comment:3 Changed 22 months ago by chapoton

Returns the Weierstrass should be Return the Weierstrass

comment:4 Changed 22 months ago by git

Commit: d8fd8c6942d78393afaec4556c4bb4015d3e8aa4a4bb7f30b9cf7aacb5869f90f91c9fc90a6f329c

Branch pushed to git repo; I updated commit sha1. New commits:

a4bb7f3returns a return now

comment:5 Changed 22 months ago by chapoton

typos

"an function" > "a function"

powerseries > power series

also please remove the commented lines

comment:6 Changed 22 months ago by git

Commit: a4bb7f30b9cf7aacb5869f90f91c9fc90a6f329cda19ab399c9c2ad0ed0da302db2cbb14138deb9b

Branch pushed to git repo; I updated commit sha1. New commits:

da19ab3ticket 31573 improve docstring

comment:7 Changed 22 months ago by wuthrich

embarrassing. Thanks for spotting these, Frédéric.

comment:8 Changed 22 months ago by chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

ok, thanks, then positive

comment:9 Changed 20 months ago by vbraun

Branch: u/wuthrich/ticket_31573da19ab399c9c2ad0ed0da302db2cbb14138deb9b
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.