Opened 7 weeks ago

Last modified 6 weeks ago

#31571 positive_review enhancement

Improve interface to plantri

Reported by: slelievre Owned by:
Priority: major Milestone: sage-9.4
Component: graph theory Keywords: plantri
Cc: dcoudert, slelievre Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: public/graphs/31571_planar_graphs (Commits, GitHub, GitLab) Commit: ad07e9413ac76528dfec905b7be3bf551df5e422
Dependencies: Stopgaps:

Status badges

Description

Change History (6)

comment:1 Changed 7 weeks ago by dcoudert

  • Authors set to David Coudert
  • Branch set to public/graphs/31571_planar_graphs
  • Commit set to eae2799cc42dd3e68d6a66a135cfc86222aababb
  • Status changed from new to needs_review

We can discuss the names of the parameters.

The method needs to be cleaned, but I let that for other tickets.


New commits:

eae2799trac #31571: more parameters for planar_graphs

comment:2 Changed 7 weeks ago by git

  • Commit changed from eae2799cc42dd3e68d6a66a135cfc86222aababb to ad07e9413ac76528dfec905b7be3bf551df5e422

Branch pushed to git repo; I updated commit sha1. New commits:

ad07e94trac #31571: remove useless import

comment:3 Changed 6 weeks ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, validé

comment:4 follow-up: Changed 6 weeks ago by dcoudert

In a future ticket we could allow a user to pass directly a string of commands to plantri as done in graphs.nauty_geng.

comment:5 in reply to: ↑ 4 Changed 6 weeks ago by slelievre

Replying to dcoudert:

In a future ticket we could allow a user to pass directly a string of commands to plantri as done in graphs.nauty_geng.

I opened #31590 for that.

comment:6 Changed 6 weeks ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Moving this ticket to 9.4, as it seems unlikely that it will be merged in 9.3, which is in the release candidate stage

Note: See TracTickets for help on using tickets.