Opened 21 months ago

Last modified 3 months ago

#31566 needs_work enhancement

add support for dynamical systems over function field in function periodic_points

Reported by: Saher Amasha Owned by:
Priority: minor Milestone: sage-9.8
Component: dynamics Keywords:
Cc: Ben Hutz Merged in:
Authors: Saher Amasha,Safa Amasha Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: u/gh-Saher-Amasha/add_support_for_dynamical_systems_over_function_field_in_function_periodic_points (Commits, GitHub, GitLab) Commit: 6fade29272cc5c9d46eab72f02c4bd38eb1324cb
Dependencies: Stopgaps:

Status badges

Description

we modified the if condition so that it doesn't throw an error when working with dynamical systems over function field, the actual code of the function is not changed(except the if condition) because it works on dynamical systems over function field

Change History (11)

comment:1 Changed 21 months ago by Matthias Köppe

Milestone: sage-9.3sage-9.4

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

comment:2 Changed 20 months ago by Saher Amasha

Branch: u/gh-Saher-Amasha/add_support_for_dynamical_systems_over_function_field_in_function_periodic_points

comment:3 Changed 20 months ago by Saher Amasha

Commit: 51f9c7252d054baf3bd370942a6ca08ccaa4d9af
Status: newneeds_review

New commits:

51f9c72modified the if condition

comment:4 Changed 20 months ago by Travis Scrimshaw

Cc: Ben Hutz added
Reviewers: Travis Scrimshaw

Why are you checking the base ring and not the ring R?

comment:5 Changed 20 months ago by Ben Hutz

Yes, you should be checking R to save an extra call of .base-ring()

You also need to add at least one example.

comment:6 Changed 20 months ago by git

Commit: 51f9c7252d054baf3bd370942a6ca08ccaa4d9af6fade29272cc5c9d46eab72f02c4bd38eb1324cb

Branch pushed to git repo; I updated commit sha1. New commits:

6fade29added 1 example,saved an extra call of .base-ring()

comment:7 Changed 17 months ago by Matthias Köppe

Milestone: sage-9.4sage-9.5

Setting a new milestone for this ticket based on a cursory review.

comment:8 Changed 16 months ago by Alexander Galarraga

Component: algebradynamics
Status: needs_reviewneeds_work

Merge conflict on the latest release.

Also, the example should include a t, so that the map is properly defined over the function field.

The latest release also throws an unnecessary ValueError? when minimal=False over function fields. This can be fixed in this ticket or a separate ticket.

comment:9 Changed 12 months ago by Matthias Köppe

Milestone: sage-9.5sage-9.6

comment:10 Changed 8 months ago by Matthias Köppe

Milestone: sage-9.6sage-9.7

comment:11 Changed 3 months ago by Matthias Köppe

Milestone: sage-9.7sage-9.8
Note: See TracTickets for help on using tickets.