#31562 closed defect (fixed)

Patch giac so that libintl from /usr/local does not leak in on macOS

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.4
Component: packages: standard Keywords:
Cc: Volker Braun, François Bissey, Dima Pasechnik, Bernard Parisse, Han Frederic Merged in:
Authors: Matthias Koeppe Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 89f61d2 (Commits, GitHub, GitLab) Commit: 89f61d2acd527c659fd1a04239661c1bb172106d
Dependencies: Stopgaps:

Status badges

Description

Crucial for building binary distributions on systems that have homebrew installed.

Attachments (1)

giac-1.6.0.47p3.tar.bz2 (34.9 MB) - added by Matthias Köppe 21 months ago.

Change History (15)

Changed 21 months ago by Matthias Köppe

Attachment: giac-1.6.0.47p3.tar.bz2 added

comment:1 Changed 21 months ago by Matthias Köppe

Branch: u/mkoeppe/patch_giac_so_that_libintl_from__usr_local_does_not_leak_in_on_macos

comment:2 Changed 21 months ago by git

Commit: 1b0a9eed3e0facc3820ec4b64e23fc6a2178da8b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1ef46d0build/pkgs/giac: Add another patch in patches/autotools
1b0a9eebuild/pkgs/giac: Update to 1.6.0.47p3

comment:3 Changed 21 months ago by Matthias Köppe

Authors: Matthais Koeppe
Cc: François Bissey Dima Pasechnik added
Priority: majorcritical
Status: newneeds_review

comment:4 Changed 21 months ago by Matthias Köppe

Authors: Matthais KoeppeMatthias Koeppe

comment:5 Changed 21 months ago by git

Commit: 1b0a9eed3e0facc3820ec4b64e23fc6a2178da8b89f61d2acd527c659fd1a04239661c1bb172106d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

89f61d2build/pkgs/giac: Update to 1.6.0.47p3

comment:6 Changed 21 months ago by Matthias Köppe

Cc: Bernard Parisse Han Frederic added

comment:7 Changed 21 months ago by François Bissey

Current upstream release (1.7.0-1) has

ALL_LINGUAS="es fr el pt it en zh de"
AM_GNU_GETTEXT
AM_GNU_GETTEXT_VERSION([0.14.5])
dnl for Slowlaris comment next line
dnl AC_CHECK_LIB(intl, main) 

Not sure if it meant to be "uncomment for solaris" but upstream has already commented it in the main body. I note, however that it is still checked over again for cygwin when gui is on.

comment:8 Changed 21 months ago by Matthias Köppe

Thanks! Yes, I have not attempted to make changes to the cygwin code.

comment:9 Changed 21 months ago by Matthias Köppe

Let's get this in please.

comment:10 Changed 21 months ago by François Bissey

Reviewers: François Bissey
Status: needs_reviewpositive_review

Looks good as is. Ship it.

comment:11 Changed 21 months ago by Matthias Köppe

Priority: criticalblocker

Thanks!

comment:12 Changed 21 months ago by Volker Braun

Priority: blockermajor

comment:13 Changed 20 months ago by Matthias Köppe

Milestone: sage-9.3sage-9.4

comment:14 Changed 19 months ago by Volker Braun

Branch: u/mkoeppe/patch_giac_so_that_libintl_from__usr_local_does_not_leak_in_on_macos89f61d2acd527c659fd1a04239661c1bb172106d
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.