Opened 6 months ago

Closed 4 months ago

#31562 closed defect (fixed)

Patch giac so that libintl from /usr/local does not leak in on macOS

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.4
Component: packages: standard Keywords:
Cc: vbraun, fbissey, dimpase, parisse, frederichan Merged in:
Authors: Matthias Koeppe Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 89f61d2 (Commits, GitHub, GitLab) Commit: 89f61d2acd527c659fd1a04239661c1bb172106d
Dependencies: Stopgaps:

Status badges

Description

Crucial for building binary distributions on systems that have homebrew installed.

Attachments (1)

giac-1.6.0.47p3.tar.bz2 (34.9 MB) - added by mkoeppe 6 months ago.

Change History (15)

Changed 6 months ago by mkoeppe

comment:1 Changed 6 months ago by mkoeppe

  • Branch set to u/mkoeppe/patch_giac_so_that_libintl_from__usr_local_does_not_leak_in_on_macos

comment:2 Changed 6 months ago by git

  • Commit set to 1b0a9eed3e0facc3820ec4b64e23fc6a2178da8b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1ef46d0build/pkgs/giac: Add another patch in patches/autotools
1b0a9eebuild/pkgs/giac: Update to 1.6.0.47p3

comment:3 Changed 6 months ago by mkoeppe

  • Authors set to Matthais Koeppe
  • Cc fbissey dimpase added
  • Priority changed from major to critical
  • Status changed from new to needs_review

comment:4 Changed 6 months ago by mkoeppe

  • Authors changed from Matthais Koeppe to Matthias Koeppe

comment:5 Changed 6 months ago by git

  • Commit changed from 1b0a9eed3e0facc3820ec4b64e23fc6a2178da8b to 89f61d2acd527c659fd1a04239661c1bb172106d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

89f61d2build/pkgs/giac: Update to 1.6.0.47p3

comment:6 Changed 6 months ago by mkoeppe

  • Cc parisse frederichan added

comment:7 Changed 6 months ago by fbissey

Current upstream release (1.7.0-1) has

ALL_LINGUAS="es fr el pt it en zh de"
AM_GNU_GETTEXT
AM_GNU_GETTEXT_VERSION([0.14.5])
dnl for Slowlaris comment next line
dnl AC_CHECK_LIB(intl, main) 

Not sure if it meant to be "uncomment for solaris" but upstream has already commented it in the main body. I note, however that it is still checked over again for cygwin when gui is on.

comment:8 Changed 6 months ago by mkoeppe

Thanks! Yes, I have not attempted to make changes to the cygwin code.

comment:9 Changed 6 months ago by mkoeppe

Let's get this in please.

comment:10 Changed 6 months ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Looks good as is. Ship it.

comment:11 Changed 6 months ago by mkoeppe

  • Priority changed from critical to blocker

Thanks!

comment:12 Changed 6 months ago by vbraun

  • Priority changed from blocker to major

comment:13 Changed 5 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

comment:14 Changed 4 months ago by vbraun

  • Branch changed from u/mkoeppe/patch_giac_so_that_libintl_from__usr_local_does_not_leak_in_on_macos to 89f61d2acd527c659fd1a04239661c1bb172106d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.