#31524 closed enhancement (fixed)

refresh one file about quadratic forms

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.3
Component: quadratic forms Keywords:
Cc: slelievre Merged in:
Authors: Frédéric Chapoton Reviewers: Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: c471061 (Commits, GitHub, GitLab) Commit: c4710617cf39ff4aabd355cf709b42dbf84093bf
Dependencies: Stopgaps:

Status badges

Description

  • do not use Returns but Return
  • do not use bare Exception
  • remove unused imports
  • better raise statements
  • less verbose comments

Change History (8)

comment:1 Changed 17 months ago by chapoton

  • Branch set to u/chapoton/31524
  • Status changed from new to needs_review

comment:2 Changed 17 months ago by git

  • Commit set to f72d89be633d0e5f94f387948a13a2f4c3809e2a

Branch pushed to git repo; I updated commit sha1. New commits:

f72d89brefresh quadratic_form__genus.py

comment:3 Changed 17 months ago by slelievre

  • Reviewers set to Samuel Lelièvre

Good cleanup. Maybe take the opportunity to fix a typo:

-    Return the genus of a two times a quadratic form over `\ZZ`.
+    Return the genus of two times a quadratic form over `\ZZ`.

and to turn "Conway-Sloane" into a proper reference; probably it's this book?

But also okay to call these further things out of scope here.

comment:4 Changed 17 months ago by git

  • Commit changed from f72d89be633d0e5f94f387948a13a2f4c3809e2a to e34e795388adbd4ae245544c1f3fa95665277061

Branch pushed to git repo; I updated commit sha1. New commits:

e34e795add and fix Conway-Sloane reference

comment:5 Changed 17 months ago by chapoton

Voici. J'en ai profité pour unifier les 2 références au même livre.

comment:6 Changed 17 months ago by git

  • Commit changed from e34e795388adbd4ae245544c1f3fa95665277061 to c4710617cf39ff4aabd355cf709b42dbf84093bf

Branch pushed to git repo; I updated commit sha1. New commits:

c471061one more CS1999

comment:7 Changed 17 months ago by slelievre

  • Cc slelievre added
  • Status changed from needs_review to positive_review

Super.

comment:8 Changed 17 months ago by vbraun

  • Branch changed from u/chapoton/31524 to c4710617cf39ff4aabd355cf709b42dbf84093bf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.