Opened 9 months ago

Closed 8 months ago

#31521 closed defect (fixed)

numpy build broken with SAGE_FAT_BINARY=yes

Reported by: mkoeppe Owned by:
Priority: blocker Milestone: sage-9.3
Component: packages: standard Keywords:
Cc: embray, gh-kliem, dimpase, vbraun Merged in:
Authors: Jonathan Kliem Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 128e8ef (Commits, GitHub, GitLab) Commit: 128e8ef688fe3cba05b19f39e469cf3832be1e4a
Dependencies: #29537 Stopgaps:

Status badges

Description

Follow up from #29537.

Change History (8)

comment:1 Changed 9 months ago by mkoeppe

On macOS, with SAGE_FAT_BINARY=yes, I just got:

    [numpy-1.19.5]   Running from numpy source directory.
    [numpy-1.19.5]   Cythonizing sources
    [numpy-1.19.5]   usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
    [numpy-1.19.5]      or: setup.py --help [cmd1 cmd2 ...]
    [numpy-1.19.5]      or: setup.py --help-commands
    [numpy-1.19.5]      or: setup.py cmd --help
    [numpy-1.19.5]
    [numpy-1.19.5]   error: option --cpu-dispatch not recognized
    [numpy-1.19.5]   ********************************************************************************
    [numpy-1.19.5]   Error building a wheel for numpy-1.19.5

comment:2 Changed 9 months ago by mkoeppe

  • Cc dimpase added

comment:3 Changed 9 months ago by mkoeppe

  • Cc vbraun added
  • Summary changed from cygwin: numpy not portable despite using SAGE_FAT_BINARY=yes to numpy build broken with SAGE_FAT_BINARY=yes

Indeed, --cpu-dispatch has only been introduced in the 1.20.x series. We are still at 1.19.5.

Wondering how this has possibly passed in previous tests?!

comment:4 Changed 9 months ago by mkoeppe

And I guess the prefix SAGE_ can be removed in the variable names in sage_conf...

comment:5 Changed 9 months ago by gh-kliem

  • Authors set to Jonathan Kliem
  • Branch set to public/31521
  • Commit set to 128e8ef688fe3cba05b19f39e469cf3832be1e4a
  • Status changed from new to needs_review

Reverting for now until numpy is updated.


New commits:

128e8efRevert "do not allow numpy intrinsics when building fat binary"

comment:6 follow-up: Changed 9 months ago by mkoeppe

  • Component changed from porting: Cygwin to packages: standard
  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

Thanks!

But we'll need another ticket then to actually fix the nonportability of the build...

comment:7 in reply to: ↑ 6 Changed 9 months ago by mkoeppe

Replying to mkoeppe:

But we'll need another ticket then to actually fix the nonportability of the build...

That's now #31565.

comment:8 Changed 8 months ago by vbraun

  • Branch changed from public/31521 to 128e8ef688fe3cba05b19f39e469cf3832be1e4a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.