Opened 21 months ago
Closed 19 months ago
#31514 closed enhancement (fixed)
number_field_elements_from_algebraics with complex embeddings
Reported by: | Markus Wageringel | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.4 |
Component: | number fields | Keywords: | qqbar |
Cc: | Jean-Philippe Labbé, Vincent Delecroix, John Cremona | Merged in: | |
Authors: | Markus Wageringel | Reviewers: | Vincent Delecroix |
Report Upstream: | N/A | Work issues: | |
Branch: | d726429 (Commits, GitHub, GitLab) | Commit: | d7264299ad02e86ca8891471eeb6368e9d6be2f7 |
Dependencies: | Stopgaps: |
Description
Currently, number_field_elements_from_algebraics
only implements the embedded
parameter if all the elements are real. This ticket extends this to number fields with embedding of (non-real) algebraic numbers.
sage: K, (ii, rt2), hom = number_field_elements_from_algebraics([QQbar(I), sqrt(2)], embedded=True) sage: K Number Field in a with defining polynomial y^4 + 1 with a = -0.7071067811865475? + 0.7071067811865475?*I sage: QQbar(ii), QQbar(rt2) (0.?e-19 + 1.000000000000000?*I, 1.414213562373095? + 0.?e-18*I)
In particular, this is useful for conversions from QQbar
to the number field, which requires an embedding.
Change History (6)
comment:1 Changed 21 months ago by
Authors: | → Markus Wageringel |
---|---|
Branch: | → u/gh-mwageringel/31514 |
Cc: | Jean-Philippe Labbé Vincent Delecroix added |
Commit: | → d7264299ad02e86ca8891471eeb6368e9d6be2f7 |
Status: | new → needs_review |
comment:2 Changed 21 months ago by
Cc: | John Cremona added |
---|
comment:3 Changed 21 months ago by
Milestone: | sage-9.3 → sage-9.4 |
---|
Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.
comment:4 Changed 20 months ago by
Reviewers: | → Vincent Delecroix |
---|---|
Status: | needs_review → positive_review |
This is a great addition. Thanks.
comment:6 Changed 19 months ago by
Branch: | u/gh-mwageringel/31514 → d7264299ad02e86ca8891471eeb6368e9d6be2f7 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
The real case was implemented in #20181. I am not sure if there is a reason why the complex case was skipped, as the homomorphism returned by
number_field_elements_from_algebraics(..., embedded=False)
already corresponds to an embedding.New commits:
31514: allow complex embeddings in number_field_elements_from_algebraics