#31502 closed defect (fixed)

GH Actions: Free more disk space

Reported by: Matthias Köppe Owned by:
Priority: blocker Milestone: sage-9.3
Component: porting Keywords: docker
Cc: gh-kliem, Samuel Lelièvre Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 1bed9d5 (Commits, GitHub, GitLab) Commit: 1bed9d5ab1be334afb41f2552b1e99a01e3355b1
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

Some of the docker-based tests run out of disk space, for example ubuntu-focal-standard (https://github.com/mkoeppe/sage/runs/2116657496).

We uninstall some large unused preinstalled packages.

Change History (18)

comment:1 Changed 19 months ago by Samuel Lelièvre

Cc: Samuel Lelièvre added
Keywords: docker added

Possibly related: #29849.

comment:2 Changed 19 months ago by Matthias Köppe

Branch: u/mkoeppe/gh_actions__free_more_disk_space

comment:3 Changed 19 months ago by Matthias Köppe

Authors: Matthias Koeppe
Commit: 1bed9d5ab1be334afb41f2552b1e99a01e3355b1
Status: newneeds_review

New commits:

1bed9d5.github/workflows/tox*.yml: Free more disk space

comment:4 Changed 19 months ago by Matthias Köppe

Description: modified (diff)
Reviewers: https://github.com/mkoeppe/sage/runs/2127941282

This can be seen in action in https://github.com/mkoeppe/sage/runs/2127941282 (see output in "free disk space" and "install test prerequisites" - it frees about 7GB of space.

comment:5 Changed 19 months ago by Matthias Köppe

Fixes ubuntu-focal-standard - as can be seen in https://github.com/mkoeppe/sage/runs/2135025352

comment:6 Changed 18 months ago by gh-kliem

Reviewers: https://github.com/mkoeppe/sage/runs/2127941282Jonathan Kliem
Status: needs_reviewpositive_review

LGTM.

comment:7 Changed 18 months ago by Matthias Köppe

Thanks!

comment:8 Changed 18 months ago by Matthias Köppe

Priority: criticalblocker

Setting priority to blocker to bring this ticket to the attention of the release bot.

comment:9 Changed 18 months ago by Volker Braun

Priority: blockermajor

comment:10 Changed 18 months ago by Matthias Köppe

Priority: majorblocker

Obviously a blocker because it blocks us from demonstrating that Sage builds and tests correctly on the supported platform ubuntu-focal-standard.

comment:11 in reply to:  10 Changed 18 months ago by gh-kliem

Replying to mkoeppe:

Obviously a blocker because it blocks us from demonstrating that Sage builds and tests correctly on the supported platform ubuntu-focal-standard.

This ticket only changes files in .github/workflows/ This ticket can't break anything but the github workflows itself (and it doesn't break those).

comment:12 Changed 18 months ago by Volker Braun

How likely it is to break things is the wrong question. Instead, ask yourself: Is this ticket important enough so that everyone else's ticket should wait another week before it can get merged, so we can have an additional rc round.

comment:13 Changed 18 months ago by Matthias Köppe

Yes, a fully working portability testing infrastructure is crucial to making a release that will be in use for the next 1/2 year.

comment:14 Changed 18 months ago by Matthias Köppe

Here's an idea: If a positively reviewed ticket only modifies /.github/ or /tox.ini, just merge it and don't count it to whatever batch size or limits you use in your merge scripts. -- After all, your build scripts do not test anything involving these files.

Last edited 18 months ago by Matthias Köppe (previous) (diff)

comment:15 Changed 18 months ago by Matthias Köppe

The same idea would probably also apply to /.ci/, /.circleci/, /.gitlab-ci.yml, and /docker/ -- except these see a lot less activity as the maintainers seem to have disappeared.

comment:16 Changed 18 months ago by Volker Braun

Look, I appreciate what you are doing. But you need more frequent releases, not a more drawn-out release process so we can wait until everyone has their pet ticket merged.

comment:17 Changed 18 months ago by Matthias Köppe

Volker, I had hoped for a substantial response to comments 14/15.

comment:18 Changed 18 months ago by Volker Braun

Branch: u/mkoeppe/gh_actions__free_more_disk_space1bed9d5ab1be334afb41f2552b1e99a01e3355b1
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.