#31497 closed enhancement (fixed)

fix some annotations and flake8 E702

Reported by: Frédéric Chapoton Owned by:
Priority: minor Milestone: sage-9.3
Component: refactoring Keywords:
Cc: Travis Scrimshaw, Samuel Lelièvre Merged in:
Authors: Frédéric Chapoton Reviewers: Samuel Lelièvre
Report Upstream: N/A Work issues:
Branch: 427584c (Commits, GitHub, GitLab) Commit: 427584cfa54eb8d52d847eae7ca863aee61433a7
Dependencies: Stopgaps:

Status badges

Description

  • annotations should not use "Integral"
  • E702 is about avoiding multiple statements on one line

Change History (8)

comment:1 Changed 21 months ago by Frédéric Chapoton

Branch: u/chapoton/31497
Commit: d2f2542cafeefd8680a397ffcff60f7004257170
Status: newneeds_review

New commits:

d2f2542fix some annotations and flake8 E702

comment:2 Changed 21 months ago by git

Commit: d2f2542cafeefd8680a397ffcff60f7004257170427584cfa54eb8d52d847eae7ca863aee61433a7

Branch pushed to git repo; I updated commit sha1. New commits:

427584cfix further details

comment:3 Changed 21 months ago by Frédéric Chapoton

Cc: Travis Scrimshaw Samuel Lelièvre added

green bot, please review

comment:4 Changed 21 months ago by Samuel Lelièvre

Status: needs_reviewpositive_review

D'accord. Une référence concernant "Integer" vs "Integral"?

comment:5 Changed 21 months ago by Matthias Köppe

Reviewers: Samuel Lelièvre

comment:6 Changed 21 months ago by Frédéric Chapoton

comment:7 Changed 21 months ago by Frédéric Chapoton

comment:8 Changed 21 months ago by Volker Braun

Branch: u/chapoton/31497427584cfa54eb8d52d847eae7ca863aee61433a7
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.