Opened 21 months ago
Closed 18 months ago
#31489 closed enhancement (fixed)
Galois subgroups
Reported by:  David Roe  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  number fields  Keywords:  
Cc:  Merged in:  
Authors:  David Roe  Reviewers:  Julian Rüth 
Report Upstream:  N/A  Work issues:  
Branch:  eea977a (Commits, GitHub, GitLab)  Commit:  eea977a587068c2c112deaa464421be02ae52485 
Dependencies:  #31469  Stopgaps: 
Description
Subgroups of Galois groups should inherit from Permgroup_subgroup rather than GaloisGroup_v2
Change History (17)
comment:1 Changed 21 months ago by
Branch:  → u/roed/galois_sub 

comment:2 Changed 21 months ago by
Authors:  → David Roe 

Commit:  → 70c7f92a4a1312f5cd742133ca94197a8023b14b 
Status:  new → needs_review 
Type:  defect → enhancement 
comment:3 Changed 21 months ago by
Commit:  70c7f92a4a1312f5cd742133ca94197a8023b14b → 747a934915fc8c4e0d67471831b4dbfc583728fe 

comment:4 Changed 21 months ago by
Commit:  747a934915fc8c4e0d67471831b4dbfc583728fe → cfb6a78952c4f566affe384fa6e168c2e52e0883 

comment:5 Changed 21 months ago by
Commit:  cfb6a78952c4f566affe384fa6e168c2e52e0883 → 539b0ca5eb4280958d54c8c9734fc6be47387d20 

Branch pushed to git repo; I updated commit sha1. New commits:
539b0ca  Fix some test failures, factor _GaloisMixin for subgrous

comment:6 Changed 21 months ago by
Commit:  539b0ca5eb4280958d54c8c9734fc6be47387d20 → 61873da0d4af1854950834b926f3344c3b842e16 

Branch pushed to git repo; I updated commit sha1. New commits:
61873da  Fix bitsize

comment:7 Changed 20 months ago by
Milestone:  sage9.3 → sage9.4 

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.
comment:8 Changed 19 months ago by
Commit:  61873da0d4af1854950834b926f3344c3b842e16 → 44702c545badda7f83dd0a9fcbc789019540dd97 

comment:9 Changed 19 months ago by
Commit:  44702c545badda7f83dd0a9fcbc789019540dd97 → ba5c86833622be7ae08bf232eb4f10e7d507392f 

comment:10 Changed 19 months ago by
Reviewers:  → Julian Rüth 

Status:  needs_review → needs_work 
I put some minor comments at https://github.com/sagemath/sagetracmirror/pull/1#pullrequestreview653876822.
comment:11 Changed 19 months ago by
I don't think anything I wrote there is really important. If you feel lazy about any of these, feel free to ignore a comment ;)
comment:12 Changed 19 months ago by
Commit:  ba5c86833622be7ae08bf232eb4f10e7d507392f → a33705e5081eed32eedc3754971e57beb748a8ac 

Branch pushed to git repo; I updated commit sha1. New commits:
a33705e  Reviewer suggestions

comment:13 Changed 19 months ago by
Status:  needs_work → needs_review 

comment:14 Changed 19 months ago by
Commit:  a33705e5081eed32eedc3754971e57beb748a8ac → eea977a587068c2c112deaa464421be02ae52485 

Branch pushed to git repo; I updated commit sha1. New commits:
eea977a  Add utf line back in, remove sage: from doctest

comment:15 Changed 18 months ago by
Status:  needs_review → positive_review 

comment:16 Changed 18 months ago by
I know I am slightly late to the party, but I think this is a better idiom since it is more robust: (You don't need to change this if this remains at a positive review.)
 if category is None:  category = Groups().Commutative() + category = Groups().Commutative().or_subcategory(category)
Also, the patchbot reports an error with 9.4.beta0:
********************************************************************** File "src/sage/graphs/graph.py", line 2713, in sage.graphs.graph.Graph.is_edge_transitive Failed example: C.is_edge_transitive() Exception raised: Traceback (most recent call last): File "/home/sagepatchbot/sage/local/lib/python3.8/sitepackages/sage/doctest/forker.py", line 714, in _run self.compile_and_execute(example, compiler, test.globs) File "/home/sagepatchbot/sage/local/lib/python3.8/sitepackages/sage/doctest/forker.py", line 1133, in compile_and_execute exec(compiled, globs) File "<doctest sage.graphs.graph.Graph.is_edge_transitive[3]>", line 1, in <module> C.is_edge_transitive() File "/home/sagepatchbot/sage/local/lib/python3.8/sitepackages/sage/graphs/graph.py", line 2731, in is_edge_transitive return libgap(A).OrbitLength(e, libgap.OnSets) == self.size() File "sage/libs/gap/element.pyx", line 2677, in sage.libs.gap.element.GapElement_MethodProxy.__call__ (build/cythonized/sage/libs/gap/element.c:20775) return GapElement_Function.__call__(self, * ([self.first_argument] + list(args))) File "sage/libs/gap/element.pyx", line 2525, in sage.libs.gap.element.GapElement_Function.__call__ (build/cythonized/sage/libs/gap/element.c:19779) sig_on() sage.libs.gap.util.GAPError: Error, OnSets: <set> must be a set (not a immutable nonstrictlysorted plain list of cyclotomics)
Is this an actual error?
comment:17 Changed 18 months ago by
Branch:  u/roed/galois_sub → eea977a587068c2c112deaa464421be02ae52485 

Resolution:  → fixed 
Status:  positive_review → closed 
Last 10 new commits:
Working on Galois groups of finite fields
Working on Galois groups of finite fields
Working on subfields of finite fields
Fix test failure, documentation in algebraic closure
Merge branch 'u/roed/subfields' of git://trac.sagemath.org/sage into t/31469/gf_galois
Choose default variable name in subfield, as in subfields
Merge branch 't/23801/subfields' into t/31469/gf_galois
Refactor galois groups for abelian groups
Fix pyflakes, coverage
Change how Galois subgroups print, add categories for subgroups, change subgroup inheritance around, etc