Opened 11 months ago

Closed 8 months ago

#31489 closed enhancement (fixed)

Galois subgroups

Reported by: roed Owned by:
Priority: major Milestone: sage-9.4
Component: number fields Keywords:
Cc: Merged in:
Authors: David Roe Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: eea977a (Commits, GitHub, GitLab) Commit: eea977a587068c2c112deaa464421be02ae52485
Dependencies: #31469 Stopgaps:

Status badges

Description

Subgroups of Galois groups should inherit from Permgroup_subgroup rather than GaloisGroup_v2

Change History (17)

comment:1 Changed 10 months ago by roed

  • Branch set to u/roed/galois_sub

comment:2 Changed 10 months ago by roed

  • Authors set to David Roe
  • Commit set to 70c7f92a4a1312f5cd742133ca94197a8023b14b
  • Status changed from new to needs_review
  • Type changed from defect to enhancement

Last 10 new commits:

ea5b428Working on Galois groups of finite fields
4b67449Working on Galois groups of finite fields
02e858bWorking on subfields of finite fields
cf896f3Fix test failure, documentation in algebraic closure
424a96eMerge branch 'u/roed/subfields' of git://trac.sagemath.org/sage into t/31469/gf_galois
c80ede2Choose default variable name in subfield, as in subfields
57dc39bMerge branch 't/23801/subfields' into t/31469/gf_galois
7937212Refactor galois groups for abelian groups
b3fcfc5Fix pyflakes, coverage
70c7f92Change how Galois subgroups print, add categories for subgroups, change subgroup inheritance around, etc

comment:3 Changed 10 months ago by git

  • Commit changed from 70c7f92a4a1312f5cd742133ca94197a8023b14b to 747a934915fc8c4e0d67471831b4dbfc583728fe

Branch pushed to git repo; I updated commit sha1. New commits:

1c99275Merge branch 'develop' into t/31469/gf_galois
747a934Merge branch 't/31469/gf_galois' into t/31489/galois_sub

comment:4 Changed 10 months ago by git

  • Commit changed from 747a934915fc8c4e0d67471831b4dbfc583728fe to cfb6a78952c4f566affe384fa6e168c2e52e0883

Branch pushed to git repo; I updated commit sha1. New commits:

a1b793eFix pyflakes, add example of polred to fixed_field for galois groups
cfb6a78Fix test failure and other plugin problems

comment:5 Changed 10 months ago by git

  • Commit changed from cfb6a78952c4f566affe384fa6e168c2e52e0883 to 539b0ca5eb4280958d54c8c9734fc6be47387d20

Branch pushed to git repo; I updated commit sha1. New commits:

539b0caFix some test failures, factor _GaloisMixin for subgrous

comment:6 Changed 10 months ago by git

  • Commit changed from 539b0ca5eb4280958d54c8c9734fc6be47387d20 to 61873da0d4af1854950834b926f3344c3b842e16

Branch pushed to git repo; I updated commit sha1. New commits:

61873daFix bitsize

comment:7 Changed 10 months ago by mkoeppe

  • Milestone changed from sage-9.3 to sage-9.4

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

comment:8 Changed 9 months ago by git

  • Commit changed from 61873da0d4af1854950834b926f3344c3b842e16 to 44702c545badda7f83dd0a9fcbc789019540dd97

Branch pushed to git repo; I updated commit sha1. New commits:

24cf4ddReviewer suggestions
225e1d2Merge branch 't/31469/gf_galois' into t/31489/galois_sub
44702c5Add some comments for attributes required by galois mixin classes

comment:9 Changed 9 months ago by git

  • Commit changed from 44702c545badda7f83dd0a9fcbc789019540dd97 to ba5c86833622be7ae08bf232eb4f10e7d507392f

Branch pushed to git repo; I updated commit sha1. New commits:

f09750dFix a bug with relative number field Galois groups
ba5c868Merge branch 't/31469/gf_galois' into t/31489/galois_sub

comment:10 Changed 9 months ago by saraedum

  • Reviewers set to Julian Rüth
  • Status changed from needs_review to needs_work

comment:11 Changed 9 months ago by saraedum

I don't think anything I wrote there is really important. If you feel lazy about any of these, feel free to ignore a comment ;)

comment:12 Changed 9 months ago by git

  • Commit changed from ba5c86833622be7ae08bf232eb4f10e7d507392f to a33705e5081eed32eedc3754971e57beb748a8ac

Branch pushed to git repo; I updated commit sha1. New commits:

a33705eReviewer suggestions

comment:13 Changed 9 months ago by roed

  • Status changed from needs_work to needs_review

comment:14 Changed 9 months ago by git

  • Commit changed from a33705e5081eed32eedc3754971e57beb748a8ac to eea977a587068c2c112deaa464421be02ae52485

Branch pushed to git repo; I updated commit sha1. New commits:

eea977aAdd utf line back in, remove sage: from doctest

comment:15 Changed 8 months ago by saraedum

  • Status changed from needs_review to positive_review

comment:16 Changed 8 months ago by tscrim

I know I am slightly late to the party, but I think this is a better idiom since it is more robust: (You don't need to change this if this remains at a positive review.)

-        if category is None:
-            category = Groups().Commutative()
+        category = Groups().Commutative().or_subcategory(category)

Also, the patchbot reports an error with 9.4.beta0:

**********************************************************************
File "src/sage/graphs/graph.py", line 2713, in sage.graphs.graph.Graph.is_edge_transitive
Failed example:
    C.is_edge_transitive()
Exception raised:
    Traceback (most recent call last):
      File "/home/sage-patchbot/sage/local/lib/python3.8/site-packages/sage/doctest/forker.py", line 714, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/home/sage-patchbot/sage/local/lib/python3.8/site-packages/sage/doctest/forker.py", line 1133, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.graphs.graph.Graph.is_edge_transitive[3]>", line 1, in <module>
        C.is_edge_transitive()
      File "/home/sage-patchbot/sage/local/lib/python3.8/site-packages/sage/graphs/graph.py", line 2731, in is_edge_transitive
        return libgap(A).OrbitLength(e, libgap.OnSets) == self.size()
      File "sage/libs/gap/element.pyx", line 2677, in sage.libs.gap.element.GapElement_MethodProxy.__call__ (build/cythonized/sage/libs/gap/element.c:20775)
        return GapElement_Function.__call__(self, * ([self.first_argument] + list(args)))
      File "sage/libs/gap/element.pyx", line 2525, in sage.libs.gap.element.GapElement_Function.__call__ (build/cythonized/sage/libs/gap/element.c:19779)
        sig_on()
    sage.libs.gap.util.GAPError: Error, OnSets: <set> must be a set (not a immutable non-strictly-sorted plain list of cyclotomics)

Is this an actual error?

Last edited 8 months ago by tscrim (previous) (diff)

comment:17 Changed 8 months ago by vbraun

  • Branch changed from u/roed/galois_sub to eea977a587068c2c112deaa464421be02ae52485
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.