#31476 closed defect (fixed)

Downgrade ipython to 7.16.x and jedi to 0.17.x to restore Python 3.6 support (ubuntu-bionic-standard)

Reported by: Matthias Köppe Owned by:
Priority: blocker Milestone: sage-9.3
Component: packages: standard Keywords:
Cc: gh-kliem Merged in:
Authors: Matthias Koeppe, Jonathan Kliem Reviewers: Jonathan Kliem, Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 50084a8 (Commits, GitHub, GitLab) Commit: 50084a85f9a29bb8df924f46a8069e9f874fd192
Dependencies: #31373 Stopgaps:

Status badges

Description

(from #31373)

Attachments (1)

Sage_crash_report.txt (42.3 KB) - added by gh-kliem 21 months ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 21 months ago by Matthias Köppe

Branch: u/mkoeppe/downgrade_ipython_to_7_16_x_to_restore_python_3_6_support__ubuntu_bionic_standard_

comment:2 Changed 21 months ago by Matthias Köppe

Authors: Matthias Koeppe
Commit: 140af6ababe30d86f44ee6dfc2706d94d6a2fb59
Status: newneeds_review

New commits:

3b7d7e5upgrade jedi and ipython
b48a79bMerge #31373
140af6abuild/pkgs/ipython: Downgrade to 7.16.1

comment:3 Changed 21 months ago by Matthias Köppe

Dependencies: #31373

comment:4 Changed 21 months ago by gh-kliem

Status: needs_reviewneeds_work

This ticket breaks it completely.

I can't tab-complete anymore and if I try it get and awful error with a hard crash of sage.

Changed 21 months ago by gh-kliem

Attachment: Sage_crash_report.txt added

comment:6 Changed 21 months ago by gh-kliem

Should downgrade jedi to 0.17.0 again.

I will open a seperate ticket to address the issues of #31373.

comment:7 Changed 21 months ago by gh-kliem

Branch: u/mkoeppe/downgrade_ipython_to_7_16_x_to_restore_python_3_6_support__ubuntu_bionic_standard_u/gh-kliem/downgrade_ipython_to_7_16_x_to_restore_python_3_6_support__ubuntu_bionic_standard_
Commit: 140af6ababe30d86f44ee6dfc2706d94d6a2fb59468a828d04a12a08de39435ac2f3b86c9a83d017
Status: needs_workneeds_review

New commits:

468a828downgrade jedi, as 0.18.0 is supported only by ipython 7.18.1 and higher

comment:8 Changed 21 months ago by gh-kliem

Summary: Downgrade ipython to 7.16.x to restore Python 3.6 support (ubuntu-bionic-standard)Downgrade ipython to 7.16.x and jedi to 0.17.0 to restore Python 3.6 support (ubuntu-bionic-standard)

comment:9 Changed 21 months ago by gh-kliem

Reviewers: https://github.com/kliem/sage/pull/42/checks

comment:10 Changed 21 months ago by Matthias Köppe

Authors: Matthias KoeppeMatthias Koeppe, Jonathan Kliem

comment:11 Changed 21 months ago by Matthias Köppe

Shouldn't we use jedi 0.17.2 then?

comment:12 Changed 21 months ago by gh-kliem

Yes. I just didn't check and assumed that 0.17.0 is below 0.18.0. 0.17.2 mentions python 3.9 support, so that's a plus.

comment:13 Changed 21 months ago by Matthias Köppe

Branch: u/gh-kliem/downgrade_ipython_to_7_16_x_to_restore_python_3_6_support__ubuntu_bionic_standard_u/mkoeppe/downgrade_ipython_to_7_16_x_to_restore_python_3_6_support__ubuntu_bionic_standard_

comment:14 Changed 21 months ago by Matthias Köppe

Commit: 468a828d04a12a08de39435ac2f3b86c9a83d01750084a85f9a29bb8df924f46a8069e9f874fd192
Summary: Downgrade ipython to 7.16.x and jedi to 0.17.0 to restore Python 3.6 support (ubuntu-bionic-standard)Downgrade ipython to 7.16.x and jedi to 0.17.x to restore Python 3.6 support (ubuntu-bionic-standard)

New commits:

50084a8build/pkgs/jedi: Update to 0.17.2

comment:15 Changed 21 months ago by gh-kliem

Everything passes on my side and the interface looks as expected.

comment:16 Changed 21 months ago by Matthias Köppe

Reviewers: https://github.com/kliem/sage/pull/42/checks..., Matthias Koeppe

Also works for me. Positive review from my side.

comment:17 Changed 21 months ago by gh-kliem

Reviewers: ..., Matthias KoeppeJonathan Kliem, Matthias Koeppe
Status: needs_reviewpositive_review

LGTM.

comment:18 Changed 21 months ago by Volker Braun

Branch: u/mkoeppe/downgrade_ipython_to_7_16_x_to_restore_python_3_6_support__ubuntu_bionic_standard_50084a85f9a29bb8df924f46a8069e9f874fd192
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.